All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-tegra@vger.kernel.org
Subject: [PATCH 20/26] drm: tegra: Remove #ifdef guards for PM related functions
Date: Mon,  7 Nov 2022 17:52:50 +0000	[thread overview]
Message-ID: <20221107175256.360839-10-paul@crapouillou.net> (raw)
In-Reply-To: <20221107175256.360839-1-paul@crapouillou.net>

Use the RUNTIME_PM_OPS() and pm_ptr() macros to handle the
.runtime_suspend/.runtime_resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_PM is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Note that this driver should probably use the
DEFINE_RUNTIME_DEV_PM_OPS() macro instead, which will provide
.suspend/.resume callbacks, pointing to pm_runtime_force_suspend() and
pm_runtime_force_resume() respectively; unless those callbacks really
aren't needed.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
---
 drivers/gpu/drm/tegra/dpaux.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 7dc681e2ee90..3c84e73d5051 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -598,7 +598,6 @@ static int tegra_dpaux_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
 static int tegra_dpaux_suspend(struct device *dev)
 {
 	struct tegra_dpaux *dpaux = dev_get_drvdata(dev);
@@ -657,10 +656,9 @@ static int tegra_dpaux_resume(struct device *dev)
 	clk_disable_unprepare(dpaux->clk);
 	return err;
 }
-#endif
 
 static const struct dev_pm_ops tegra_dpaux_pm_ops = {
-	SET_RUNTIME_PM_OPS(tegra_dpaux_suspend, tegra_dpaux_resume, NULL)
+	RUNTIME_PM_OPS(tegra_dpaux_suspend, tegra_dpaux_resume, NULL)
 };
 
 static const struct tegra_dpaux_soc tegra124_dpaux_soc = {
@@ -694,7 +692,7 @@ struct platform_driver tegra_dpaux_driver = {
 	.driver = {
 		.name = "tegra-dpaux",
 		.of_match_table = tegra_dpaux_of_match,
-		.pm = &tegra_dpaux_pm_ops,
+		.pm = pm_ptr(&tegra_dpaux_pm_ops),
 	},
 	.probe = tegra_dpaux_probe,
 	.remove = tegra_dpaux_remove,
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Paul Cercueil <paul@crapouillou.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org
Subject: [PATCH 20/26] drm: tegra: Remove #ifdef guards for PM related functions
Date: Mon,  7 Nov 2022 17:52:50 +0000	[thread overview]
Message-ID: <20221107175256.360839-10-paul@crapouillou.net> (raw)
In-Reply-To: <20221107175256.360839-1-paul@crapouillou.net>

Use the RUNTIME_PM_OPS() and pm_ptr() macros to handle the
.runtime_suspend/.runtime_resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_PM is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Note that this driver should probably use the
DEFINE_RUNTIME_DEV_PM_OPS() macro instead, which will provide
.suspend/.resume callbacks, pointing to pm_runtime_force_suspend() and
pm_runtime_force_resume() respectively; unless those callbacks really
aren't needed.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
---
 drivers/gpu/drm/tegra/dpaux.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 7dc681e2ee90..3c84e73d5051 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -598,7 +598,6 @@ static int tegra_dpaux_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM
 static int tegra_dpaux_suspend(struct device *dev)
 {
 	struct tegra_dpaux *dpaux = dev_get_drvdata(dev);
@@ -657,10 +656,9 @@ static int tegra_dpaux_resume(struct device *dev)
 	clk_disable_unprepare(dpaux->clk);
 	return err;
 }
-#endif
 
 static const struct dev_pm_ops tegra_dpaux_pm_ops = {
-	SET_RUNTIME_PM_OPS(tegra_dpaux_suspend, tegra_dpaux_resume, NULL)
+	RUNTIME_PM_OPS(tegra_dpaux_suspend, tegra_dpaux_resume, NULL)
 };
 
 static const struct tegra_dpaux_soc tegra124_dpaux_soc = {
@@ -694,7 +692,7 @@ struct platform_driver tegra_dpaux_driver = {
 	.driver = {
 		.name = "tegra-dpaux",
 		.of_match_table = tegra_dpaux_of_match,
-		.pm = &tegra_dpaux_pm_ops,
+		.pm = pm_ptr(&tegra_dpaux_pm_ops),
 	},
 	.probe = tegra_dpaux_probe,
 	.remove = tegra_dpaux_remove,
-- 
2.35.1


  parent reply	other threads:[~2022-11-07 17:54 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 17:50 [PATCH 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Paul Cercueil
2022-11-07 17:50 ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 01/26] drm: modeset-helper: Export dev_pm_ops for simple drivers Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-08 12:10   ` Thomas Zimmermann
2022-11-08 12:10     ` Thomas Zimmermann
2022-11-08 12:33     ` Paul Cercueil
2022-11-08 12:33       ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 02/26] drm: bochs: Use the dev_pm_ops provided by modeset helper Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 03/26] drm: imx: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 04/26] drm: rockchip: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 05/26] drm: tegra: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 06/26] drm: sun4i: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-14  0:34   ` Samuel Holland
2022-11-14  0:34     ` Samuel Holland
2022-11-14  0:34     ` Samuel Holland
2022-11-07 17:50 ` [PATCH 07/26] drm: msxfb: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50 ` [PATCH 08/26] drm: atmel-hlcdc: Remove #ifdef guards for PM related functions Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:53   ` Sam Ravnborg
2022-11-07 17:53     ` Sam Ravnborg
2022-11-07 17:53     ` Sam Ravnborg
2022-11-10 15:28   ` Claudiu.Beznea
2022-11-10 15:28     ` Claudiu.Beznea
2022-11-10 15:28     ` Claudiu.Beznea
2022-11-07 17:50 ` [PATCH 09/26] drm: exynos: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-21  4:25   ` Inki Dae
2022-11-21  4:25     ` Inki Dae
2022-11-21  4:25     ` Inki Dae
2022-11-07 17:50 ` [PATCH 10/26] drm: imx/dcss: " Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-07 17:50   ` Paul Cercueil
2022-11-11 14:27   ` Laurentiu Palcu
2022-11-11 14:27     ` Laurentiu Palcu
2022-11-11 14:27     ` Laurentiu Palcu
2022-11-07 17:52 ` [PATCH 11/26] drm: bridge/dw-hdmi: " Paul Cercueil
2022-11-07 17:52   ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 12/26] drm: etnaviv: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 18:07     ` Lucas Stach
2022-11-07 18:07       ` Lucas Stach
2022-11-07 21:03       ` Paul Cercueil
2022-11-07 21:03         ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 13/26] drm: fsl-dcu: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 14/26] drm: mediatek: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 15/26] drm: omap: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 16/26] drm: panfrost: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-09 15:16     ` Steven Price
2022-11-09 15:16       ` Steven Price
2022-11-07 17:52   ` [PATCH 17/26] drm: rcar-du: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-16 13:41     ` Kieran Bingham
2022-11-16 13:41       ` Kieran Bingham
2022-11-07 17:52   ` [PATCH 18/26] drm: rockchip: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 19/26] drm: shmobile: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-16 13:41     ` Kieran Bingham
2022-11-16 13:41       ` Kieran Bingham
2022-11-07 17:52   ` Paul Cercueil [this message]
2022-11-07 17:52     ` [PATCH 20/26] drm: tegra: " Paul Cercueil
2022-11-07 17:52   ` [PATCH 21/26] drm: tilcdc: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 17:52   ` [PATCH 22/26] drm: vboxvideo: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 19:43     ` Hans de Goede
2022-11-07 19:43       ` Hans de Goede
2022-11-07 17:52   ` [PATCH 23/26] drm: vc4: " Paul Cercueil
2022-11-07 17:52     ` Paul Cercueil
2022-11-07 20:27   ` [PATCH 21/26] drm: tilcdc: " sarha
2022-11-07 20:27     ` sarha
2022-11-07 17:55 ` [PATCH 24/26] drm: gm12u320: " Paul Cercueil
2022-11-07 17:55   ` Paul Cercueil
2022-11-07 17:55   ` [PATCH 25/26] drm: tidss: " Paul Cercueil
2022-11-07 17:55     ` Paul Cercueil
2022-11-07 17:55   ` [PATCH 26/26] drm/i915/gt: " Paul Cercueil
2022-11-07 17:55     ` [Intel-gfx] " Paul Cercueil
2022-11-07 17:55     ` Paul Cercueil
2022-11-07 20:31     ` Rodrigo Vivi
2022-11-07 20:31       ` [Intel-gfx] " Rodrigo Vivi
2022-11-07 20:31       ` Rodrigo Vivi
2022-11-07 20:59       ` Paul Cercueil
2022-11-07 20:59         ` [Intel-gfx] " Paul Cercueil
2022-11-07 20:59         ` Paul Cercueil
2022-11-07 19:43   ` [PATCH 24/26] drm: gm12u320: " Hans de Goede
2022-11-07 19:43     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107175256.360839-10-paul@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.