From: Paul Cercueil <paul@crapouillou.net> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil <paul@crapouillou.net> Subject: [PATCH 01/26] drm: modeset-helper: Export dev_pm_ops for simple drivers Date: Mon, 7 Nov 2022 17:50:41 +0000 [thread overview] Message-ID: <20221107175106.360578-2-paul@crapouillou.net> (raw) In-Reply-To: <20221107175106.360578-1-paul@crapouillou.net> Export a dev_pm_ops meant to be used with simple drivers, which have their struct drm_device registered as their struct device's drvdata, and only call drm_mode_config_pm_{suspend,resume}. The symbol is conditionally exported if IS_ENABLED(CONFIG_PM_SLEEP), and therefore it should always be referenced using the pm_sleep_ptr() macro. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/gpu/drm/drm_modeset_helper.c | 32 ++++++++++++++++++++++++++++ include/drm/drm_modeset_helper.h | 4 ++++ 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c index f858dfedf2cf..0bc9f9228a60 100644 --- a/drivers/gpu/drm/drm_modeset_helper.c +++ b/drivers/gpu/drm/drm_modeset_helper.c @@ -20,6 +20,9 @@ * OF THIS SOFTWARE. */ +#include <linux/device.h> +#include <linux/pm.h> + #include <drm/drm_atomic_helper.h> #include <drm/drm_fb_helper.h> #include <drm/drm_fourcc.h> @@ -244,3 +247,32 @@ int drm_mode_config_helper_resume(struct drm_device *dev) return ret; } EXPORT_SYMBOL(drm_mode_config_helper_resume); + +static int drm_mode_config_pm_suspend(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + + return drm_mode_config_helper_suspend(drm); +} + +static int drm_mode_config_pm_resume(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + + return drm_mode_config_helper_resume(drm); +} + +/** + * drm_mode_config_pm_ops - Exported dev_pm_ops helper for simple drivers + * + * This dev_pm_ops can be used for simple drivers that would otherwise only call + * drm_mode_config_helper_suspend / drm_mode_config_helper_resume in their PM + * callbacks. It is only valid if the driver's drm_device has been registered as + * the struct device's drvdata. + * + * The exported symbol must always be used with the pm_sleep_ptr() macro, like + * this: + * .pm = pm_sleep_ptr(&drm_mode_config_pm_ops), + */ +EXPORT_SIMPLE_DEV_PM_OPS(drm_mode_config_pm_ops, + drm_mode_config_pm_suspend, drm_mode_config_pm_resume); diff --git a/include/drm/drm_modeset_helper.h b/include/drm/drm_modeset_helper.h index 995fd981cab0..85f29637e9c1 100644 --- a/include/drm/drm_modeset_helper.h +++ b/include/drm/drm_modeset_helper.h @@ -23,6 +23,8 @@ #ifndef __DRM_KMS_HELPER_H__ #define __DRM_KMS_HELPER_H__ +#include <linux/pm.h> + struct drm_crtc; struct drm_crtc_funcs; struct drm_device; @@ -41,4 +43,6 @@ int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, int drm_mode_config_helper_suspend(struct drm_device *dev); int drm_mode_config_helper_resume(struct drm_device *dev); +extern const struct dev_pm_ops drm_mode_config_pm_ops; + #endif -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: Paul Cercueil <paul@crapouillou.net>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 01/26] drm: modeset-helper: Export dev_pm_ops for simple drivers Date: Mon, 7 Nov 2022 17:50:41 +0000 [thread overview] Message-ID: <20221107175106.360578-2-paul@crapouillou.net> (raw) In-Reply-To: <20221107175106.360578-1-paul@crapouillou.net> Export a dev_pm_ops meant to be used with simple drivers, which have their struct drm_device registered as their struct device's drvdata, and only call drm_mode_config_pm_{suspend,resume}. The symbol is conditionally exported if IS_ENABLED(CONFIG_PM_SLEEP), and therefore it should always be referenced using the pm_sleep_ptr() macro. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/gpu/drm/drm_modeset_helper.c | 32 ++++++++++++++++++++++++++++ include/drm/drm_modeset_helper.h | 4 ++++ 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c index f858dfedf2cf..0bc9f9228a60 100644 --- a/drivers/gpu/drm/drm_modeset_helper.c +++ b/drivers/gpu/drm/drm_modeset_helper.c @@ -20,6 +20,9 @@ * OF THIS SOFTWARE. */ +#include <linux/device.h> +#include <linux/pm.h> + #include <drm/drm_atomic_helper.h> #include <drm/drm_fb_helper.h> #include <drm/drm_fourcc.h> @@ -244,3 +247,32 @@ int drm_mode_config_helper_resume(struct drm_device *dev) return ret; } EXPORT_SYMBOL(drm_mode_config_helper_resume); + +static int drm_mode_config_pm_suspend(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + + return drm_mode_config_helper_suspend(drm); +} + +static int drm_mode_config_pm_resume(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + + return drm_mode_config_helper_resume(drm); +} + +/** + * drm_mode_config_pm_ops - Exported dev_pm_ops helper for simple drivers + * + * This dev_pm_ops can be used for simple drivers that would otherwise only call + * drm_mode_config_helper_suspend / drm_mode_config_helper_resume in their PM + * callbacks. It is only valid if the driver's drm_device has been registered as + * the struct device's drvdata. + * + * The exported symbol must always be used with the pm_sleep_ptr() macro, like + * this: + * .pm = pm_sleep_ptr(&drm_mode_config_pm_ops), + */ +EXPORT_SIMPLE_DEV_PM_OPS(drm_mode_config_pm_ops, + drm_mode_config_pm_suspend, drm_mode_config_pm_resume); diff --git a/include/drm/drm_modeset_helper.h b/include/drm/drm_modeset_helper.h index 995fd981cab0..85f29637e9c1 100644 --- a/include/drm/drm_modeset_helper.h +++ b/include/drm/drm_modeset_helper.h @@ -23,6 +23,8 @@ #ifndef __DRM_KMS_HELPER_H__ #define __DRM_KMS_HELPER_H__ +#include <linux/pm.h> + struct drm_crtc; struct drm_crtc_funcs; struct drm_device; @@ -41,4 +43,6 @@ int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, int drm_mode_config_helper_suspend(struct drm_device *dev); int drm_mode_config_helper_resume(struct drm_device *dev); +extern const struct dev_pm_ops drm_mode_config_pm_ops; + #endif -- 2.35.1
next prev parent reply other threads:[~2022-11-07 17:51 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-07 17:50 [PATCH 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil [this message] 2022-11-07 17:50 ` [PATCH 01/26] drm: modeset-helper: Export dev_pm_ops for simple drivers Paul Cercueil 2022-11-08 12:10 ` Thomas Zimmermann 2022-11-08 12:10 ` Thomas Zimmermann 2022-11-08 12:33 ` Paul Cercueil 2022-11-08 12:33 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 02/26] drm: bochs: Use the dev_pm_ops provided by modeset helper Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 03/26] drm: imx: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 04/26] drm: rockchip: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 05/26] drm: tegra: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 06/26] drm: sun4i: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-14 0:34 ` Samuel Holland 2022-11-14 0:34 ` Samuel Holland 2022-11-14 0:34 ` Samuel Holland 2022-11-07 17:50 ` [PATCH 07/26] drm: msxfb: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 08/26] drm: atmel-hlcdc: Remove #ifdef guards for PM related functions Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:53 ` Sam Ravnborg 2022-11-07 17:53 ` Sam Ravnborg 2022-11-07 17:53 ` Sam Ravnborg 2022-11-10 15:28 ` Claudiu.Beznea 2022-11-10 15:28 ` Claudiu.Beznea 2022-11-10 15:28 ` Claudiu.Beznea 2022-11-07 17:50 ` [PATCH 09/26] drm: exynos: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-21 4:25 ` Inki Dae 2022-11-21 4:25 ` Inki Dae 2022-11-21 4:25 ` Inki Dae 2022-11-07 17:50 ` [PATCH 10/26] drm: imx/dcss: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-11 14:27 ` Laurentiu Palcu 2022-11-11 14:27 ` Laurentiu Palcu 2022-11-11 14:27 ` Laurentiu Palcu 2022-11-07 17:52 ` [PATCH 11/26] drm: bridge/dw-hdmi: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 12/26] drm: etnaviv: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 18:07 ` Lucas Stach 2022-11-07 18:07 ` Lucas Stach 2022-11-07 21:03 ` Paul Cercueil 2022-11-07 21:03 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 13/26] drm: fsl-dcu: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 14/26] drm: mediatek: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 15/26] drm: omap: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 16/26] drm: panfrost: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-09 15:16 ` Steven Price 2022-11-09 15:16 ` Steven Price 2022-11-07 17:52 ` [PATCH 17/26] drm: rcar-du: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-16 13:41 ` Kieran Bingham 2022-11-16 13:41 ` Kieran Bingham 2022-11-07 17:52 ` [PATCH 18/26] drm: rockchip: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 19/26] drm: shmobile: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-16 13:41 ` Kieran Bingham 2022-11-16 13:41 ` Kieran Bingham 2022-11-07 17:52 ` [PATCH 20/26] drm: tegra: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 21/26] drm: tilcdc: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 22/26] drm: vboxvideo: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 19:43 ` Hans de Goede 2022-11-07 19:43 ` Hans de Goede 2022-11-07 17:52 ` [PATCH 23/26] drm: vc4: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 20:27 ` [PATCH 21/26] drm: tilcdc: " sarha 2022-11-07 20:27 ` sarha 2022-11-07 17:55 ` [PATCH 24/26] drm: gm12u320: " Paul Cercueil 2022-11-07 17:55 ` Paul Cercueil 2022-11-07 17:55 ` [PATCH 25/26] drm: tidss: " Paul Cercueil 2022-11-07 17:55 ` Paul Cercueil 2022-11-07 17:55 ` [PATCH 26/26] drm/i915/gt: " Paul Cercueil 2022-11-07 17:55 ` [Intel-gfx] " Paul Cercueil 2022-11-07 17:55 ` Paul Cercueil 2022-11-07 20:31 ` Rodrigo Vivi 2022-11-07 20:31 ` [Intel-gfx] " Rodrigo Vivi 2022-11-07 20:31 ` Rodrigo Vivi 2022-11-07 20:59 ` Paul Cercueil 2022-11-07 20:59 ` [Intel-gfx] " Paul Cercueil 2022-11-07 20:59 ` Paul Cercueil 2022-11-07 19:43 ` [PATCH 24/26] drm: gm12u320: " Hans de Goede 2022-11-07 19:43 ` Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221107175106.360578-2-paul@crapouillou.net \ --to=paul@crapouillou.net \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.