From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Pin-yen Lin <treapking@chromium.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Daniel Scally <djrscally@gmail.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Prashant Malani <pmalani@chromium.org>, Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org> Cc: "Javier Martinez Canillas" <javierm@redhat.com>, "Stephen Boyd" <swboyd@chromium.org>, dri-devel@lists.freedesktop.org, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Thomas Zimmermann" <tzimmermann@suse.de>, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-acpi@vger.kernel.org, "Marek Vasut" <marex@denx.de>, "Xin Ji" <xji@analogixsemi.com>, "Lyude Paul" <lyude@redhat.com>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, linux-kernel@vger.kernel.org, "Allen Chen" <allen.chen@ite.com.tw> Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Date: Sun, 27 Nov 2022 21:58:21 +0100 [thread overview] Message-ID: <00cc31a2-39b1-9bb3-5b79-3c6d51cd5d51@linaro.org> (raw) In-Reply-To: <20221124102056.393220-4-treapking@chromium.org> On 24/11/2022 11:20, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > --- > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. Except missing testing few things... > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 4590186c4a0b..5fdbf1f3bab8 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -12,7 +12,8 @@ maintainers: > > description: | > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > - designed for portable devices. > + designed for portable devices. Product brief is available at > + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf > > properties: > compatible: > @@ -112,10 +113,36 @@ properties: > data-lanes: true > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/properties/port-base I don't understand why you are changing this line. > description: > Video port for panel or connector. > > + patternProperties: > + "^endpoint@[01]$": > + $ref: /schemas/media/video-interfaces.yaml# > + type: object > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 > + > + remote-endpoint: true > + > + data-lanes: > + minItems: 1 > + uniqueItems: true These are confusing... you allow only one item, so why minItems and uniqueItems? > + items: > + - enum: [ 0, 1, 2, 3] > + > + mode-switch: > + type: boolean > + description: Register this node as a Type-C mode switch or not. > + > + required: > + - reg > + - remote-endpoint > + > required: > - port@0 > - port@1 > @@ -186,3 +213,45 @@ examples: > }; > }; > }; > + - | > + &i2c3 { > + anx_bridge_dp: anx7625-dp@58 { Messed up indentation. > + compatible = "analogix,anx7625 Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation "; > + reg = <0x58>; Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Pin-yen Lin <treapking@chromium.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Daniel Scally <djrscally@gmail.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Prashant Malani <pmalani@chromium.org>, Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org> Cc: "Marek Vasut" <marex@denx.de>, devicetree@vger.kernel.org, "Nícolas F . R . A . Prado" <nfraprado@collabora.com>, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, "Javier Martinez Canillas" <javierm@redhat.com>, dri-devel@lists.freedesktop.org, "Stephen Boyd" <swboyd@chromium.org>, linux-acpi@vger.kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Xin Ji" <xji@analogixsemi.com>, "Allen Chen" <allen.chen@ite.com.tw>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com> Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Date: Sun, 27 Nov 2022 21:58:21 +0100 [thread overview] Message-ID: <00cc31a2-39b1-9bb3-5b79-3c6d51cd5d51@linaro.org> (raw) In-Reply-To: <20221124102056.393220-4-treapking@chromium.org> On 24/11/2022 11:20, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > --- > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. Except missing testing few things... > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 4590186c4a0b..5fdbf1f3bab8 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -12,7 +12,8 @@ maintainers: > > description: | > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > - designed for portable devices. > + designed for portable devices. Product brief is available at > + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf > > properties: > compatible: > @@ -112,10 +113,36 @@ properties: > data-lanes: true > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/properties/port-base I don't understand why you are changing this line. > description: > Video port for panel or connector. > > + patternProperties: > + "^endpoint@[01]$": > + $ref: /schemas/media/video-interfaces.yaml# > + type: object > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 > + > + remote-endpoint: true > + > + data-lanes: > + minItems: 1 > + uniqueItems: true These are confusing... you allow only one item, so why minItems and uniqueItems? > + items: > + - enum: [ 0, 1, 2, 3] > + > + mode-switch: > + type: boolean > + description: Register this node as a Type-C mode switch or not. > + > + required: > + - reg > + - remote-endpoint > + > required: > - port@0 > - port@1 > @@ -186,3 +213,45 @@ examples: > }; > }; > }; > + - | > + &i2c3 { > + anx_bridge_dp: anx7625-dp@58 { Messed up indentation. > + compatible = "analogix,anx7625 Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation "; > + reg = <0x58>; Best regards, Krzysztof
next prev parent reply other threads:[~2022-11-27 20:58 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-24 10:20 [PATCH v6 0/7] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 10:20 ` [PATCH v6 1/7] device property: Add remote endpoint to devcon matcher Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 10:20 ` [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 12:24 ` Andy Shevchenko 2022-11-24 12:24 ` Andy Shevchenko 2022-11-25 5:52 ` Pin-yen Lin 2022-11-25 5:52 ` Pin-yen Lin 2022-11-25 5:53 ` Prashant Malani 2022-11-25 5:53 ` Prashant Malani 2022-11-24 10:20 ` [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 17:39 ` Rob Herring 2022-11-24 17:39 ` Rob Herring 2022-11-25 3:58 ` Pin-yen Lin 2022-11-25 3:58 ` Pin-yen Lin 2022-11-27 20:58 ` Krzysztof Kozlowski [this message] 2022-11-27 20:58 ` Krzysztof Kozlowski 2022-12-26 8:49 ` Pin-yen Lin 2022-12-26 8:49 ` Pin-yen Lin 2022-11-24 10:20 ` [PATCH v6 4/7] drm/bridge: anx7625: Check for Type-C during panel registration Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 10:20 ` [PATCH v6 5/7] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 12:18 ` Andy Shevchenko 2022-11-24 12:18 ` Andy Shevchenko 2022-11-25 6:58 ` Pin-yen Lin 2022-11-25 6:58 ` Pin-yen Lin 2022-11-24 10:20 ` [PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 17:39 ` Rob Herring 2022-11-24 17:39 ` Rob Herring 2022-11-25 3:58 ` Pin-yen Lin 2022-11-25 3:58 ` Pin-yen Lin 2022-11-27 21:02 ` Krzysztof Kozlowski 2022-11-27 21:02 ` Krzysztof Kozlowski 2022-12-26 8:57 ` Pin-yen Lin 2022-12-26 8:57 ` Pin-yen Lin 2022-11-24 10:20 ` [PATCH v6 7/7] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin 2022-11-24 10:20 ` Pin-yen Lin 2022-11-24 12:23 ` Andy Shevchenko 2022-11-24 12:23 ` Andy Shevchenko 2022-11-25 6:55 ` Pin-yen Lin 2022-11-25 6:55 ` Pin-yen Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=00cc31a2-39b1-9bb3-5b79-3c6d51cd5d51@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@gmail.com \ --cc=allen.chen@ite.com.tw \ --cc=andriy.shevchenko@linux.intel.com \ --cc=andrzej.hajda@intel.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=bleung@chromium.org \ --cc=chrome-platform@lists.linux.dev \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=djrscally@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=groeck@chromium.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=hsinyi@chromium.org \ --cc=javierm@redhat.com \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=marex@denx.de \ --cc=neil.armstrong@linaro.org \ --cc=nfraprado@collabora.com \ --cc=pmalani@chromium.org \ --cc=rafael@kernel.org \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=swboyd@chromium.org \ --cc=treapking@chromium.org \ --cc=tzimmermann@suse.de \ --cc=xji@analogixsemi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.