Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support - Pin-yen Lin

From: Pin-yen Lin <treapking@chromium.org>
To: Rob Herring <robh@kernel.org>
Cc: "Prashant Malani" <pmalani@chromium.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	devicetree@vger.kernel.org, ",
	Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	dri-devel@lists.freedesktop.org,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	linux-acpi@vger.kernel.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	chrome-platform@lists.linux.dev,
	"Robert Foss" <robert.foss@linaro.org>,
	"Allen Chen" <allen.chen@ite.com.tw>,
	"Hsin-Yi Wang" <hsinyi@chromium.org>,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Marek Vasut" <marex@denx.de>,
	"Benson Leung" <bleung@chromium.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	linux-kernel@vger.kernel.org, "Jonas Karlman" <jonas@kwiboo.se>,
	"Lyude Paul" <lyude@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Xin Ji" <xji@analogixsemi.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>
Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support
Date: Fri, 25 Nov 2022 11:58:09 +0800	[thread overview]
Message-ID: <CAEXTbpcn+AkG0YF2xHce99dX7V=tt3i76tBQ8m=qLjx+u7YKHQ@mail.gmail.com> (raw)
In-Reply-To: <166930150025.3946612.5757271936642172776.robh@kernel.org>

Sorry for accidentally using the tab characters. Will fix this in v7.

On Fri, Nov 25, 2022 at 1:39 AM Rob Herring <robh@kernel.org> wrote:
>
>
> On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote:
> > Analogix 7625 can be used in systems to switch the DP traffic between
> > two downstreams, which can be USB Type-C DisplayPort alternate mode
> > lane or regular DisplayPort output ports.
> >
> > Update the binding to accommodate this usage by introducing a
> > data-lanes and a mode-switch property on endpoints.
> >
> > Also include the link to the product brief in the bindings.
> >
> > Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> >
> > ---
> >
> > Changes in v6:
> > - Remove switches node and use endpoints and data-lanes property to
> >   describe the connections.
> >
> >  .../display/bridge/analogix,anx7625.yaml      | 73 ++++++++++++++++++-
> >  1 file changed, 71 insertions(+), 2 deletions(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
>
> dtschema/dtc warnings/errors:
> make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts'
> Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token
> make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file
> make: *** [Makefile:1492: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command.
>