Re: [PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support

From: Rob Herring <robh@kernel.org>
To: Pin-yen Lin <treapking@chromium.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Xin Ji" <xji@analogixsemi.com>, "Lyude Paul" <lyude@redhat.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Benson Leung" <bleung@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"David Airlie" <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	"Prashant Malani" <pmalani@chromium.org>,
	"Hsin-Yi Wang" <hsinyi@chromium.org>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Allen Chen" <allen.chen@ite.com.tw>,
	"Marek Vasut" <marex@denx.de>,
	linux-acpi@vger.kernel.org,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	linux-kernel@vger.kernel.org,
	"Guenter Roeck" <groeck@chromium.org>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	chrome-platform@lists.linux.dev
Subject: Re: [PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support
Date: Thu, 24 Nov 2022 11:39:27 -0600	[thread overview]
Message-ID: <166930150123.3946649.3725588692267123167.robh@kernel.org> (raw)
In-Reply-To: <20221124102056.393220-7-treapking@chromium.org>

On Thu, 24 Nov 2022 18:20:55 +0800, Pin-yen Lin wrote:
> ITE IT6505 can be used in systems to switch the DP traffic between
> two downstreams, which can be USB Type-C DisplayPort alternate mode
> lane or regular DisplayPort output ports.
> 
> Update the binding to accommodate this usage by introducing a
> data-lanes and a mode-switch property on endpoints.
> 
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 
> ---
> 
> Changes in v6:
> - Remove switches node and use endpoints and data-lanes property to
>   describe the connections.
> 
>  .../bindings/display/bridge/ite,it6505.yaml   | 94 ++++++++++++++++++-
>  1 file changed, 90 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml:99:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/ite,it6505.example.dts'
Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml:99:1: found character '\t' that cannot start any token
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/ite,it6505.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml:99:1: found character '\t' that cannot start any token
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml: ignoring, error parsing file
make: *** [Makefile:1492: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-7-treapking@chromium.org

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command.