From: Elliot Berman <quic_eberman@quicinc.com> To: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Jonathan Corbet <corbet@lwn.net>, "Prakruthi Deepak Heragu" <quic_pheragu@quicinc.com> Cc: Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Bjorn Andersson <andersson@kernel.org>, "Konrad Dybcio" <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Bagas Sanjaya <bagasdotme@gmail.com>, Will Deacon <will@kernel.org>, Andy Gross <agross@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Jassi Brar <jassisinghbrar@gmail.com>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v11 10/26] gunyah: vm_mgr: Introduce basic VM Manager Date: Tue, 11 Apr 2023 13:48:43 -0700 [thread overview] Message-ID: <030888c7-1e32-1663-589a-55e998963ab7@quicinc.com> (raw) In-Reply-To: <37bc641a-77b9-a740-a08e-8b86d0b50630@linaro.org> On 3/31/2023 7:25 AM, Alex Elder wrote: > On 3/3/23 7:06 PM, Elliot Berman wrote: >> @@ -129,6 +131,7 @@ struct gh_rm_connection { >> * @cache: cache for allocating Tx messages >> * @send_lock: synchronization to allow only one request to be sent >> at a time >> * @nh: notifier chain for clients interested in RM notification >> messages >> + * @miscdev: /dev/gunyah >> */ >> struct gh_rm { >> struct device *dev; >> @@ -145,6 +148,8 @@ struct gh_rm { >> struct kmem_cache *cache; >> struct mutex send_lock; >> struct blocking_notifier_head nh; >> + >> + struct miscdevice miscdev; >> }; >> /** >> @@ -593,6 +598,21 @@ void gh_rm_put(struct gh_rm *rm) >> } >> EXPORT_SYMBOL_GPL(gh_rm_put); > > I feel like /dev/gunyah code would more appropriately be found > in "vm_mgr.c". All gh_dev_ioctl() does is call the function > defined there, and it's therefore a VM-oriented rather than > resource-oriented device. I'd like to keep the gh_dev_ioctl where it is because it keeps the struct gh_rm explicitly private to rsc_mgr.c and thinking this helps keep the design cleaner long term by preventing new members from sneaking into struct gh_rm. >> + >> +static long gh_dev_ioctl_create_vm(struct gh_rm *rm, unsigned long arg) >> +{ >> + struct gh_vm *ghvm; >> + struct file *file; >> + int fd, err; >> + >> + /* arg reserved for future use. */ > > Do you have a clear idea of how this might be used in the future? Not yet. I have some vague ideas to use it as a enumeration of "special" VM types. We might have special number for VMs which use "protected VM firmware" for the Android boot flow, another number for the "Trusted UI VM", another for "OEM VM", etc. Passing 0 would always be the unauthenticated VM which we are creating today. We're considering bumping the info to a separate ioctl since additional info needs to be passed from userspace to configure the VM. Userspace would do GH_CREATE_VM(). Another ioctl like GH_VM_SET_PVMFW_ADDRESS() would imply that the VM uses the protected VM firmware for the Android boot flow. Another ioctl call would be used to imply the "Trusted UI VM". In any case, we're still in early design phase. > > I was thinking you could silently ignore the argument value, but > I suppose if it *does* get used in the future, you want the caller > to know it's being ignored. (Is that right?) > That's right. Thanks, Elliot
WARNING: multiple messages have this Message-ID (diff)
From: Elliot Berman <quic_eberman@quicinc.com> To: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Jonathan Corbet <corbet@lwn.net>, "Prakruthi Deepak Heragu" <quic_pheragu@quicinc.com> Cc: Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Bjorn Andersson <andersson@kernel.org>, "Konrad Dybcio" <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Bagas Sanjaya <bagasdotme@gmail.com>, Will Deacon <will@kernel.org>, Andy Gross <agross@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Jassi Brar <jassisinghbrar@gmail.com>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v11 10/26] gunyah: vm_mgr: Introduce basic VM Manager Date: Tue, 11 Apr 2023 13:48:43 -0700 [thread overview] Message-ID: <030888c7-1e32-1663-589a-55e998963ab7@quicinc.com> (raw) In-Reply-To: <37bc641a-77b9-a740-a08e-8b86d0b50630@linaro.org> On 3/31/2023 7:25 AM, Alex Elder wrote: > On 3/3/23 7:06 PM, Elliot Berman wrote: >> @@ -129,6 +131,7 @@ struct gh_rm_connection { >> * @cache: cache for allocating Tx messages >> * @send_lock: synchronization to allow only one request to be sent >> at a time >> * @nh: notifier chain for clients interested in RM notification >> messages >> + * @miscdev: /dev/gunyah >> */ >> struct gh_rm { >> struct device *dev; >> @@ -145,6 +148,8 @@ struct gh_rm { >> struct kmem_cache *cache; >> struct mutex send_lock; >> struct blocking_notifier_head nh; >> + >> + struct miscdevice miscdev; >> }; >> /** >> @@ -593,6 +598,21 @@ void gh_rm_put(struct gh_rm *rm) >> } >> EXPORT_SYMBOL_GPL(gh_rm_put); > > I feel like /dev/gunyah code would more appropriately be found > in "vm_mgr.c". All gh_dev_ioctl() does is call the function > defined there, and it's therefore a VM-oriented rather than > resource-oriented device. I'd like to keep the gh_dev_ioctl where it is because it keeps the struct gh_rm explicitly private to rsc_mgr.c and thinking this helps keep the design cleaner long term by preventing new members from sneaking into struct gh_rm. >> + >> +static long gh_dev_ioctl_create_vm(struct gh_rm *rm, unsigned long arg) >> +{ >> + struct gh_vm *ghvm; >> + struct file *file; >> + int fd, err; >> + >> + /* arg reserved for future use. */ > > Do you have a clear idea of how this might be used in the future? Not yet. I have some vague ideas to use it as a enumeration of "special" VM types. We might have special number for VMs which use "protected VM firmware" for the Android boot flow, another number for the "Trusted UI VM", another for "OEM VM", etc. Passing 0 would always be the unauthenticated VM which we are creating today. We're considering bumping the info to a separate ioctl since additional info needs to be passed from userspace to configure the VM. Userspace would do GH_CREATE_VM(). Another ioctl like GH_VM_SET_PVMFW_ADDRESS() would imply that the VM uses the protected VM firmware for the Android boot flow. Another ioctl call would be used to imply the "Trusted UI VM". In any case, we're still in early design phase. > > I was thinking you could silently ignore the argument value, but > I suppose if it *does* get used in the future, you want the caller > to know it's being ignored. (Is that right?) > That's right. Thanks, Elliot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-11 20:49 UTC|newest] Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-04 1:06 [PATCH v11 00/26] Drivers for gunyah hypervisor Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 01/26] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 02/26] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 03/26] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-31 14:24 ` Alex Elder 2023-03-31 14:24 ` Alex Elder 2023-04-03 19:44 ` Elliot Berman 2023-04-03 19:44 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 04/26] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-31 14:24 ` Alex Elder 2023-03-31 14:24 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 05/26] virt: gunyah: Identify hypervisor version Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 15:48 ` Srinivas Kandagatla 2023-03-21 15:48 ` Srinivas Kandagatla 2023-03-31 14:24 ` Alex Elder 2023-03-31 14:24 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 06/26] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 15:49 ` Srinivas Kandagatla 2023-03-21 15:49 ` Srinivas Kandagatla 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 07/26] mailbox: Add Gunyah message queue mailbox Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-03 20:15 ` Elliot Berman 2023-04-03 20:15 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 08/26] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-03 20:34 ` Elliot Berman 2023-04-03 20:34 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 09/26] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-03 21:09 ` Elliot Berman 2023-04-03 21:09 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 10/26] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-11 20:48 ` Elliot Berman [this message] 2023-04-11 20:48 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 11/26] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 12/26] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-24 18:37 ` Will Deacon 2023-03-24 18:37 ` Will Deacon 2023-04-11 20:34 ` Elliot Berman 2023-04-11 20:34 ` Elliot Berman 2023-04-11 21:19 ` Will Deacon 2023-04-11 21:19 ` Will Deacon 2023-04-12 20:48 ` Elliot Berman 2023-04-12 20:48 ` Elliot Berman 2023-04-13 9:54 ` Will Deacon 2023-04-13 9:54 ` Will Deacon 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-04-11 21:04 ` Elliot Berman 2023-04-11 21:04 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:24 ` Srinivas Kandagatla 2023-03-21 14:24 ` Srinivas Kandagatla 2023-04-11 21:07 ` Elliot Berman 2023-04-11 21:07 ` Elliot Berman 2023-04-11 21:09 ` Alex Elder 2023-04-11 21:09 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-04-11 21:16 ` Elliot Berman 2023-04-11 21:16 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 14/26] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 15/26] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-22 19:17 ` Elliot Berman 2023-03-22 19:17 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 16/26] firmware: qcom_scm: Register Gunyah platform ops Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:24 ` Srinivas Kandagatla 2023-03-21 14:24 ` Srinivas Kandagatla 2023-03-21 18:40 ` Elliot Berman 2023-03-21 18:40 ` Elliot Berman 2023-03-21 20:19 ` Srinivas Kandagatla 2023-03-21 20:19 ` Srinivas Kandagatla 2023-03-04 1:06 ` [PATCH v11 17/26] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 18/26] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-04-18 0:25 ` Elliot Berman 2023-04-18 0:25 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 19/26] gunyah: vm_mgr: Add framework to add VM Functions Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 20/26] virt: gunyah: Add resource tickets Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-04-17 22:57 ` Elliot Berman 2023-04-17 22:57 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 21/26] virt: gunyah: Add IO handlers Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 22/26] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-04-17 22:41 ` Elliot Berman 2023-04-17 22:41 ` Elliot Berman 2023-04-18 12:46 ` Alex Elder 2023-04-18 12:46 ` Alex Elder 2023-04-18 17:18 ` Elliot Berman 2023-04-18 17:18 ` Elliot Berman 2023-04-18 17:31 ` Alex Elder 2023-04-18 17:31 ` Alex Elder 2023-04-18 18:35 ` Elliot Berman 2023-04-18 18:35 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 23/26] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 24/26] virt: gunyah: Add irqfd interface Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-04-17 22:55 ` Elliot Berman 2023-04-17 22:55 ` Elliot Berman 2023-04-18 12:55 ` Alex Elder 2023-04-18 12:55 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 25/26] virt: gunyah: Add ioeventfd Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 26/26] MAINTAINERS: Add Gunyah hypervisor drivers section Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:24 ` [PATCH v11 00/26] Drivers for gunyah hypervisor Alex Elder 2023-03-31 14:24 ` Alex Elder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=030888c7-1e32-1663-589a-55e998963ab7@quicinc.com \ --to=quic_eberman@quicinc.com \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=arnd@arndb.de \ --cc=bagasdotme@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=elder@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jassisinghbrar@gmail.com \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_svaddagi@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.