From: Alex Elder <elder@linaro.org> To: Elliot Berman <quic_eberman@quicinc.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Will Deacon <will@kernel.org>, Andy Gross <agross@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Jassi Brar <jassisinghbrar@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 00/26] Drivers for gunyah hypervisor Date: Fri, 31 Mar 2023 09:24:24 -0500 [thread overview] Message-ID: <88a4808c-5f45-cb07-83bb-039f9d832b5b@linaro.org> (raw) In-Reply-To: <20230304010632.2127470-1-quic_eberman@quicinc.com> On 3/3/23 7:06 PM, Elliot Berman wrote: > Gunyah is a Type-1 hypervisor independent of any > high-level OS kernel, and runs in a higher CPU privilege level. It does > not depend on any lower-privileged OS kernel/code for its core > functionality. This increases its security and can support a much smaller > trusted computing base than a Type-2 hypervisor. > > Gunyah is an open source hypervisor. The source repo is available at > https://github.com/quic/gunyah-hypervisor. I've done a pretty detailed review again, and got further along than I did last time. Things are definitely looking better, but I have found some bugs that need to be addressed. I also make a lot of comments about grouping certain sets of definitions into enumerated types. Also I tend to notice when things aren't done consistently, and I mention that a lot. There are silly suggestions all over about alignment of things--these are mainly to make the code look prettier, though that's a matter of opinion. I still prefer having lines generally closer to 80 columns wide, but I've already mentioned that... I really focused on the code, and not the documentation. In fact I didn't even pay much attention to your patch headers either. I did not review the SCM calls yet. So in summary I have not reviewed patches 1, 2, 16, 17, and 26. I try to look at everything in my next review, which I hope will be final (or very close). -Alex > The diagram below shows the architecture. > > :: > > VM A VM B > +-----+ +-----+ | +-----+ +-----+ +-----+ > | | | | | | | | | | | > EL0 | APP | | APP | | | APP | | APP | | APP | > | | | | | | | | | | | > +-----+ +-----+ | +-----+ +-----+ +-----+ > ---------------------|------------------------- > +--------------+ | +----------------------+ > | | | | | > EL1 | Linux Kernel | | |Linux kernel/Other OS | ... > | | | | | > +--------------+ | +----------------------+ > --------hvc/smc------|------hvc/smc------------ > +----------------------------------------+ > | | > EL2 | Gunyah Hypervisor | > | | > +----------------------------------------+ > > Gunyah provides these following features. > . . .
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <elder@linaro.org> To: Elliot Berman <quic_eberman@quicinc.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Will Deacon <will@kernel.org>, Andy Gross <agross@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Jassi Brar <jassisinghbrar@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 00/26] Drivers for gunyah hypervisor Date: Fri, 31 Mar 2023 09:24:24 -0500 [thread overview] Message-ID: <88a4808c-5f45-cb07-83bb-039f9d832b5b@linaro.org> (raw) In-Reply-To: <20230304010632.2127470-1-quic_eberman@quicinc.com> On 3/3/23 7:06 PM, Elliot Berman wrote: > Gunyah is a Type-1 hypervisor independent of any > high-level OS kernel, and runs in a higher CPU privilege level. It does > not depend on any lower-privileged OS kernel/code for its core > functionality. This increases its security and can support a much smaller > trusted computing base than a Type-2 hypervisor. > > Gunyah is an open source hypervisor. The source repo is available at > https://github.com/quic/gunyah-hypervisor. I've done a pretty detailed review again, and got further along than I did last time. Things are definitely looking better, but I have found some bugs that need to be addressed. I also make a lot of comments about grouping certain sets of definitions into enumerated types. Also I tend to notice when things aren't done consistently, and I mention that a lot. There are silly suggestions all over about alignment of things--these are mainly to make the code look prettier, though that's a matter of opinion. I still prefer having lines generally closer to 80 columns wide, but I've already mentioned that... I really focused on the code, and not the documentation. In fact I didn't even pay much attention to your patch headers either. I did not review the SCM calls yet. So in summary I have not reviewed patches 1, 2, 16, 17, and 26. I try to look at everything in my next review, which I hope will be final (or very close). -Alex > The diagram below shows the architecture. > > :: > > VM A VM B > +-----+ +-----+ | +-----+ +-----+ +-----+ > | | | | | | | | | | | > EL0 | APP | | APP | | | APP | | APP | | APP | > | | | | | | | | | | | > +-----+ +-----+ | +-----+ +-----+ +-----+ > ---------------------|------------------------- > +--------------+ | +----------------------+ > | | | | | > EL1 | Linux Kernel | | |Linux kernel/Other OS | ... > | | | | | > +--------------+ | +----------------------+ > --------hvc/smc------|------hvc/smc------------ > +----------------------------------------+ > | | > EL2 | Gunyah Hypervisor | > | | > +----------------------------------------+ > > Gunyah provides these following features. > . . . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-31 14:24 UTC|newest] Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-04 1:06 [PATCH v11 00/26] Drivers for gunyah hypervisor Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 01/26] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 02/26] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 03/26] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-31 14:24 ` Alex Elder 2023-03-31 14:24 ` Alex Elder 2023-04-03 19:44 ` Elliot Berman 2023-04-03 19:44 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 04/26] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-31 14:24 ` Alex Elder 2023-03-31 14:24 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 05/26] virt: gunyah: Identify hypervisor version Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 15:48 ` Srinivas Kandagatla 2023-03-21 15:48 ` Srinivas Kandagatla 2023-03-31 14:24 ` Alex Elder 2023-03-31 14:24 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 06/26] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 15:49 ` Srinivas Kandagatla 2023-03-21 15:49 ` Srinivas Kandagatla 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 07/26] mailbox: Add Gunyah message queue mailbox Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-21 14:22 ` Srinivas Kandagatla 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-03 20:15 ` Elliot Berman 2023-04-03 20:15 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 08/26] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-03 20:34 ` Elliot Berman 2023-04-03 20:34 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 09/26] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-03 21:09 ` Elliot Berman 2023-04-03 21:09 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 10/26] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-31 14:25 ` Alex Elder 2023-03-31 14:25 ` Alex Elder 2023-04-11 20:48 ` Elliot Berman 2023-04-11 20:48 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 11/26] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 12/26] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-24 18:37 ` Will Deacon 2023-03-24 18:37 ` Will Deacon 2023-04-11 20:34 ` Elliot Berman 2023-04-11 20:34 ` Elliot Berman 2023-04-11 21:19 ` Will Deacon 2023-04-11 21:19 ` Will Deacon 2023-04-12 20:48 ` Elliot Berman 2023-04-12 20:48 ` Elliot Berman 2023-04-13 9:54 ` Will Deacon 2023-04-13 9:54 ` Will Deacon 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-04-11 21:04 ` Elliot Berman 2023-04-11 21:04 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:24 ` Srinivas Kandagatla 2023-03-21 14:24 ` Srinivas Kandagatla 2023-04-11 21:07 ` Elliot Berman 2023-04-11 21:07 ` Elliot Berman 2023-04-11 21:09 ` Alex Elder 2023-04-11 21:09 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-04-11 21:16 ` Elliot Berman 2023-04-11 21:16 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 14/26] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 15/26] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-21 14:23 ` Srinivas Kandagatla 2023-03-22 19:17 ` Elliot Berman 2023-03-22 19:17 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 16/26] firmware: qcom_scm: Register Gunyah platform ops Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-21 14:24 ` Srinivas Kandagatla 2023-03-21 14:24 ` Srinivas Kandagatla 2023-03-21 18:40 ` Elliot Berman 2023-03-21 18:40 ` Elliot Berman 2023-03-21 20:19 ` Srinivas Kandagatla 2023-03-21 20:19 ` Srinivas Kandagatla 2023-03-04 1:06 ` [PATCH v11 17/26] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 18/26] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-04-18 0:25 ` Elliot Berman 2023-04-18 0:25 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 19/26] gunyah: vm_mgr: Add framework to add VM Functions Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:26 ` Alex Elder 2023-03-31 14:26 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 20/26] virt: gunyah: Add resource tickets Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-04-17 22:57 ` Elliot Berman 2023-04-17 22:57 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 21/26] virt: gunyah: Add IO handlers Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 22/26] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-04-17 22:41 ` Elliot Berman 2023-04-17 22:41 ` Elliot Berman 2023-04-18 12:46 ` Alex Elder 2023-04-18 12:46 ` Alex Elder 2023-04-18 17:18 ` Elliot Berman 2023-04-18 17:18 ` Elliot Berman 2023-04-18 17:31 ` Alex Elder 2023-04-18 17:31 ` Alex Elder 2023-04-18 18:35 ` Elliot Berman 2023-04-18 18:35 ` Elliot Berman 2023-03-04 1:06 ` [PATCH v11 23/26] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 24/26] virt: gunyah: Add irqfd interface Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-04-17 22:55 ` Elliot Berman 2023-04-17 22:55 ` Elliot Berman 2023-04-18 12:55 ` Alex Elder 2023-04-18 12:55 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 25/26] virt: gunyah: Add ioeventfd Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:27 ` Alex Elder 2023-03-31 14:27 ` Alex Elder 2023-03-04 1:06 ` [PATCH v11 26/26] MAINTAINERS: Add Gunyah hypervisor drivers section Elliot Berman 2023-03-04 1:06 ` Elliot Berman 2023-03-31 14:24 ` Alex Elder [this message] 2023-03-31 14:24 ` [PATCH v11 00/26] Drivers for gunyah hypervisor Alex Elder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=88a4808c-5f45-cb07-83bb-039f9d832b5b@linaro.org \ --to=elder@linaro.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=arnd@arndb.de \ --cc=bagasdotme@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jassisinghbrar@gmail.com \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_svaddagi@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.