From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Jisheng Zhang <jszhang@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Vinod Koul <vkoul@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Logan Gunthorpe <logang@deltatee.com>,
Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] dmaengine: sprd: Don't set chancnt
Date: Tue, 14 Mar 2023 11:51:25 +0800 [thread overview]
Message-ID: <04cc510b-6d66-99b5-4fe8-f51729299574@linux.alibaba.com> (raw)
In-Reply-To: <20230313170250.815-6-jszhang@kernel.org>
On 3/14/2023 1:02 AM, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/dma/sprd-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 474d3ba8ec9f..2b639adb48ba 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev)
>
> dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask);
> sdev->total_chns = chn_count;
> - sdev->dma_dev.chancnt = chn_count;
> INIT_LIST_HEAD(&sdev->dma_dev.channels);
> INIT_LIST_HEAD(&sdev->dma_dev.global_node);
> sdev->dma_dev.dev = &pdev->dev;
WARNING: multiple messages have this Message-ID (diff)
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Jisheng Zhang <jszhang@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Vinod Koul <vkoul@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Logan Gunthorpe <logang@deltatee.com>,
Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] dmaengine: sprd: Don't set chancnt
Date: Tue, 14 Mar 2023 11:51:25 +0800 [thread overview]
Message-ID: <04cc510b-6d66-99b5-4fe8-f51729299574@linux.alibaba.com> (raw)
In-Reply-To: <20230313170250.815-6-jszhang@kernel.org>
On 3/14/2023 1:02 AM, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/dma/sprd-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 474d3ba8ec9f..2b639adb48ba 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev)
>
> dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask);
> sdev->total_chns = chn_count;
> - sdev->dma_dev.chancnt = chn_count;
> INIT_LIST_HEAD(&sdev->dma_dev.channels);
> INIT_LIST_HEAD(&sdev->dma_dev.global_node);
> sdev->dma_dev.dev = &pdev->dev;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-14 3:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 17:02 [PATCH 0/5] dma: don't set chancnt Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 1/5] dmaengine: dw-axi-dmac: Don't " Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-17 17:39 ` Vinod Koul
2023-03-17 17:39 ` Vinod Koul
2023-03-13 17:02 ` [PATCH 2/5] dmaengine: axi-dmac: " Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-13 17:36 ` Lars-Peter Clausen
2023-03-13 17:36 ` Lars-Peter Clausen
2023-03-13 17:02 ` [PATCH 3/5] dmaengine: plx_dma: " Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 4/5] dmaengine: hidma: " Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 5/5] dmaengine: sprd: " Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-14 3:51 ` Baolin Wang [this message]
2023-03-14 3:51 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04cc510b-6d66-99b5-4fe8-f51729299574@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=okaya@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=vkoul@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.