All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jisheng Zhang <jszhang@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt
Date: Mon, 13 Mar 2023 10:36:20 -0700	[thread overview]
Message-ID: <5513e68a-22b8-2c91-5342-b1796741610d@metafoo.de> (raw)
In-Reply-To: <20230313170250.815-3-jszhang@kernel.org>

On 3/13/23 10:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.

s/outself/ourself/

Looks good otherwise, thanks.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>   drivers/dma/dma-axi-dmac.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index a812b9b00e6b..fc7cdad37161 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev)
>   	dma_dev->device_terminate_all = axi_dmac_terminate_all;
>   	dma_dev->device_synchronize = axi_dmac_synchronize;
>   	dma_dev->dev = &pdev->dev;
> -	dma_dev->chancnt = 1;
>   	dma_dev->src_addr_widths = BIT(dmac->chan.src_width);
>   	dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width);
>   	dma_dev->directions = BIT(dmac->chan.direction);



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jisheng Zhang <jszhang@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt
Date: Mon, 13 Mar 2023 10:36:20 -0700	[thread overview]
Message-ID: <5513e68a-22b8-2c91-5342-b1796741610d@metafoo.de> (raw)
In-Reply-To: <20230313170250.815-3-jszhang@kernel.org>

On 3/13/23 10:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.

s/outself/ourself/

Looks good otherwise, thanks.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>   drivers/dma/dma-axi-dmac.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index a812b9b00e6b..fc7cdad37161 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev)
>   	dma_dev->device_terminate_all = axi_dmac_terminate_all;
>   	dma_dev->device_synchronize = axi_dmac_synchronize;
>   	dma_dev->dev = &pdev->dev;
> -	dma_dev->chancnt = 1;
>   	dma_dev->src_addr_widths = BIT(dmac->chan.src_width);
>   	dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width);
>   	dma_dev->directions = BIT(dmac->chan.direction);



  reply	other threads:[~2023-03-13 17:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 17:02 [PATCH 0/5] dma: don't set chancnt Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 1/5] dmaengine: dw-axi-dmac: Don't " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-17 17:39   ` Vinod Koul
2023-03-17 17:39     ` Vinod Koul
2023-03-13 17:02 ` [PATCH 2/5] dmaengine: axi-dmac: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-13 17:36   ` Lars-Peter Clausen [this message]
2023-03-13 17:36     ` Lars-Peter Clausen
2023-03-13 17:02 ` [PATCH 3/5] dmaengine: plx_dma: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 4/5] dmaengine: hidma: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 5/5] dmaengine: sprd: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-14  3:51   ` Baolin Wang
2023-03-14  3:51     ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5513e68a-22b8-2c91-5342-b1796741610d@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jszhang@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=okaya@kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.