All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Julia Lawall <julia.lawall@inria.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 04 Jun 2020 09:08:44 -0700	[thread overview]
Message-ID: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> (raw)
In-Reply-To: <20200604123038.GG22511@kadam>

On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote:
> On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote:
> > OK, I recall a discussion with Dan where he suggested that some things
> > that were not actually bug fixes could also merit a Fixes tag.  But it's
> > probably better if he weighs in directly.
> 
> I generally think Fixes should only be used for "real bug" fixes.
> 
> The one exception is when I'm reviewing a patch that fixes an "unused
> assignment" static checker warning is that I know which commit
> introduced the warning.  I don't have strong feelings if it's in the
> Fixes tag or if it's just mentioned in the commit message.

My view is that changes that silence compiler warnings are
not fixing bugs and that these changes should generally not
be backported.

Compiler silencing changes marked as fixes can introduce other
defects in working code.

Backporting patches to stable trees should be conservatively
rather than liberally applied.

It seems that the actual backport maintainers disagree though.



WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Julia Lawall <julia.lawall@inria.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	kernel-janitors@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Daniel Mack <daniel@zonque.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 04 Jun 2020 16:08:44 +0000	[thread overview]
Message-ID: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> (raw)
In-Reply-To: <20200604123038.GG22511@kadam>

On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote:
> On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote:
> > OK, I recall a discussion with Dan where he suggested that some things
> > that were not actually bug fixes could also merit a Fixes tag.  But it's
> > probably better if he weighs in directly.
> 
> I generally think Fixes should only be used for "real bug" fixes.
> 
> The one exception is when I'm reviewing a patch that fixes an "unused
> assignment" static checker warning is that I know which commit
> introduced the warning.  I don't have strong feelings if it's in the
> Fixes tag or if it's just mentioned in the commit message.

My view is that changes that silence compiler warnings are
not fixing bugs and that these changes should generally not
be backported.

Compiler silencing changes marked as fixes can introduce other
defects in working code.

Backporting patches to stable trees should be conservatively
rather than liberally applied.

It seems that the actual backport maintainers disagree though.

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Julia Lawall <julia.lawall@inria.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	kernel-janitors@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Daniel Mack <daniel@zonque.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 04 Jun 2020 09:08:44 -0700	[thread overview]
Message-ID: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> (raw)
In-Reply-To: <20200604123038.GG22511@kadam>

On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote:
> On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote:
> > OK, I recall a discussion with Dan where he suggested that some things
> > that were not actually bug fixes could also merit a Fixes tag.  But it's
> > probably better if he weighs in directly.
> 
> I generally think Fixes should only be used for "real bug" fixes.
> 
> The one exception is when I'm reviewing a patch that fixes an "unused
> assignment" static checker warning is that I know which commit
> introduced the warning.  I don't have strong feelings if it's in the
> Fixes tag or if it's just mentioned in the commit message.

My view is that changes that silence compiler warnings are
not fixing bugs and that these changes should generally not
be backported.

Compiler silencing changes marked as fixes can introduce other
defects in working code.

Backporting patches to stable trees should be conservatively
rather than liberally applied.

It seems that the actual backport maintainers disagree though.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-04 16:08 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31  7:37 [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Christophe JAILLET
2020-05-31  7:37 ` Christophe JAILLET
2020-05-31  7:37 ` Christophe JAILLET
2020-06-01  8:58 ` Robert Jarzmik
2020-06-01  8:58   ` Robert Jarzmik
2020-06-01  8:58   ` Robert Jarzmik
2020-06-01 11:31   ` Christophe JAILLET
2020-06-01 11:31     ` Christophe JAILLET
2020-06-01 11:31     ` Christophe JAILLET
2020-06-01 18:31     ` Dan Carpenter
2020-06-01 18:31       ` Dan Carpenter
2020-06-01 18:31       ` Dan Carpenter
2020-06-03 22:08       ` Linus Walleij
2020-06-03 22:08         ` Linus Walleij
2020-06-03 22:08         ` Linus Walleij
2020-06-04  8:31         ` Dan Carpenter
2020-06-04  8:31           ` Dan Carpenter
2020-06-04  8:31           ` Dan Carpenter
2020-06-04  9:17           ` Joe Perches
2020-06-04  9:17             ` Joe Perches
2020-06-04  9:17             ` Joe Perches
2020-06-04  9:52             ` Julia Lawall
2020-06-04  9:52               ` Julia Lawall
2020-06-04  9:52               ` Julia Lawall
2020-06-04 10:00               ` Joe Perches
2020-06-04 10:00                 ` Joe Perches
2020-06-04 10:00                 ` Joe Perches
2020-06-04 10:33                 ` Julia Lawall
2020-06-04 10:33                   ` Julia Lawall
2020-06-04 10:33                   ` Julia Lawall
2020-06-04 11:08                   ` Joe Perches
2020-06-04 11:08                     ` Joe Perches
2020-06-04 11:08                     ` Joe Perches
2020-06-04 11:42                     ` Julia Lawall
2020-06-04 11:42                       ` Julia Lawall
2020-06-04 11:42                       ` Julia Lawall
2020-06-04 12:30                       ` Dan Carpenter
2020-06-04 12:30                         ` Dan Carpenter
2020-06-04 12:30                         ` Dan Carpenter
2020-06-04 16:08                         ` Joe Perches [this message]
2020-06-04 16:08                           ` Joe Perches
2020-06-04 16:08                           ` Joe Perches
2020-06-04 16:29                           ` Julia Lawall
2020-06-04 16:29                             ` Julia Lawall
2020-06-04 16:29                             ` Julia Lawall
2020-06-04 17:35                           ` Dan Carpenter
2020-06-04 17:35                             ` Dan Carpenter
2020-06-04 17:35                             ` Dan Carpenter
2020-06-04 18:02                             ` Joe Perches
2020-06-04 18:02                               ` Joe Perches
2020-06-04 18:02                               ` Joe Perches
2020-06-03 22:05 ` Linus Walleij
2020-06-03 22:05   ` Linus Walleij
2020-06-03 22:05   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com \
    --to=joe@perches.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=julia.lawall@inria.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.