From: Julia Lawall <julia.lawall@inria.fr>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Linus Walleij <linus.walleij@linaro.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 4 Jun 2020 12:33:53 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2006041228520.2577@hadrien> (raw)
In-Reply-To: <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com>
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote:
> > Should Fixes also be used when the change will make it hard to port other
> > fixes over it?
>
> If it's a logic defect or regression that's being fixed,
> shouldn't the logic defect or regression be fixed as
> reasonably soon as possible?
Sure, but I recall seeing some patches that mentioned that the problem had
existed since the beginning of git. Of course, it should be rare.
>
> The nature of the fix should ideally be optimal for
> backporting, but I believe that should not stop any
> consideration for the standalone fix itself.
I'm not sure to follow this. Sometimes non-bug fixes that block
backporting a bug fix have to be backported as well. So the fixes would
again highlight the range of versions affected by the issue.
julia
> What do you think?
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Joe Perches <joe@perches.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 04 Jun 2020 10:33:53 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2006041228520.2577@hadrien> (raw)
In-Reply-To: <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com>
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote:
> > Should Fixes also be used when the change will make it hard to port other
> > fixes over it?
>
> If it's a logic defect or regression that's being fixed,
> shouldn't the logic defect or regression be fixed as
> reasonably soon as possible?
Sure, but I recall seeing some patches that mentioned that the problem had
existed since the beginning of git. Of course, it should be rare.
>
> The nature of the fix should ideally be optimal for
> backporting, but I believe that should not stop any
> consideration for the standalone fix itself.
I'm not sure to follow this. Sometimes non-bug fixes that block
backporting a bug fix have to be backported as well. So the fixes would
again highlight the range of versions affected by the issue.
julia
> What do you think?
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Joe Perches <joe@perches.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 4 Jun 2020 12:33:53 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2006041228520.2577@hadrien> (raw)
In-Reply-To: <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com>
On Thu, 4 Jun 2020, Joe Perches wrote:
> On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote:
> > Should Fixes also be used when the change will make it hard to port other
> > fixes over it?
>
> If it's a logic defect or regression that's being fixed,
> shouldn't the logic defect or regression be fixed as
> reasonably soon as possible?
Sure, but I recall seeing some patches that mentioned that the problem had
existed since the beginning of git. Of course, it should be rare.
>
> The nature of the fix should ideally be optimal for
> backporting, but I believe that should not stop any
> consideration for the standalone fix itself.
I'm not sure to follow this. Sometimes non-bug fixes that block
backporting a bug fix have to be backported as well. So the fixes would
again highlight the range of versions affected by the issue.
julia
> What do you think?
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-04 10:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 7:37 [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Christophe JAILLET
2020-05-31 7:37 ` Christophe JAILLET
2020-05-31 7:37 ` Christophe JAILLET
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 18:31 ` Dan Carpenter
2020-06-01 18:31 ` Dan Carpenter
2020-06-01 18:31 ` Dan Carpenter
2020-06-03 22:08 ` Linus Walleij
2020-06-03 22:08 ` Linus Walleij
2020-06-03 22:08 ` Linus Walleij
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:52 ` Julia Lawall
2020-06-04 9:52 ` Julia Lawall
2020-06-04 9:52 ` Julia Lawall
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:33 ` Julia Lawall [this message]
2020-06-04 10:33 ` Julia Lawall
2020-06-04 10:33 ` Julia Lawall
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:42 ` Julia Lawall
2020-06-04 11:42 ` Julia Lawall
2020-06-04 11:42 ` Julia Lawall
2020-06-04 12:30 ` Dan Carpenter
2020-06-04 12:30 ` Dan Carpenter
2020-06-04 12:30 ` Dan Carpenter
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:29 ` Julia Lawall
2020-06-04 16:29 ` Julia Lawall
2020-06-04 16:29 ` Julia Lawall
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 18:02 ` Joe Perches
2020-06-04 18:02 ` Joe Perches
2020-06-04 18:02 ` Joe Perches
2020-06-03 22:05 ` Linus Walleij
2020-06-03 22:05 ` Linus Walleij
2020-06-03 22:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2006041228520.2577@hadrien \
--to=julia.lawall@inria.fr \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.