From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Christian Marangi <ansuelsmth@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Biao Huang <biao.huang@mediatek.com>,
Yang Yingliang <yangyingliang@huawei.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description
Date: Thu, 16 Mar 2023 09:05:37 +0100 [thread overview]
Message-ID: <08925242-4c2c-e149-39e5-6ee16ba17cbd@linaro.org> (raw)
In-Reply-To: <20230313225103.30512-9-Sergey.Semin@baikalelectronics.ru>
On 13/03/2023 23:50, Serge Semin wrote:
> The property is supposed to contain a phandle reference to the DT-node
> with the AXI-bus parameters. Such DT-node is described in the same
> DT-bindings schema by means of the sub-node with the name
> "stmmac-axi-config". Similarly to MTL Tx/Rx config phandle properties
> let's drop the target DT-node properties list from the "snps,axi-config"
> property description since having that duplicate is not only pointless,
> but also worsens the bindings maintainability by causing a need to support
> the two identical lists. Instead the reference to the target DT-node is
> added to the description.
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Christian Marangi <ansuelsmth@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Biao Huang <biao.huang@mediatek.com>,
Yang Yingliang <yangyingliang@huawei.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description
Date: Thu, 16 Mar 2023 09:05:37 +0100 [thread overview]
Message-ID: <08925242-4c2c-e149-39e5-6ee16ba17cbd@linaro.org> (raw)
In-Reply-To: <20230313225103.30512-9-Sergey.Semin@baikalelectronics.ru>
On 13/03/2023 23:50, Serge Semin wrote:
> The property is supposed to contain a phandle reference to the DT-node
> with the AXI-bus parameters. Such DT-node is described in the same
> DT-bindings schema by means of the sub-node with the name
> "stmmac-axi-config". Similarly to MTL Tx/Rx config phandle properties
> let's drop the target DT-node properties list from the "snps,axi-config"
> property description since having that duplicate is not only pointless,
> but also worsens the bindings maintainability by causing a need to support
> the two identical lists. Instead the reference to the target DT-node is
> added to the description.
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-16 8:06 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 22:50 [PATCH net-next 00/16] dt-bindings: net: dwmac: Extend clocks, props desc and constraints Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-14 14:10 ` Rob Herring
2023-03-14 14:10 ` Rob Herring
2023-03-14 15:06 ` Serge Semin
2023-03-14 15:06 ` Serge Semin
2023-03-14 17:09 ` Serge Semin
2023-03-14 17:09 ` Serge Semin
2023-03-16 20:40 ` Rob Herring
2023-03-16 20:40 ` Rob Herring
2023-03-16 20:50 ` Serge Semin
2023-03-16 20:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 04/16] dt-bindings: net: dwmac: Detach Generic DW MAC bindings Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 05/16] dt-bindings: net: dwmac: Elaborate snps,clk-csr description Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-16 8:04 ` Krzysztof Kozlowski
2023-03-16 8:04 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 06/16] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk clocks description Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 07/16] dt-bindings: net: dwmac: Add Tx/Rx clock sources Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-16 8:05 ` Krzysztof Kozlowski [this message]
2023-03-16 8:05 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-23 11:37 ` Serge Semin
2023-03-23 11:37 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 10/16] dt-bindings: net: dwmac: Add AXI-bus properties constraints Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-23 11:49 ` Serge Semin
2023-03-23 11:49 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 11/16] dt-bindings: net: dwmac: Add MTL Rx Queue " Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-16 8:07 ` Krzysztof Kozlowski
2023-03-16 8:07 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 12/16] dt-bindings: net: dwmac: Add MTL Tx " Serge Semin
2023-03-13 22:50 ` Serge Semin
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-23 11:55 ` Serge Semin
2023-03-23 11:55 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 13/16] dt-bindings: net: dwmac: Fix MTL Tx Queue props description Serge Semin
2023-03-13 22:51 ` Serge Semin
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-23 12:03 ` Serge Semin
2023-03-23 12:03 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 14/16] dt-bindings: net: dwmac: Use flag definition instead of booleans Serge Semin
2023-03-13 22:51 ` Serge Semin
2023-03-16 8:09 ` Krzysztof Kozlowski
2023-03-16 8:09 ` Krzysztof Kozlowski
2023-03-23 12:08 ` Serge Semin
2023-03-23 12:08 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Serge Semin
2023-03-13 22:51 ` Serge Semin
2023-03-17 20:56 ` Rob Herring
2023-03-17 20:56 ` Rob Herring
2023-03-23 15:10 ` Serge Semin
2023-03-23 15:10 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 16/16] dt-bindings: net: dwmac: Add MTL Tx queue CBS-algo " Serge Semin
2023-03-13 22:51 ` Serge Semin
2023-03-17 20:57 ` Rob Herring
2023-03-17 20:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08925242-4c2c-e149-39e5-6ee16ba17cbd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=ansuelsmth@gmail.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.