From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>, Serge Semin <fancer.lancer@gmail.com>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Christian Marangi <ansuelsmth@gmail.com>, Richard Cochran <richardcochran@gmail.com>, Biao Huang <biao.huang@mediatek.com>, Yang Yingliang <yangyingliang@huawei.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org> Subject: [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Date: Tue, 14 Mar 2023 01:50:50 +0300 [thread overview] Message-ID: <20230313225103.30512-4-Sergey.Semin@baikalelectronics.ru> (raw) In-Reply-To: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> Indeed the STMMAC driver doesn't take the vendor-specific compatible string into account to parse the "snps,tso" boolean property. It just makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC IP-cores. The original allwinner sunXi bindings file also didn't have the TSO-related property declared. Neither Ingenic nor Loongson LLD drivers activate the GMAC4/5/etc-specific core code. Taking all of that into account fix the conditional statement so the TSO-property would be evaluated for the compatibles having the corresponding IP-core version by dropping all of the vendor-specific compatibles from the property conditional statement. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Rob Herring <robh@kernel.org> --- Note this won't break the bindings description, since the "snps,tso" property isn't parsed by the denoted glue drivers, but only by the generic platform DT-parser. Changelog v1: - Use correct syntax of the JSON pointers, so the later would begin with a '/' after the '#'. --- .../devicetree/bindings/net/snps,dwmac.yaml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index fb9b8506a48f..92feed3c29bc 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -590,27 +590,12 @@ allOf: compatible: contains: enum: - - allwinner,sun7i-a20-gmac - - allwinner,sun8i-a83t-emac - - allwinner,sun8i-h3-emac - - allwinner,sun8i-r40-gmac - - allwinner,sun8i-v3s-emac - - allwinner,sun50i-a64-emac - - loongson,ls2k-dwmac - - loongson,ls7a-dwmac - - ingenic,jz4775-mac - - ingenic,x1000-mac - - ingenic,x1600-mac - - ingenic,x1830-mac - - ingenic,x2000-mac - snps,dwmac-4.00 - snps,dwmac-4.10a - snps,dwmac-4.20a - snps,dwmac-5.10a - snps,dwxgmac - snps,dwxgmac-2.10 - - st,spear600-gmac - then: properties: snps,tso: -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>, Serge Semin <fancer.lancer@gmail.com>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Christian Marangi <ansuelsmth@gmail.com>, Richard Cochran <richardcochran@gmail.com>, Biao Huang <biao.huang@mediatek.com>, Yang Yingliang <yangyingliang@huawei.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org> Subject: [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Date: Tue, 14 Mar 2023 01:50:50 +0300 [thread overview] Message-ID: <20230313225103.30512-4-Sergey.Semin@baikalelectronics.ru> (raw) In-Reply-To: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> Indeed the STMMAC driver doesn't take the vendor-specific compatible string into account to parse the "snps,tso" boolean property. It just makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC IP-cores. The original allwinner sunXi bindings file also didn't have the TSO-related property declared. Neither Ingenic nor Loongson LLD drivers activate the GMAC4/5/etc-specific core code. Taking all of that into account fix the conditional statement so the TSO-property would be evaluated for the compatibles having the corresponding IP-core version by dropping all of the vendor-specific compatibles from the property conditional statement. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Rob Herring <robh@kernel.org> --- Note this won't break the bindings description, since the "snps,tso" property isn't parsed by the denoted glue drivers, but only by the generic platform DT-parser. Changelog v1: - Use correct syntax of the JSON pointers, so the later would begin with a '/' after the '#'. --- .../devicetree/bindings/net/snps,dwmac.yaml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index fb9b8506a48f..92feed3c29bc 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -590,27 +590,12 @@ allOf: compatible: contains: enum: - - allwinner,sun7i-a20-gmac - - allwinner,sun8i-a83t-emac - - allwinner,sun8i-h3-emac - - allwinner,sun8i-r40-gmac - - allwinner,sun8i-v3s-emac - - allwinner,sun50i-a64-emac - - loongson,ls2k-dwmac - - loongson,ls7a-dwmac - - ingenic,jz4775-mac - - ingenic,x1000-mac - - ingenic,x1600-mac - - ingenic,x1830-mac - - ingenic,x2000-mac - snps,dwmac-4.00 - snps,dwmac-4.10a - snps,dwmac-4.20a - snps,dwmac-5.10a - snps,dwxgmac - snps,dwxgmac-2.10 - - st,spear600-gmac - then: properties: snps,tso: -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-13 22:52 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-13 22:50 [PATCH net-next 00/16] dt-bindings: net: dwmac: Extend clocks, props desc and constraints Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-14 14:10 ` Rob Herring 2023-03-14 14:10 ` Rob Herring 2023-03-14 15:06 ` Serge Semin 2023-03-14 15:06 ` Serge Semin 2023-03-14 17:09 ` Serge Semin 2023-03-14 17:09 ` Serge Semin 2023-03-16 20:40 ` Rob Herring 2023-03-16 20:40 ` Rob Herring 2023-03-16 20:50 ` Serge Semin 2023-03-16 20:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` Serge Semin [this message] 2023-03-13 22:50 ` [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Serge Semin 2023-03-13 22:50 ` [PATCH net-next 04/16] dt-bindings: net: dwmac: Detach Generic DW MAC bindings Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 05/16] dt-bindings: net: dwmac: Elaborate snps,clk-csr description Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:04 ` Krzysztof Kozlowski 2023-03-16 8:04 ` Krzysztof Kozlowski 2023-03-13 22:50 ` [PATCH net-next 06/16] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk clocks description Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 07/16] dt-bindings: net: dwmac: Add Tx/Rx clock sources Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:05 ` Krzysztof Kozlowski 2023-03-16 8:05 ` Krzysztof Kozlowski 2023-03-13 22:50 ` [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-23 11:37 ` Serge Semin 2023-03-23 11:37 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 10/16] dt-bindings: net: dwmac: Add AXI-bus properties constraints Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-23 11:49 ` Serge Semin 2023-03-23 11:49 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 11/16] dt-bindings: net: dwmac: Add MTL Rx Queue " Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:07 ` Krzysztof Kozlowski 2023-03-16 8:07 ` Krzysztof Kozlowski 2023-03-13 22:50 ` [PATCH net-next 12/16] dt-bindings: net: dwmac: Add MTL Tx " Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-23 11:55 ` Serge Semin 2023-03-23 11:55 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 13/16] dt-bindings: net: dwmac: Fix MTL Tx Queue props description Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-23 12:03 ` Serge Semin 2023-03-23 12:03 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 14/16] dt-bindings: net: dwmac: Use flag definition instead of booleans Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-16 8:09 ` Krzysztof Kozlowski 2023-03-16 8:09 ` Krzysztof Kozlowski 2023-03-23 12:08 ` Serge Semin 2023-03-23 12:08 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-17 20:56 ` Rob Herring 2023-03-17 20:56 ` Rob Herring 2023-03-23 15:10 ` Serge Semin 2023-03-23 15:10 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 16/16] dt-bindings: net: dwmac: Add MTL Tx queue CBS-algo " Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-17 20:57 ` Rob Herring 2023-03-17 20:57 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230313225103.30512-4-Sergey.Semin@baikalelectronics.ru \ --to=sergey.semin@baikalelectronics.ru \ --cc=Alexey.Malahov@baikalelectronics.ru \ --cc=Pavel.Parkhomenko@baikalelectronics.ru \ --cc=alexandre.torgue@foss.st.com \ --cc=ansuelsmth@gmail.com \ --cc=biao.huang@mediatek.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=fancer.lancer@gmail.com \ --cc=joabreu@synopsys.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=peppe.cavallaro@st.com \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=yangyingliang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.