From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>, Serge Semin <fancer.lancer@gmail.com>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Christian Marangi <ansuelsmth@gmail.com>, Richard Cochran <richardcochran@gmail.com>, Biao Huang <biao.huang@mediatek.com>, Yang Yingliang <yangyingliang@huawei.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org> Subject: [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Date: Tue, 14 Mar 2023 01:50:49 +0300 [thread overview] Message-ID: <20230313225103.30512-3-Sergey.Semin@baikalelectronics.ru> (raw) In-Reply-To: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> In accordance with [1] the permitted PBL values can be set as one of [1, 2, 4, 8, 16, 32]. The rest of the values result in undefined behavior. At the same time some of the permitted values can be also invalid depending on the controller FIFOs size and the data bus width. Due to having too many variables all the possible PBL property constraints can't be implemented in the bindings schema, let's extend the set of permitted PBL values to be as much as the configuration register supports leaving the undefined behaviour cases for developers to handle. [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, October 2013, p. 380. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Rob Herring <robh@kernel.org> --- Changelog v1: - Use correct syntax of the JSON pointers, so the later would begin with a '/' after the '#'. --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index a0a0437eb4f0..fb9b8506a48f 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -428,23 +428,26 @@ properties: snps,pbl: description: - Programmable Burst Length (tx and rx) + Programmable Burst Length (tx and rx). Note some of these values + can be still invalid due to HW limitations connected with the data + bus width and the FIFOs depth, so a total length of a single DMA + burst shouldn't exceed half the FIFO depth. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [2, 4, 8] + enum: [1, 2, 4, 8, 16, 32] snps,txpbl: description: Tx Programmable Burst Length. If set, DMA tx will use this value rather than snps,pbl. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [2, 4, 8] + enum: [1, 2, 4, 8, 16, 32] snps,rxpbl: description: Rx Programmable Burst Length. If set, DMA rx will use this value rather than snps,pbl. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [2, 4, 8] + enum: [1, 2, 4, 8, 16, 32] snps,no-pbl-x8: $ref: /schemas/types.yaml#/definitions/flag -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>, Serge Semin <fancer.lancer@gmail.com>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Christian Marangi <ansuelsmth@gmail.com>, Richard Cochran <richardcochran@gmail.com>, Biao Huang <biao.huang@mediatek.com>, Yang Yingliang <yangyingliang@huawei.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org> Subject: [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Date: Tue, 14 Mar 2023 01:50:49 +0300 [thread overview] Message-ID: <20230313225103.30512-3-Sergey.Semin@baikalelectronics.ru> (raw) In-Reply-To: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> In accordance with [1] the permitted PBL values can be set as one of [1, 2, 4, 8, 16, 32]. The rest of the values result in undefined behavior. At the same time some of the permitted values can be also invalid depending on the controller FIFOs size and the data bus width. Due to having too many variables all the possible PBL property constraints can't be implemented in the bindings schema, let's extend the set of permitted PBL values to be as much as the configuration register supports leaving the undefined behaviour cases for developers to handle. [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, October 2013, p. 380. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Rob Herring <robh@kernel.org> --- Changelog v1: - Use correct syntax of the JSON pointers, so the later would begin with a '/' after the '#'. --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index a0a0437eb4f0..fb9b8506a48f 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -428,23 +428,26 @@ properties: snps,pbl: description: - Programmable Burst Length (tx and rx) + Programmable Burst Length (tx and rx). Note some of these values + can be still invalid due to HW limitations connected with the data + bus width and the FIFOs depth, so a total length of a single DMA + burst shouldn't exceed half the FIFO depth. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [2, 4, 8] + enum: [1, 2, 4, 8, 16, 32] snps,txpbl: description: Tx Programmable Burst Length. If set, DMA tx will use this value rather than snps,pbl. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [2, 4, 8] + enum: [1, 2, 4, 8, 16, 32] snps,rxpbl: description: Rx Programmable Burst Length. If set, DMA rx will use this value rather than snps,pbl. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [2, 4, 8] + enum: [1, 2, 4, 8, 16, 32] snps,no-pbl-x8: $ref: /schemas/types.yaml#/definitions/flag -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-13 22:52 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-13 22:50 [PATCH net-next 00/16] dt-bindings: net: dwmac: Extend clocks, props desc and constraints Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-14 14:10 ` Rob Herring 2023-03-14 14:10 ` Rob Herring 2023-03-14 15:06 ` Serge Semin 2023-03-14 15:06 ` Serge Semin 2023-03-14 17:09 ` Serge Semin 2023-03-14 17:09 ` Serge Semin 2023-03-16 20:40 ` Rob Herring 2023-03-16 20:40 ` Rob Herring 2023-03-16 20:50 ` Serge Semin 2023-03-16 20:50 ` Serge Semin 2023-03-13 22:50 ` Serge Semin [this message] 2023-03-13 22:50 ` [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Serge Semin 2023-03-13 22:50 ` [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 04/16] dt-bindings: net: dwmac: Detach Generic DW MAC bindings Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 05/16] dt-bindings: net: dwmac: Elaborate snps,clk-csr description Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:04 ` Krzysztof Kozlowski 2023-03-16 8:04 ` Krzysztof Kozlowski 2023-03-13 22:50 ` [PATCH net-next 06/16] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk clocks description Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 07/16] dt-bindings: net: dwmac: Add Tx/Rx clock sources Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:05 ` Krzysztof Kozlowski 2023-03-16 8:05 ` Krzysztof Kozlowski 2023-03-13 22:50 ` [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-23 11:37 ` Serge Semin 2023-03-23 11:37 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 10/16] dt-bindings: net: dwmac: Add AXI-bus properties constraints Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-16 8:06 ` Krzysztof Kozlowski 2023-03-23 11:49 ` Serge Semin 2023-03-23 11:49 ` Serge Semin 2023-03-13 22:50 ` [PATCH net-next 11/16] dt-bindings: net: dwmac: Add MTL Rx Queue " Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:07 ` Krzysztof Kozlowski 2023-03-16 8:07 ` Krzysztof Kozlowski 2023-03-13 22:50 ` [PATCH net-next 12/16] dt-bindings: net: dwmac: Add MTL Tx " Serge Semin 2023-03-13 22:50 ` Serge Semin 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-23 11:55 ` Serge Semin 2023-03-23 11:55 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 13/16] dt-bindings: net: dwmac: Fix MTL Tx Queue props description Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-16 8:08 ` Krzysztof Kozlowski 2023-03-23 12:03 ` Serge Semin 2023-03-23 12:03 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 14/16] dt-bindings: net: dwmac: Use flag definition instead of booleans Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-16 8:09 ` Krzysztof Kozlowski 2023-03-16 8:09 ` Krzysztof Kozlowski 2023-03-23 12:08 ` Serge Semin 2023-03-23 12:08 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-17 20:56 ` Rob Herring 2023-03-17 20:56 ` Rob Herring 2023-03-23 15:10 ` Serge Semin 2023-03-23 15:10 ` Serge Semin 2023-03-13 22:51 ` [PATCH net-next 16/16] dt-bindings: net: dwmac: Add MTL Tx queue CBS-algo " Serge Semin 2023-03-13 22:51 ` Serge Semin 2023-03-17 20:57 ` Rob Herring 2023-03-17 20:57 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230313225103.30512-3-Sergey.Semin@baikalelectronics.ru \ --to=sergey.semin@baikalelectronics.ru \ --cc=Alexey.Malahov@baikalelectronics.ru \ --cc=Pavel.Parkhomenko@baikalelectronics.ru \ --cc=alexandre.torgue@foss.st.com \ --cc=ansuelsmth@gmail.com \ --cc=biao.huang@mediatek.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=fancer.lancer@gmail.com \ --cc=joabreu@synopsys.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=peppe.cavallaro@st.com \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=yangyingliang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.