From: "Manna, Animesh" <animesh.manna@intel.com> To: Harry Wentland <hwentlan@amd.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jani.nikula@intel.com, nidhi1.gupta@intel.com, manasi.d.navare@intel.com, uma.shankar@intel.com, anshuman.gupta@intel.com, Alex Deucher <alexander.deucher@amd.com> Subject: Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue. Date: Wed, 18 Dec 2019 21:43:49 +0530 [thread overview] Message-ID: <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com> (raw) In-Reply-To: <03119efd-5130-3851-5dec-bd4ef5b8cfd5@amd.com> On 18-12-2019 21:12, Harry Wentland wrote: > On 2019-12-18 10:13 a.m., Animesh Manna wrote: >> [Why]: >> Aligh with DP spec wanted to follow same naming convention. >> >> [How]: >> Changed the macro name of the dpcd address used for getting requested >> test-pattern. >> > Please roll this into your patch that renames the definition. All > patches should compile on their own. Thanks Harry for review, wanted to follow similar commit-description format followed in amd-driver compare to i915 and created a separate patch. Maybe is it good idea to change the patch sequence and make it as first patch. Regards, Animesh > > Thanks, > Harry > >> Cc: Harry Wentland <harry.wentland@amd.com> >> Cc: Alex Deucher <alexander.deucher@amd.com> >> Signed-off-by: Animesh Manna <animesh.manna@intel.com> >> --- >> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> index 42aa889fd0f5..1a6109be2fce 100644 >> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> @@ -2491,7 +2491,7 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link) >> /* get phy test pattern and pattern parameters from DP receiver */ >> core_link_read_dpcd( >> link, >> - DP_TEST_PHY_PATTERN, >> + DP_PHY_TEST_PATTERN, >> &dpcd_test_pattern.raw, >> sizeof(dpcd_test_pattern)); >> core_link_read_dpcd( >> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Manna, Animesh" <animesh.manna@intel.com> To: Harry Wentland <hwentlan@amd.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jani.nikula@intel.com, nidhi1.gupta@intel.com, Alex Deucher <alexander.deucher@amd.com>, Harry Wentland <harry.wentland@amd.com> Subject: Re: [Intel-gfx] [PATCH v2 2/9] drm/amd/display: Fix compilation issue. Date: Wed, 18 Dec 2019 21:43:49 +0530 [thread overview] Message-ID: <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com> (raw) In-Reply-To: <03119efd-5130-3851-5dec-bd4ef5b8cfd5@amd.com> On 18-12-2019 21:12, Harry Wentland wrote: > On 2019-12-18 10:13 a.m., Animesh Manna wrote: >> [Why]: >> Aligh with DP spec wanted to follow same naming convention. >> >> [How]: >> Changed the macro name of the dpcd address used for getting requested >> test-pattern. >> > Please roll this into your patch that renames the definition. All > patches should compile on their own. Thanks Harry for review, wanted to follow similar commit-description format followed in amd-driver compare to i915 and created a separate patch. Maybe is it good idea to change the patch sequence and make it as first patch. Regards, Animesh > > Thanks, > Harry > >> Cc: Harry Wentland <harry.wentland@amd.com> >> Cc: Alex Deucher <alexander.deucher@amd.com> >> Signed-off-by: Animesh Manna <animesh.manna@intel.com> >> --- >> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> index 42aa889fd0f5..1a6109be2fce 100644 >> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >> @@ -2491,7 +2491,7 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link) >> /* get phy test pattern and pattern parameters from DP receiver */ >> core_link_read_dpcd( >> link, >> - DP_TEST_PHY_PATTERN, >> + DP_PHY_TEST_PATTERN, >> &dpcd_test_pattern.raw, >> sizeof(dpcd_test_pattern)); >> core_link_read_dpcd( >> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-18 16:14 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-18 15:13 [PATCH v2 0/9] DP Phy compliance auto test Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 1/9] drm/dp: get/set phy compliance pattern Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 2/9] drm/amd/display: Fix compilation issue Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:42 ` Harry Wentland 2019-12-18 15:42 ` [Intel-gfx] " Harry Wentland 2019-12-18 16:13 ` Manna, Animesh [this message] 2019-12-18 16:13 ` Manna, Animesh 2019-12-18 16:22 ` Harry Wentland 2019-12-18 16:22 ` [Intel-gfx] " Harry Wentland 2019-12-18 23:53 ` Manasi Navare 2019-12-18 23:53 ` [Intel-gfx] " Manasi Navare 2019-12-19 13:36 ` Manna, Animesh 2019-12-19 13:36 ` [Intel-gfx] " Manna, Animesh 2019-12-23 17:03 ` [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec Animesh Manna 2019-12-23 17:03 ` [Intel-gfx] " Animesh Manna 2019-12-23 17:03 ` [PATCH v3 2/9] drm/dp: get/set phy compliance pattern Animesh Manna 2019-12-23 17:03 ` [Intel-gfx] " Animesh Manna 2019-12-23 19:53 ` Harry Wentland 2019-12-23 19:53 ` [Intel-gfx] " Harry Wentland 2019-12-30 16:05 ` Manna, Animesh 2019-12-30 16:05 ` [Intel-gfx] " Manna, Animesh 2019-12-30 16:11 ` Harry Wentland 2019-12-30 16:11 ` [Intel-gfx] " Harry Wentland 2019-12-30 16:30 ` Manna, Animesh 2019-12-30 16:30 ` [Intel-gfx] " Manna, Animesh 2019-12-23 19:53 ` [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec Harry Wentland 2019-12-23 19:53 ` [Intel-gfx] " Harry Wentland 2019-12-18 15:13 ` [PATCH v2 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-19 10:51 ` Jani Nikula 2019-12-19 10:51 ` [Intel-gfx] " Jani Nikula 2019-12-19 13:27 ` Manna, Animesh 2019-12-19 13:27 ` [Intel-gfx] " Manna, Animesh 2019-12-19 12:33 ` Ville Syrjälä 2019-12-19 12:33 ` [Intel-gfx] " Ville Syrjälä 2019-12-19 13:31 ` Manna, Animesh 2019-12-19 13:31 ` [Intel-gfx] " Manna, Animesh 2019-12-23 16:45 ` [PATCH v3 " Animesh Manna 2019-12-23 16:45 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 4/9] drm/i915/dp: Preparation for DP phy compliance auto test Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 5/9] drm/i915/dsb: Send uevent to testapp Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 6/9] drm/i915/dp: Add debugfs entry for DP phy compliance Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 7/9] drm/i915/dp: Register definition for DP compliance register Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 8/9] drm/i915/dp: Update the pattern as per request Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 15:13 ` [PATCH v2 9/9] drm/i915/dp: [FIXME] Program vswing, pre-emphasis, test-pattern Animesh Manna 2019-12-18 15:13 ` [Intel-gfx] " Animesh Manna 2019-12-18 18:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP Phy compliance auto test Patchwork 2019-12-18 18:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2019-12-18 19:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2019-12-20 4:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2019-12-23 19:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DP Phy compliance auto test (rev4) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com \ --to=animesh.manna@intel.com \ --cc=alexander.deucher@amd.com \ --cc=anshuman.gupta@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hwentlan@amd.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=manasi.d.navare@intel.com \ --cc=nidhi1.gupta@intel.com \ --cc=uma.shankar@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.