From: Tamizh chelvam <tamizhr@codeaurora.org> To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> Cc: ath10k@lists.infradead.org, johannes@sipsolutions.net, linux-wireless@vger.kernel.org, Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> Subject: Re: [PATCH 1/4] New netlink command for TID specific configuration Date: Thu, 08 Nov 2018 23:17:22 +0530 [thread overview] Message-ID: <0b75171a7777bd25e203240a3a119cb5@codeaurora.org> (raw) In-Reply-To: <20181107140552.zfuusbapgqjumoln@bars> > Hello Tamizh, > >> Co-Developed-by: Tamizh Chelvam <tamizhr@codeaurora.org> >> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> >> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org> >> --- >> include/net/cfg80211.h | 14 +++++++ >> include/uapi/linux/nl80211.h | 69 +++++++++++++++++++++++++++++++++ >> net/wireless/nl80211.c | 86 >> ++++++++++++++++++++++++++++++++++++++++++ >> net/wireless/rdev-ops.h | 15 ++++++++ >> net/wireless/trace.h | 27 +++++++++++++ >> 5 files changed, 211 insertions(+) > > ... > >> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c >> index d744388..d386ad7 100644 >> --- a/net/wireless/nl80211.c >> +++ b/net/wireless/nl80211.c > > ... > >> +static int nl80211_set_tid_config(struct sk_buff *skb, >> + struct genl_info *info) >> +{ >> + struct cfg80211_registered_device *rdev = info->user_ptr[0]; >> + struct nlattr *attrs[NL80211_ATTR_TID_MAX + 1]; >> + struct nlattr *tid; >> + struct net_device *dev = info->user_ptr[1]; >> + const char *peer = NULL; >> + u8 tid_no; >> + int ret = -EINVAL, retry_short = -1, retry_long = -1; >> + >> + tid = info->attrs[NL80211_ATTR_TID_CONFIG]; >> + if (!tid) >> + return -EINVAL; >> + >> + ret = nla_parse_nested(attrs, NL80211_ATTR_TID_MAX, tid, >> + nl80211_attr_tid_policy, info->extack); >> + if (ret) >> + return ret; >> + >> + if (!attrs[NL80211_ATTR_TID]) >> + return -EINVAL; >> + >> + if (attrs[NL80211_ATTR_TID_RETRY_SHORT]) { >> + retry_short = >> nla_get_u8(attrs[NL80211_ATTR_TID_RETRY_SHORT]); >> + if (!retry_short || >> + retry_short > rdev->wiphy.max_data_retry_count) >> + return -EINVAL; >> + } >> + >> + if (attrs[NL80211_ATTR_TID_RETRY_LONG]) { >> + retry_long = >> nla_get_u8(attrs[NL80211_ATTR_TID_RETRY_LONG]); >> + if (!retry_long || >> + retry_long > rdev->wiphy.max_data_retry_count) >> + return -EINVAL; >> + } >> + >> + tid_no = nla_get_u8(attrs[NL80211_ATTR_TID]); >> + if (tid_no >= IEEE80211_FIRST_TSPEC_TSID) >> + return -EINVAL; >> + >> + if (info->attrs[NL80211_ATTR_MAC]) >> + peer = nla_data(info->attrs[NL80211_ATTR_MAC]); >> + >> + if (nla_get_flag(attrs[NL80211_ATTR_TID_RETRY_CONFIG])) { > > Do we really need this additional flag to indicate retry data ? > Maybe we can simply check retry attrs or even retry data, e.g.: Yes, because this implementation gives provision to set default retry count for TID traffic type for a station. Since we use single NL command for all TID configurations, this flag will be useful to notify the driver about retry TID configuration change. > > if (attrs[NL80211_ATTR_TID_RETRY_LONG] || > attrs[NL80211_ATTR_TID_RETRY_SHORT]) { > ... > > if ((retry_short > 0) || (retry_long > 0)) { > ... > >> + if (!wiphy_ext_feature_isset( >> + &rdev->wiphy, >> + >> NL80211_EXT_FEATURE_PER_TID_RETRY_CONFIG)) >> + return -EOPNOTSUPP; >> + >> + if (peer && !wiphy_ext_feature_isset( >> + &rdev->wiphy, >> + >> NL80211_EXT_FEATURE_PER_STA_RETRY_CONFIG)) >> + return -EOPNOTSUPP; >> + >> + if (!rdev->ops->set_data_retry_count || >> + !rdev->wiphy.max_data_retry_count) >> + return -EOPNOTSUPP; >> + >> + ret = rdev_set_data_retry_count(rdev, dev, peer, >> tid_no, >> + retry_short, >> retry_long); >> + } >> + >> + return ret; >> +} > > Regards, > Sergey Thanks, Tamizh.
WARNING: multiple messages have this Message-ID (diff)
From: Tamizh chelvam <tamizhr@codeaurora.org> To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>, ath10k@lists.infradead.org Subject: Re: [PATCH 1/4] New netlink command for TID specific configuration Date: Thu, 08 Nov 2018 23:17:22 +0530 [thread overview] Message-ID: <0b75171a7777bd25e203240a3a119cb5@codeaurora.org> (raw) In-Reply-To: <20181107140552.zfuusbapgqjumoln@bars> > Hello Tamizh, > >> Co-Developed-by: Tamizh Chelvam <tamizhr@codeaurora.org> >> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> >> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org> >> --- >> include/net/cfg80211.h | 14 +++++++ >> include/uapi/linux/nl80211.h | 69 +++++++++++++++++++++++++++++++++ >> net/wireless/nl80211.c | 86 >> ++++++++++++++++++++++++++++++++++++++++++ >> net/wireless/rdev-ops.h | 15 ++++++++ >> net/wireless/trace.h | 27 +++++++++++++ >> 5 files changed, 211 insertions(+) > > ... > >> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c >> index d744388..d386ad7 100644 >> --- a/net/wireless/nl80211.c >> +++ b/net/wireless/nl80211.c > > ... > >> +static int nl80211_set_tid_config(struct sk_buff *skb, >> + struct genl_info *info) >> +{ >> + struct cfg80211_registered_device *rdev = info->user_ptr[0]; >> + struct nlattr *attrs[NL80211_ATTR_TID_MAX + 1]; >> + struct nlattr *tid; >> + struct net_device *dev = info->user_ptr[1]; >> + const char *peer = NULL; >> + u8 tid_no; >> + int ret = -EINVAL, retry_short = -1, retry_long = -1; >> + >> + tid = info->attrs[NL80211_ATTR_TID_CONFIG]; >> + if (!tid) >> + return -EINVAL; >> + >> + ret = nla_parse_nested(attrs, NL80211_ATTR_TID_MAX, tid, >> + nl80211_attr_tid_policy, info->extack); >> + if (ret) >> + return ret; >> + >> + if (!attrs[NL80211_ATTR_TID]) >> + return -EINVAL; >> + >> + if (attrs[NL80211_ATTR_TID_RETRY_SHORT]) { >> + retry_short = >> nla_get_u8(attrs[NL80211_ATTR_TID_RETRY_SHORT]); >> + if (!retry_short || >> + retry_short > rdev->wiphy.max_data_retry_count) >> + return -EINVAL; >> + } >> + >> + if (attrs[NL80211_ATTR_TID_RETRY_LONG]) { >> + retry_long = >> nla_get_u8(attrs[NL80211_ATTR_TID_RETRY_LONG]); >> + if (!retry_long || >> + retry_long > rdev->wiphy.max_data_retry_count) >> + return -EINVAL; >> + } >> + >> + tid_no = nla_get_u8(attrs[NL80211_ATTR_TID]); >> + if (tid_no >= IEEE80211_FIRST_TSPEC_TSID) >> + return -EINVAL; >> + >> + if (info->attrs[NL80211_ATTR_MAC]) >> + peer = nla_data(info->attrs[NL80211_ATTR_MAC]); >> + >> + if (nla_get_flag(attrs[NL80211_ATTR_TID_RETRY_CONFIG])) { > > Do we really need this additional flag to indicate retry data ? > Maybe we can simply check retry attrs or even retry data, e.g.: Yes, because this implementation gives provision to set default retry count for TID traffic type for a station. Since we use single NL command for all TID configurations, this flag will be useful to notify the driver about retry TID configuration change. > > if (attrs[NL80211_ATTR_TID_RETRY_LONG] || > attrs[NL80211_ATTR_TID_RETRY_SHORT]) { > ... > > if ((retry_short > 0) || (retry_long > 0)) { > ... > >> + if (!wiphy_ext_feature_isset( >> + &rdev->wiphy, >> + >> NL80211_EXT_FEATURE_PER_TID_RETRY_CONFIG)) >> + return -EOPNOTSUPP; >> + >> + if (peer && !wiphy_ext_feature_isset( >> + &rdev->wiphy, >> + >> NL80211_EXT_FEATURE_PER_STA_RETRY_CONFIG)) >> + return -EOPNOTSUPP; >> + >> + if (!rdev->ops->set_data_retry_count || >> + !rdev->wiphy.max_data_retry_count) >> + return -EOPNOTSUPP; >> + >> + ret = rdev_set_data_retry_count(rdev, dev, peer, >> tid_no, >> + retry_short, >> retry_long); >> + } >> + >> + return ret; >> +} > > Regards, > Sergey Thanks, Tamizh. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-11-08 17:47 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-22 17:55 [PATCH 0/4] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-10-22 17:55 ` [PATCH 1/4] New netlink command " Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-06 10:16 ` Sergey Matyukevich 2018-11-06 10:16 ` Sergey Matyukevich 2018-11-08 17:29 ` Tamizh chelvam 2018-11-08 17:29 ` Tamizh chelvam 2018-11-09 9:47 ` Sergey Matyukevich 2018-11-09 9:47 ` Sergey Matyukevich 2018-11-06 11:31 ` Johannes Berg 2018-11-06 11:31 ` Johannes Berg 2018-11-07 14:05 ` Sergey Matyukevich 2018-11-07 14:05 ` Sergey Matyukevich 2018-11-08 17:47 ` Tamizh chelvam [this message] 2018-11-08 17:47 ` Tamizh chelvam 2018-11-09 9:40 ` Sergey Matyukevich 2018-11-09 9:40 ` Sergey Matyukevich 2018-11-09 12:24 ` Johannes Berg 2018-11-09 12:24 ` Johannes Berg 2018-11-13 6:46 ` Tamizh chelvam 2018-11-13 6:46 ` Tamizh chelvam 2018-11-09 11:37 ` Johannes Berg 2018-11-09 11:37 ` Johannes Berg 2018-10-22 17:55 ` [PATCH 2/4] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-06 10:21 ` Sergey Matyukevich 2018-11-06 10:21 ` Sergey Matyukevich 2018-11-08 12:28 ` Tamizh chelvam 2018-11-08 12:28 ` Tamizh chelvam 2018-10-22 17:55 ` [PATCH 3/4] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-06 10:33 ` Sergey Matyukevich 2018-11-06 10:33 ` Sergey Matyukevich 2018-11-08 12:42 ` Tamizh chelvam 2018-11-08 12:42 ` Tamizh chelvam 2018-11-07 23:55 ` Igor Mitsyanko 2018-11-07 23:55 ` Igor Mitsyanko 2018-10-22 17:55 ` [PATCH 4/4] ath10k: Add support to configure " Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-09 9:26 ` Sergey Matyukevich 2018-11-09 9:26 ` Sergey Matyukevich 2018-11-05 20:43 ` [PATCH 0/4] cfg80211/mac80211: Add support for " Johannes Berg 2018-11-05 20:43 ` Johannes Berg 2018-11-06 10:45 ` Sergey Matyukevich 2018-11-06 10:45 ` Sergey Matyukevich 2018-11-06 11:28 ` Johannes Berg 2018-11-06 11:28 ` Johannes Berg 2018-11-06 12:17 ` Sergey Matyukevich 2018-11-06 12:17 ` Sergey Matyukevich 2018-11-08 0:55 ` Igor Mitsyanko 2018-11-08 0:55 ` Igor Mitsyanko 2018-11-08 16:31 ` Ben Greear 2018-11-08 16:31 ` Ben Greear 2019-02-13 19:01 ` Sergey Matyukevich 2019-02-13 19:01 ` Sergey Matyukevich [not found] ` <a7d97b692da245a8b85769d7766ceba7@aphydexm01f.ap.qualcomm.com> 2019-02-14 7:14 ` Tamizh chelvam 2019-02-14 7:14 ` Tamizh chelvam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0b75171a7777bd25e203240a3a119cb5@codeaurora.org \ --to=tamizhr@codeaurora.org \ --cc=ath10k@lists.infradead.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ --cc=sergey.matyukevich.os@quantenna.com \ --cc=vthiagar@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.