From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> To: Tamizh chelvam <tamizhr@codeaurora.org> Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>, "johannes@sipsolutions.net" <johannes@sipsolutions.net>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org> Subject: Re: [PATCH 4/4] ath10k: Add support to configure TID specific configuration Date: Fri, 9 Nov 2018 09:26:03 +0000 [thread overview] Message-ID: <20181109092557.ciw457se3ssajl3v@bars> (raw) In-Reply-To: <1540230918-27712-5-git-send-email-tamizhr@codeaurora.org> Hello Tamizh, > Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org> > --- > drivers/net/wireless/ath/ath10k/core.h | 23 ++++ > drivers/net/wireless/ath/ath10k/mac.c | 240 +++++++++++++++++++++++++++++---- > drivers/net/wireless/ath/ath10k/wmi.c | 6 +- > drivers/net/wireless/ath/ath10k/wmi.h | 1 + > 4 files changed, 245 insertions(+), 25 deletions(-) ... > +static int ath10k_mac_op_set_tid_conf(struct ieee80211_hw *hw, > + struct ieee80211_vif *vif, > + struct ieee80211_sta *sta, > + struct ieee80211_tid_conf *tid_conf, > + u8 changed) > +{ > + int ret; > + struct ath10k *ar = hw->priv; > + struct ath10k_vif *arvif = (void *)vif->drv_priv; > + struct ath10k_mac_iter_tid_config data = {}; > + struct wmi_per_peer_per_tid_cfg_arg arg = {}; > + struct ath10k_sta *arsta; > + > + if (!(changed & TID_RETRY_CONF_CHANGED) && > + !(changed & TID_AGGR_CONF_CHANGED)) > + return 0; > + > + mutex_lock(&ar->conf_mutex); > + arg.vdev_id = arvif->vdev_id; > + arg.tid = tid_conf->tid; > + > + if (sta) { > + arsta = (struct ath10k_sta *)sta->drv_priv; > + ether_addr_copy(arg.peer_macaddr.addr, sta->addr); > + > + if (changed & TID_RETRY_CONF_CHANGED) { > + if (tid_conf->retry_long == > + arsta->retry_count[arg.tid]) { > + ret = 0; > + goto exit; > + } > + > + if (tid_conf->retry_long == -1) { > + if (arvif->retry_count[arg.tid]) > + arg.retry_count = > + arvif->retry_count[arg.tid]; > + else > + arg.retry_count = > + ATH10K_MAX_RETRY_COUNT; > + } else { > + arg.retry_count = tid_conf->retry_long; > + } > + } > + if (changed & TID_AGGR_CONF_CHANGED) { > + if (tid_conf->aggr) > + arg.aggr_control = > + WMI_TID_CONFIG_AGGR_CONTROL_ENABLE; > + else > + arg.aggr_control = > + WMI_TID_CONFIG_AGGR_CONTROL_DISABLE; > + } > + > + ret = ath10k_wmi_set_per_peer_per_tid_cfg(ar, &arg); > + if (!ret) { > + /* Store the configured parameters in success case */ > + if (changed & TID_RETRY_CONF_CHANGED) > + arsta->retry_count[arg.tid] = > + tid_conf->retry_long; > + if (changed & TID_AGGR_CONF_CHANGED) > + arsta->aggr_ctrl[arg.tid] = arg.aggr_control; > + } > + > + goto exit; > + } > + > + ret = 0; > + > + if (changed & TID_RETRY_CONF_CHANGED) > + arvif->retry_count[tid_conf->tid] = tid_conf->retry_long; Shouldn't it use default ATH10K_MAX_RETRY_COUNT value when incoming retry_long value is -1 ? Regards, Sergey
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> To: Tamizh chelvam <tamizhr@codeaurora.org> Cc: "johannes@sipsolutions.net" <johannes@sipsolutions.net>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [PATCH 4/4] ath10k: Add support to configure TID specific configuration Date: Fri, 9 Nov 2018 09:26:03 +0000 [thread overview] Message-ID: <20181109092557.ciw457se3ssajl3v@bars> (raw) In-Reply-To: <1540230918-27712-5-git-send-email-tamizhr@codeaurora.org> Hello Tamizh, > Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org> > --- > drivers/net/wireless/ath/ath10k/core.h | 23 ++++ > drivers/net/wireless/ath/ath10k/mac.c | 240 +++++++++++++++++++++++++++++---- > drivers/net/wireless/ath/ath10k/wmi.c | 6 +- > drivers/net/wireless/ath/ath10k/wmi.h | 1 + > 4 files changed, 245 insertions(+), 25 deletions(-) ... > +static int ath10k_mac_op_set_tid_conf(struct ieee80211_hw *hw, > + struct ieee80211_vif *vif, > + struct ieee80211_sta *sta, > + struct ieee80211_tid_conf *tid_conf, > + u8 changed) > +{ > + int ret; > + struct ath10k *ar = hw->priv; > + struct ath10k_vif *arvif = (void *)vif->drv_priv; > + struct ath10k_mac_iter_tid_config data = {}; > + struct wmi_per_peer_per_tid_cfg_arg arg = {}; > + struct ath10k_sta *arsta; > + > + if (!(changed & TID_RETRY_CONF_CHANGED) && > + !(changed & TID_AGGR_CONF_CHANGED)) > + return 0; > + > + mutex_lock(&ar->conf_mutex); > + arg.vdev_id = arvif->vdev_id; > + arg.tid = tid_conf->tid; > + > + if (sta) { > + arsta = (struct ath10k_sta *)sta->drv_priv; > + ether_addr_copy(arg.peer_macaddr.addr, sta->addr); > + > + if (changed & TID_RETRY_CONF_CHANGED) { > + if (tid_conf->retry_long == > + arsta->retry_count[arg.tid]) { > + ret = 0; > + goto exit; > + } > + > + if (tid_conf->retry_long == -1) { > + if (arvif->retry_count[arg.tid]) > + arg.retry_count = > + arvif->retry_count[arg.tid]; > + else > + arg.retry_count = > + ATH10K_MAX_RETRY_COUNT; > + } else { > + arg.retry_count = tid_conf->retry_long; > + } > + } > + if (changed & TID_AGGR_CONF_CHANGED) { > + if (tid_conf->aggr) > + arg.aggr_control = > + WMI_TID_CONFIG_AGGR_CONTROL_ENABLE; > + else > + arg.aggr_control = > + WMI_TID_CONFIG_AGGR_CONTROL_DISABLE; > + } > + > + ret = ath10k_wmi_set_per_peer_per_tid_cfg(ar, &arg); > + if (!ret) { > + /* Store the configured parameters in success case */ > + if (changed & TID_RETRY_CONF_CHANGED) > + arsta->retry_count[arg.tid] = > + tid_conf->retry_long; > + if (changed & TID_AGGR_CONF_CHANGED) > + arsta->aggr_ctrl[arg.tid] = arg.aggr_control; > + } > + > + goto exit; > + } > + > + ret = 0; > + > + if (changed & TID_RETRY_CONF_CHANGED) > + arvif->retry_count[tid_conf->tid] = tid_conf->retry_long; Shouldn't it use default ATH10K_MAX_RETRY_COUNT value when incoming retry_long value is -1 ? Regards, Sergey _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-11-09 9:26 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-22 17:55 [PATCH 0/4] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-10-22 17:55 ` [PATCH 1/4] New netlink command " Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-06 10:16 ` Sergey Matyukevich 2018-11-06 10:16 ` Sergey Matyukevich 2018-11-08 17:29 ` Tamizh chelvam 2018-11-08 17:29 ` Tamizh chelvam 2018-11-09 9:47 ` Sergey Matyukevich 2018-11-09 9:47 ` Sergey Matyukevich 2018-11-06 11:31 ` Johannes Berg 2018-11-06 11:31 ` Johannes Berg 2018-11-07 14:05 ` Sergey Matyukevich 2018-11-07 14:05 ` Sergey Matyukevich 2018-11-08 17:47 ` Tamizh chelvam 2018-11-08 17:47 ` Tamizh chelvam 2018-11-09 9:40 ` Sergey Matyukevich 2018-11-09 9:40 ` Sergey Matyukevich 2018-11-09 12:24 ` Johannes Berg 2018-11-09 12:24 ` Johannes Berg 2018-11-13 6:46 ` Tamizh chelvam 2018-11-13 6:46 ` Tamizh chelvam 2018-11-09 11:37 ` Johannes Berg 2018-11-09 11:37 ` Johannes Berg 2018-10-22 17:55 ` [PATCH 2/4] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-06 10:21 ` Sergey Matyukevich 2018-11-06 10:21 ` Sergey Matyukevich 2018-11-08 12:28 ` Tamizh chelvam 2018-11-08 12:28 ` Tamizh chelvam 2018-10-22 17:55 ` [PATCH 3/4] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-06 10:33 ` Sergey Matyukevich 2018-11-06 10:33 ` Sergey Matyukevich 2018-11-08 12:42 ` Tamizh chelvam 2018-11-08 12:42 ` Tamizh chelvam 2018-11-07 23:55 ` Igor Mitsyanko 2018-11-07 23:55 ` Igor Mitsyanko 2018-10-22 17:55 ` [PATCH 4/4] ath10k: Add support to configure " Tamizh chelvam 2018-10-22 17:55 ` Tamizh chelvam 2018-11-09 9:26 ` Sergey Matyukevich [this message] 2018-11-09 9:26 ` Sergey Matyukevich 2018-11-05 20:43 ` [PATCH 0/4] cfg80211/mac80211: Add support for " Johannes Berg 2018-11-05 20:43 ` Johannes Berg 2018-11-06 10:45 ` Sergey Matyukevich 2018-11-06 10:45 ` Sergey Matyukevich 2018-11-06 11:28 ` Johannes Berg 2018-11-06 11:28 ` Johannes Berg 2018-11-06 12:17 ` Sergey Matyukevich 2018-11-06 12:17 ` Sergey Matyukevich 2018-11-08 0:55 ` Igor Mitsyanko 2018-11-08 0:55 ` Igor Mitsyanko 2018-11-08 16:31 ` Ben Greear 2018-11-08 16:31 ` Ben Greear 2019-02-13 19:01 ` Sergey Matyukevich 2019-02-13 19:01 ` Sergey Matyukevich [not found] ` <a7d97b692da245a8b85769d7766ceba7@aphydexm01f.ap.qualcomm.com> 2019-02-14 7:14 ` Tamizh chelvam 2019-02-14 7:14 ` Tamizh chelvam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181109092557.ciw457se3ssajl3v@bars \ --to=sergey.matyukevich.os@quantenna.com \ --cc=ath10k@lists.infradead.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ --cc=tamizhr@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.