From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Subject: Re: [PATCH 1/4] New netlink command for TID specific configuration
Date: Tue, 13 Nov 2018 12:16:22 +0530 [thread overview]
Message-ID: <f024b86729f2361aeb0e8939db8d3a04@codeaurora.org> (raw)
In-Reply-To: <dda0f03868f631ba9f76170e19dd28099a0e0add.camel@sipsolutions.net>
On 2018-11-09 17:54, Johannes Berg wrote:
> On Fri, 2018-11-09 at 09:40 +0000, Sergey Matyukevich wrote:
>>
>> Ok. So if driver receives retry value (-1), it should reset to some
>> default value known to driver or firmware. IMHO it worth making it
>> more explicit: in its current form this convention will not be obvious
>> for driver authors. Though I don't have a good idea how to do it.
>> Maybe merge both aggregation and retry cfg80211 callbacks into one
>> and use structure for params and bitmask for operations...
>
> I think we want that anyway, I just suggested to also add the "noack"
> to
> the same API, and indeed it's pointless to set retries and noack.
>
Sure, I'll change it to a single api for all the tid_config operations.
WARNING: multiple messages have this Message-ID (diff)
From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>,
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/4] New netlink command for TID specific configuration
Date: Tue, 13 Nov 2018 12:16:22 +0530 [thread overview]
Message-ID: <f024b86729f2361aeb0e8939db8d3a04@codeaurora.org> (raw)
In-Reply-To: <dda0f03868f631ba9f76170e19dd28099a0e0add.camel@sipsolutions.net>
On 2018-11-09 17:54, Johannes Berg wrote:
> On Fri, 2018-11-09 at 09:40 +0000, Sergey Matyukevich wrote:
>>
>> Ok. So if driver receives retry value (-1), it should reset to some
>> default value known to driver or firmware. IMHO it worth making it
>> more explicit: in its current form this convention will not be obvious
>> for driver authors. Though I don't have a good idea how to do it.
>> Maybe merge both aggregation and retry cfg80211 callbacks into one
>> and use structure for params and bitmask for operations...
>
> I think we want that anyway, I just suggested to also add the "noack"
> to
> the same API, and indeed it's pointless to set retries and noack.
>
Sure, I'll change it to a single api for all the tid_config operations.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-11-13 6:46 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 17:55 [PATCH 0/4] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2018-10-22 17:55 ` Tamizh chelvam
2018-10-22 17:55 ` [PATCH 1/4] New netlink command " Tamizh chelvam
2018-10-22 17:55 ` Tamizh chelvam
2018-11-06 10:16 ` Sergey Matyukevich
2018-11-06 10:16 ` Sergey Matyukevich
2018-11-08 17:29 ` Tamizh chelvam
2018-11-08 17:29 ` Tamizh chelvam
2018-11-09 9:47 ` Sergey Matyukevich
2018-11-09 9:47 ` Sergey Matyukevich
2018-11-06 11:31 ` Johannes Berg
2018-11-06 11:31 ` Johannes Berg
2018-11-07 14:05 ` Sergey Matyukevich
2018-11-07 14:05 ` Sergey Matyukevich
2018-11-08 17:47 ` Tamizh chelvam
2018-11-08 17:47 ` Tamizh chelvam
2018-11-09 9:40 ` Sergey Matyukevich
2018-11-09 9:40 ` Sergey Matyukevich
2018-11-09 12:24 ` Johannes Berg
2018-11-09 12:24 ` Johannes Berg
2018-11-13 6:46 ` Tamizh chelvam [this message]
2018-11-13 6:46 ` Tamizh chelvam
2018-11-09 11:37 ` Johannes Berg
2018-11-09 11:37 ` Johannes Berg
2018-10-22 17:55 ` [PATCH 2/4] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2018-10-22 17:55 ` Tamizh chelvam
2018-11-06 10:21 ` Sergey Matyukevich
2018-11-06 10:21 ` Sergey Matyukevich
2018-11-08 12:28 ` Tamizh chelvam
2018-11-08 12:28 ` Tamizh chelvam
2018-10-22 17:55 ` [PATCH 3/4] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2018-10-22 17:55 ` Tamizh chelvam
2018-11-06 10:33 ` Sergey Matyukevich
2018-11-06 10:33 ` Sergey Matyukevich
2018-11-08 12:42 ` Tamizh chelvam
2018-11-08 12:42 ` Tamizh chelvam
2018-11-07 23:55 ` Igor Mitsyanko
2018-11-07 23:55 ` Igor Mitsyanko
2018-10-22 17:55 ` [PATCH 4/4] ath10k: Add support to configure " Tamizh chelvam
2018-10-22 17:55 ` Tamizh chelvam
2018-11-09 9:26 ` Sergey Matyukevich
2018-11-09 9:26 ` Sergey Matyukevich
2018-11-05 20:43 ` [PATCH 0/4] cfg80211/mac80211: Add support for " Johannes Berg
2018-11-05 20:43 ` Johannes Berg
2018-11-06 10:45 ` Sergey Matyukevich
2018-11-06 10:45 ` Sergey Matyukevich
2018-11-06 11:28 ` Johannes Berg
2018-11-06 11:28 ` Johannes Berg
2018-11-06 12:17 ` Sergey Matyukevich
2018-11-06 12:17 ` Sergey Matyukevich
2018-11-08 0:55 ` Igor Mitsyanko
2018-11-08 0:55 ` Igor Mitsyanko
2018-11-08 16:31 ` Ben Greear
2018-11-08 16:31 ` Ben Greear
2019-02-13 19:01 ` Sergey Matyukevich
2019-02-13 19:01 ` Sergey Matyukevich
[not found] ` <a7d97b692da245a8b85769d7766ceba7@aphydexm01f.ap.qualcomm.com>
2019-02-14 7:14 ` Tamizh chelvam
2019-02-14 7:14 ` Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f024b86729f2361aeb0e8939db8d3a04@codeaurora.org \
--to=tamizhr@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.