All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
	Akash Gajjar <gajjar04akash@gmail.com>
Cc: Jagan Teki <jagan@edgeble.ai>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 01/12] rockchip: Fix early use of bootph props
Date: Tue, 14 Mar 2023 11:15:03 +0800	[thread overview]
Message-ID: <100fdfb2-aad5-b039-aee8-50a5edbb8392@rock-chips.com> (raw)
In-Reply-To: <20230314003755.512696-2-jonas@kwiboo.se>

Hi Jonas,

On 2023/3/14 08:38, Jonas Karlman wrote:
> Running U-Boot on a ROCK 3 Model A result in the following:
>
>    No serial driver found
>    resetting ...
>    no sysreset
>    ### ERROR ### Please RESET the board ###
>
> Replace bootph- props with u-boot,dm- props to fix this.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

Sorry, my mistake, I though the patch series [0] has been apply to 
master, but it's in next for now.

We may need another fix after next merge to master next month.

I will apply this frist for this release.


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

[0] 
https://patchwork.ozlabs.org/project/uboot/cover/20230213155641.1208774-1-sjg@chromium.org/


> ---
>   arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi        |  2 +-
>   arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi     |  2 +-
>   arch/arm/dts/rk3568-rock-3a-u-boot.dtsi          |  2 +-
>   arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi |  2 +-
>   arch/arm/dts/rk3588s-u-boot.dtsi                 | 14 +++++++-------
>   5 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi b/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi
> index a27a3adc082b..27735c49ddc0 100644
> --- a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi
> @@ -11,7 +11,7 @@
>   };
>   
>   &uart0 {
> -	bootph-all;
> +	u-boot,dm-pre-reloc;
>   	clock-frequency = <24000000>;
>   	status = "okay";
>   };
> diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> index 4e791738335f..589332503e72 100644
> --- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> +++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> @@ -13,6 +13,6 @@
>   
>   &uart2 {
>   	clock-frequency = <24000000>;
> -	bootph-all;
> +	u-boot,dm-pre-reloc;
>   	status = "okay";
>   };
> diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> index ed47efa44bf9..b5ca23a82a20 100644
> --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> @@ -19,6 +19,6 @@
>   
>   &uart2 {
>   	clock-frequency = <24000000>;
> -	bootph-all;
> +	u-boot,dm-pre-reloc;
>   	status = "okay";
>   };
> diff --git a/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi b/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
> index 3235bd36e4c8..612966492b02 100644
> --- a/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
> @@ -18,7 +18,7 @@
>   
>   &sdmmc {
>   	bus-width = <4>;
> -	bootph-all;
> +	u-boot,dm-pre-reloc;
>   	u-boot,spl-fifo-mode;
>   	status = "okay";
>   };
> diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi
> index 1e225d71efc2..f880f4a16741 100644
> --- a/arch/arm/dts/rk3588s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588s-u-boot.dtsi
> @@ -8,12 +8,12 @@
>   / {
>   	dmc {
>   		compatible = "rockchip,rk3588-dmc";
> -		bootph-all;
> +		u-boot,dm-pre-reloc;
>   		status = "okay";
>   	};
>   
>   	pmu1_grf: syscon@fd58a000 {
> -		bootph-all;
> +		u-boot,dm-pre-reloc;
>   		compatible = "rockchip,rk3588-pmu1-grf", "syscon";
>   		reg = <0x0 0xfd58a000 0x0 0x2000>;
>   	};
> @@ -46,26 +46,26 @@
>   };
>   
>   &xin24m {
> -	bootph-all;
> +	u-boot,dm-pre-reloc;
>   	status = "okay";
>   };
>   
>   &cru {
> -	bootph-pre-ram;
> +	u-boot,dm-spl;
>   	status = "okay";
>   };
>   
>   &sys_grf {
> -	bootph-pre-ram;
> +	u-boot,dm-spl;
>   	status = "okay";
>   };
>   
>   &uart2 {
>   	clock-frequency = <24000000>;
> -	bootph-pre-ram;
> +	u-boot,dm-spl;
>   	status = "okay";
>   };
>   
>   &ioc {
> -	bootph-pre-ram;
> +	u-boot,dm-spl;
>   };

  reply	other threads:[~2023-03-14  3:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  0:38 [PATCH 00/12] rockchip: Fixes for RK3568 and RK3588 and cleanup Jonas Karlman
2023-03-14  0:38 ` [PATCH 01/12] rockchip: Fix early use of bootph props Jonas Karlman
2023-03-14  3:15   ` Kever Yang [this message]
2023-03-14  0:38 ` [PATCH 02/12] rockchip: rk3568: Fix boot device detection Jonas Karlman
2023-03-14  3:16   ` Kever Yang
2023-03-14  0:38 ` [PATCH 03/12] rockchip: rk3568-rock-3a: Sync device tree from linux Jonas Karlman
2023-03-14  3:17   ` Kever Yang
2023-03-14  0:38 ` [PATCH 04/12] clk: rockchip: rk3568: Fix reset handler Jonas Karlman
2023-03-14  0:38 ` [PATCH 05/12] clk: rockchip: rk3588: Fix clk_aux16m in clock driver Jonas Karlman
2023-03-14  3:21   ` Kever Yang
2023-03-14  0:38 ` [PATCH 06/12] rockchip: rk3588-rock-5b: Fix sdmmc boot Jonas Karlman
2023-03-14  3:22   ` Kever Yang
2023-03-14  0:38 ` [PATCH 07/12] rockchip: rk3588: Add boot device detection Jonas Karlman
2023-03-14  3:22   ` Kever Yang
2023-03-14  0:38 ` [PATCH 08/12] rockchip: tinker-rk3288: Use common BOOT_TARGET_DEVICES Jonas Karlman
2023-03-14  3:28   ` Kever Yang
2023-03-14  0:38 ` [PATCH 09/12] mmc: rockchip_dw_mmc: Fix get_mmc_clk return value Jonas Karlman
2023-03-14  3:25   ` Kever Yang
2023-03-14  0:38 ` [PATCH 10/12] rockchip: include: configs: Remove dangling comments Jonas Karlman
2023-03-14  3:28   ` Kever Yang
2023-03-14  0:38 ` [PATCH 11/12] rockchip: include: configs: Remove unused SDRAM_BANK_SIZE Jonas Karlman
2023-03-14  3:29   ` Kever Yang
2023-03-14  0:38 ` [PATCH 12/12] rockchip: Convert rk35xx to use standard boot Jonas Karlman
2023-03-15 19:43   ` Simon Glass
2023-03-19  6:16   ` Kever Yang
2023-03-19  9:13     ` Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=100fdfb2-aad5-b039-aee8-50a5edbb8392@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=eugen.hristev@collabora.com \
    --cc=gajjar04akash@gmail.com \
    --cc=jagan@edgeble.ai \
    --cc=jonas@kwiboo.se \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.