From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Chris Morgan <macromorgan@hotmail.com>,
Peter Geis <pgwipeout@gmail.com>
Cc: Jagan Teki <jagan@edgeble.ai>,
Eugen Hristev <eugen.hristev@collabora.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 02/12] rockchip: rk3568: Fix boot device detection
Date: Tue, 14 Mar 2023 11:16:45 +0800 [thread overview]
Message-ID: <f2c3c0a6-96f2-ee3b-2e88-aebca2828865@rock-chips.com> (raw)
In-Reply-To: <20230314003755.512696-3-jonas@kwiboo.se>
On 2023/3/14 08:38, Jonas Karlman wrote:
> The boot source node path for emmc is using the old sdhci name.
> Replace with correct mmc name and also add same-as-spl to boot order.
>
> Fixes: 0d61f8e5f1c0 ("rockchip: rk3568: add boot device detection")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/dts/rk356x-u-boot.dtsi | 2 +-
> arch/arm/mach-rockchip/rk3568/rk3568.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi
> index 23316410496d..04a7b0a0f668 100644
> --- a/arch/arm/dts/rk356x-u-boot.dtsi
> +++ b/arch/arm/dts/rk356x-u-boot.dtsi
> @@ -12,7 +12,7 @@
> };
>
> chosen {
> - u-boot,spl-boot-order = &sdhci, &sdmmc0;
> + u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc0;
> };
>
> dmc: dmc {
> diff --git a/arch/arm/mach-rockchip/rk3568/rk3568.c b/arch/arm/mach-rockchip/rk3568/rk3568.c
> index 4a08820a0937..69ef19cc85af 100644
> --- a/arch/arm/mach-rockchip/rk3568/rk3568.c
> +++ b/arch/arm/mach-rockchip/rk3568/rk3568.c
> @@ -82,7 +82,7 @@ static struct mm_region rk3568_mem_map[] = {
> };
>
> const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = {
> - [BROM_BOOTSOURCE_EMMC] = "/sdhci@fe310000",
> + [BROM_BOOTSOURCE_EMMC] = "/mmc@fe310000",
> [BROM_BOOTSOURCE_SPINOR] = "/spi@fe300000/flash@0",
> [BROM_BOOTSOURCE_SD] = "/mmc@fe2b0000",
> };
next prev parent reply other threads:[~2023-03-14 3:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:38 [PATCH 00/12] rockchip: Fixes for RK3568 and RK3588 and cleanup Jonas Karlman
2023-03-14 0:38 ` [PATCH 01/12] rockchip: Fix early use of bootph props Jonas Karlman
2023-03-14 3:15 ` Kever Yang
2023-03-14 0:38 ` [PATCH 02/12] rockchip: rk3568: Fix boot device detection Jonas Karlman
2023-03-14 3:16 ` Kever Yang [this message]
2023-03-14 0:38 ` [PATCH 03/12] rockchip: rk3568-rock-3a: Sync device tree from linux Jonas Karlman
2023-03-14 3:17 ` Kever Yang
2023-03-14 0:38 ` [PATCH 04/12] clk: rockchip: rk3568: Fix reset handler Jonas Karlman
2023-03-14 0:38 ` [PATCH 05/12] clk: rockchip: rk3588: Fix clk_aux16m in clock driver Jonas Karlman
2023-03-14 3:21 ` Kever Yang
2023-03-14 0:38 ` [PATCH 06/12] rockchip: rk3588-rock-5b: Fix sdmmc boot Jonas Karlman
2023-03-14 3:22 ` Kever Yang
2023-03-14 0:38 ` [PATCH 07/12] rockchip: rk3588: Add boot device detection Jonas Karlman
2023-03-14 3:22 ` Kever Yang
2023-03-14 0:38 ` [PATCH 08/12] rockchip: tinker-rk3288: Use common BOOT_TARGET_DEVICES Jonas Karlman
2023-03-14 3:28 ` Kever Yang
2023-03-14 0:38 ` [PATCH 09/12] mmc: rockchip_dw_mmc: Fix get_mmc_clk return value Jonas Karlman
2023-03-14 3:25 ` Kever Yang
2023-03-14 0:38 ` [PATCH 10/12] rockchip: include: configs: Remove dangling comments Jonas Karlman
2023-03-14 3:28 ` Kever Yang
2023-03-14 0:38 ` [PATCH 11/12] rockchip: include: configs: Remove unused SDRAM_BANK_SIZE Jonas Karlman
2023-03-14 3:29 ` Kever Yang
2023-03-14 0:38 ` [PATCH 12/12] rockchip: Convert rk35xx to use standard boot Jonas Karlman
2023-03-15 19:43 ` Simon Glass
2023-03-19 6:16 ` Kever Yang
2023-03-19 9:13 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2c3c0a6-96f2-ee3b-2e88-aebca2828865@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=eugen.hristev@collabora.com \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=macromorgan@hotmail.com \
--cc=pgwipeout@gmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.