All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Klaus Goger <klaus.goger@theobroma-systems.com>,
	Levin Du <djw@t-chip.com.cn>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Akash Gajjar <akash@openedev.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Cc: Jagan Teki <jagan@edgeble.ai>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 11/12] rockchip: include: configs: Remove unused SDRAM_BANK_SIZE
Date: Tue, 14 Mar 2023 11:29:35 +0800	[thread overview]
Message-ID: <461231ab-7b69-a211-4a71-e1284ed7a8b3@rock-chips.com> (raw)
In-Reply-To: <20230314003755.512696-12-jonas@kwiboo.se>


On 2023/3/14 08:38, Jonas Karlman wrote:
> Remove unused SDRAM_BANK_SIZE define.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   include/configs/evb_rk3328.h           | 2 --
>   include/configs/evb_rk3399.h           | 2 --
>   include/configs/pinebook-pro-rk3399.h  | 2 --
>   include/configs/pinephone-pro-rk3399.h | 2 --
>   include/configs/puma_rk3399.h          | 2 --
>   include/configs/px30_common.h          | 1 -
>   include/configs/rk3188_common.h        | 1 -
>   include/configs/rk322x_common.h        | 1 -
>   include/configs/rk3288_common.h        | 1 -
>   include/configs/rk3308_common.h        | 1 -
>   include/configs/roc-pc-rk3399.h        | 2 --
>   include/configs/rock960_rk3399.h       | 1 -
>   include/configs/rockpro64_rk3399.h     | 1 -
>   13 files changed, 19 deletions(-)
>
> diff --git a/include/configs/evb_rk3328.h b/include/configs/evb_rk3328.h
> index cac613d021a8..d10e5b1d2e03 100644
> --- a/include/configs/evb_rk3328.h
> +++ b/include/configs/evb_rk3328.h
> @@ -8,6 +8,4 @@
>   
>   #include <configs/rk3328_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
> -
>   #endif
> diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h
> index b7e850370b31..70ab587795e2 100644
> --- a/include/configs/evb_rk3399.h
> +++ b/include/configs/evb_rk3399.h
> @@ -13,6 +13,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
> -
>   #endif
> diff --git a/include/configs/pinebook-pro-rk3399.h b/include/configs/pinebook-pro-rk3399.h
> index 241dc39be008..141ffcd036bb 100644
> --- a/include/configs/pinebook-pro-rk3399.h
> +++ b/include/configs/pinebook-pro-rk3399.h
> @@ -14,6 +14,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
> -
>   #endif
> diff --git a/include/configs/pinephone-pro-rk3399.h b/include/configs/pinephone-pro-rk3399.h
> index 78017d6bcc37..9cd444734392 100644
> --- a/include/configs/pinephone-pro-rk3399.h
> +++ b/include/configs/pinephone-pro-rk3399.h
> @@ -14,6 +14,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
> -
>   #endif
> diff --git a/include/configs/puma_rk3399.h b/include/configs/puma_rk3399.h
> index 23de326e7208..969acc89b937 100644
> --- a/include/configs/puma_rk3399.h
> +++ b/include/configs/puma_rk3399.h
> @@ -8,6 +8,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
> -
>   #endif
> diff --git a/include/configs/px30_common.h b/include/configs/px30_common.h
> index c0896e5f6281..8df481b09788 100644
> --- a/include/configs/px30_common.h
> +++ b/include/configs/px30_common.h
> @@ -15,7 +15,6 @@
>   
>   #define CFG_SYS_SDRAM_BASE		0
>   #define SDRAM_MAX_SIZE			0xff000000
> -#define SDRAM_BANK_SIZE			(2UL << 30)
>   
>   #define ENV_MEM_LAYOUT_SETTINGS \
>   	"scriptaddr=0x00500000\0" \
> diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h
> index ebb421c69297..fcb274565e9e 100644
> --- a/include/configs/rk3188_common.h
> +++ b/include/configs/rk3188_common.h
> @@ -12,7 +12,6 @@
>   #define CFG_IRAM_BASE	0x10080000
>   
>   #define CFG_SYS_SDRAM_BASE		0x60000000
> -#define SDRAM_BANK_SIZE			(2UL << 30)
>   #define SDRAM_MAX_SIZE			0x80000000
>   
>   #define ENV_MEM_LAYOUT_SETTINGS \
> diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h
> index fcaf9c52c4be..39a40f4e2d10 100644
> --- a/include/configs/rk322x_common.h
> +++ b/include/configs/rk322x_common.h
> @@ -13,7 +13,6 @@
>   #define CFG_IRAM_BASE		0x10080000
>   
>   #define CFG_SYS_SDRAM_BASE		0x60000000
> -#define SDRAM_BANK_SIZE			(512UL << 20UL)
>   #define SDRAM_MAX_SIZE			0x80000000
>   
>   #define ENV_MEM_LAYOUT_SETTINGS \
> diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
> index fa409c70c931..71d2426d72a4 100644
> --- a/include/configs/rk3288_common.h
> +++ b/include/configs/rk3288_common.h
> @@ -14,7 +14,6 @@
>   #define CFG_IRAM_BASE		0xff700000
>   
>   #define CFG_SYS_SDRAM_BASE		0
> -#define SDRAM_BANK_SIZE			(2UL << 30)
>   #define SDRAM_MAX_SIZE			0xfe000000
>   
>   #define ENV_MEM_LAYOUT_SETTINGS \
> diff --git a/include/configs/rk3308_common.h b/include/configs/rk3308_common.h
> index 55a0dfecb21b..ba9ee112e2df 100644
> --- a/include/configs/rk3308_common.h
> +++ b/include/configs/rk3308_common.h
> @@ -12,7 +12,6 @@
>   
>   #define CFG_SYS_SDRAM_BASE		0
>   #define SDRAM_MAX_SIZE			0xff000000
> -#define SDRAM_BANK_SIZE			(2UL << 30)
>   
>   #define ENV_MEM_LAYOUT_SETTINGS \
>   	"scriptaddr=0x00500000\0" \
> diff --git a/include/configs/roc-pc-rk3399.h b/include/configs/roc-pc-rk3399.h
> index 59fe22289cff..f99871cb9fc5 100644
> --- a/include/configs/roc-pc-rk3399.h
> +++ b/include/configs/roc-pc-rk3399.h
> @@ -13,6 +13,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
> -
>   #endif
> diff --git a/include/configs/rock960_rk3399.h b/include/configs/rock960_rk3399.h
> index 6099d2fa55a6..b85978115f5b 100644
> --- a/include/configs/rock960_rk3399.h
> +++ b/include/configs/rock960_rk3399.h
> @@ -13,5 +13,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
>   #endif
> diff --git a/include/configs/rockpro64_rk3399.h b/include/configs/rockpro64_rk3399.h
> index 9195b9b99e41..5381efac3f63 100644
> --- a/include/configs/rockpro64_rk3399.h
> +++ b/include/configs/rockpro64_rk3399.h
> @@ -13,5 +13,4 @@
>   
>   #include <configs/rk3399_common.h>
>   
> -#define SDRAM_BANK_SIZE			(2UL << 30)
>   #endif

  reply	other threads:[~2023-03-14  3:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  0:38 [PATCH 00/12] rockchip: Fixes for RK3568 and RK3588 and cleanup Jonas Karlman
2023-03-14  0:38 ` [PATCH 01/12] rockchip: Fix early use of bootph props Jonas Karlman
2023-03-14  3:15   ` Kever Yang
2023-03-14  0:38 ` [PATCH 02/12] rockchip: rk3568: Fix boot device detection Jonas Karlman
2023-03-14  3:16   ` Kever Yang
2023-03-14  0:38 ` [PATCH 03/12] rockchip: rk3568-rock-3a: Sync device tree from linux Jonas Karlman
2023-03-14  3:17   ` Kever Yang
2023-03-14  0:38 ` [PATCH 04/12] clk: rockchip: rk3568: Fix reset handler Jonas Karlman
2023-03-14  0:38 ` [PATCH 05/12] clk: rockchip: rk3588: Fix clk_aux16m in clock driver Jonas Karlman
2023-03-14  3:21   ` Kever Yang
2023-03-14  0:38 ` [PATCH 06/12] rockchip: rk3588-rock-5b: Fix sdmmc boot Jonas Karlman
2023-03-14  3:22   ` Kever Yang
2023-03-14  0:38 ` [PATCH 07/12] rockchip: rk3588: Add boot device detection Jonas Karlman
2023-03-14  3:22   ` Kever Yang
2023-03-14  0:38 ` [PATCH 08/12] rockchip: tinker-rk3288: Use common BOOT_TARGET_DEVICES Jonas Karlman
2023-03-14  3:28   ` Kever Yang
2023-03-14  0:38 ` [PATCH 09/12] mmc: rockchip_dw_mmc: Fix get_mmc_clk return value Jonas Karlman
2023-03-14  3:25   ` Kever Yang
2023-03-14  0:38 ` [PATCH 10/12] rockchip: include: configs: Remove dangling comments Jonas Karlman
2023-03-14  3:28   ` Kever Yang
2023-03-14  0:38 ` [PATCH 11/12] rockchip: include: configs: Remove unused SDRAM_BANK_SIZE Jonas Karlman
2023-03-14  3:29   ` Kever Yang [this message]
2023-03-14  0:38 ` [PATCH 12/12] rockchip: Convert rk35xx to use standard boot Jonas Karlman
2023-03-15 19:43   ` Simon Glass
2023-03-19  6:16   ` Kever Yang
2023-03-19  9:13     ` Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=461231ab-7b69-a211-4a71-e1284ed7a8b3@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=akash@openedev.com \
    --cc=djw@t-chip.com.cn \
    --cc=eugen.hristev@collabora.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jagan@edgeble.ai \
    --cc=jonas@kwiboo.se \
    --cc=klaus.goger@theobroma-systems.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=philipp.tomsich@vrull.eu \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=sjg@chromium.org \
    --cc=sunil@amarulasolutions.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.