From: Dave Hansen <haveblue@us.ibm.com> To: Roman Zippel <zippel@linux-m68k.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, geert@linux-m68k.org, ralf@linux-mips.org, linux-mm <linux-mm@kvack.org> Subject: Re: [patch] [RFC] make WANT_PAGE_VIRTUAL a config option Date: Thu, 16 Dec 2004 16:42:51 -0800 [thread overview] Message-ID: <1103244171.13614.2525.camel@localhost> (raw) In-Reply-To: <Pine.LNX.4.61.0412170133560.793@scrub.home> On Thu, 2004-12-16 at 16:36, Roman Zippel wrote: > On Thu, 16 Dec 2004, Dave Hansen wrote: > > I'm working on breaking out the struct page definition into its > > own file. There seem to be a ton of header dependencies that > > crop up around struct page, and I'd like to start getting rid > > of thise. > > Why do you want to move struct page into a separate file? Circular header dependencies suck :) I posted another patch, shortly after the one that I cc'd you on, with the following description. Cristoph suggested just making it linux/page.h and maybe combining it with page-flags.h, but otherwise the idea remains the same. > There are currently 24 places in the tree where struct page is > predeclared. However, a good number of these places also have to > do some kind of arithmetic on it, and end up using macros because > static inlines wouldn't have the type fully defined at > compile-time. > > But, in reality, struct page has very few dependencies on outside > macros or functions, and doesn't really need to be a part of the > header include mess which surrounds many of the VM headers. > > So, put 'struct page' into structpage.h, along with a nasty comment > telling everyone to keep their grubby mitts out of the file. > > Now, we can use static inlines for almost any 'struct page' > operations with no problems, and get rid of many of the > predeclarations. -- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com> To: Roman Zippel <zippel@linux-m68k.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, geert@linux-m68k.org, ralf@linux-mips.org, linux-mm <linux-mm@kvack.org> Subject: Re: [patch] [RFC] make WANT_PAGE_VIRTUAL a config option Date: Thu, 16 Dec 2004 16:42:51 -0800 [thread overview] Message-ID: <1103244171.13614.2525.camel@localhost> (raw) In-Reply-To: <Pine.LNX.4.61.0412170133560.793@scrub.home> On Thu, 2004-12-16 at 16:36, Roman Zippel wrote: > On Thu, 16 Dec 2004, Dave Hansen wrote: > > I'm working on breaking out the struct page definition into its > > own file. There seem to be a ton of header dependencies that > > crop up around struct page, and I'd like to start getting rid > > of thise. > > Why do you want to move struct page into a separate file? Circular header dependencies suck :) I posted another patch, shortly after the one that I cc'd you on, with the following description. Cristoph suggested just making it linux/page.h and maybe combining it with page-flags.h, but otherwise the idea remains the same. > There are currently 24 places in the tree where struct page is > predeclared. However, a good number of these places also have to > do some kind of arithmetic on it, and end up using macros because > static inlines wouldn't have the type fully defined at > compile-time. > > But, in reality, struct page has very few dependencies on outside > macros or functions, and doesn't really need to be a part of the > header include mess which surrounds many of the VM headers. > > So, put 'struct page' into structpage.h, along with a nasty comment > telling everyone to keep their grubby mitts out of the file. > > Now, we can use static inlines for almost any 'struct page' > operations with no problems, and get rid of many of the > predeclarations. -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-12-17 0:44 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-12-16 21:56 [patch] [RFC] make WANT_PAGE_VIRTUAL a config option Dave Hansen 2004-12-16 21:56 ` Dave Hansen 2004-12-17 0:36 ` Roman Zippel 2004-12-17 0:36 ` Roman Zippel 2004-12-17 0:42 ` Dave Hansen [this message] 2004-12-17 0:42 ` Dave Hansen 2004-12-17 0:51 ` Roman Zippel 2004-12-17 0:51 ` Roman Zippel 2004-12-17 1:14 ` Dave Hansen 2004-12-17 1:14 ` Dave Hansen 2004-12-17 2:50 ` Roman Zippel 2004-12-17 2:50 ` Roman Zippel 2004-12-17 4:24 ` Dave Hansen 2004-12-17 4:24 ` Dave Hansen 2004-12-17 13:26 ` Roman Zippel 2004-12-17 13:26 ` Roman Zippel 2004-12-17 15:59 ` Dave Hansen 2004-12-17 15:59 ` Dave Hansen 2004-12-17 20:27 ` Roman Zippel 2004-12-17 20:27 ` Roman Zippel 2004-12-17 21:48 ` Dave Hansen 2004-12-17 21:48 ` Dave Hansen 2004-12-18 0:52 ` Roman Zippel 2004-12-18 0:52 ` Roman Zippel 2004-12-20 14:49 ` Dave Hansen 2004-12-20 14:49 ` Dave Hansen 2004-12-20 20:45 ` Roman Zippel 2004-12-20 20:45 ` Roman Zippel 2004-12-17 2:01 ` Dave Hansen 2004-12-17 2:01 ` Dave Hansen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1103244171.13614.2525.camel@localhost \ --to=haveblue@us.ibm.com \ --cc=geert@linux-m68k.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=ralf@linux-mips.org \ --cc=zippel@linux-m68k.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.