From: Roman Zippel <zippel@linux-m68k.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
geert@linux-m68k.org, ralf@linux-mips.org,
linux-mm <linux-mm@kvack.org>
Subject: Re: [patch] [RFC] make WANT_PAGE_VIRTUAL a config option
Date: Fri, 17 Dec 2004 14:26:11 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0412171132560.793@scrub.home> (raw)
In-Reply-To: <1103257482.13614.2817.camel@localhost>
Hi,
On Thu, 16 Dec 2004, Dave Hansen wrote:
> Sorry I didn't provide this. My recent effort started to clean up some
> ugliness in some current patches that worked around this actually
> happening a few months ago. The original example didn't survive :)
There are two points, which did originally catch my attention.
1) Where/why do you want to remove the dependency on asm/page.h?
2) Does every structure really needs its own header?
If you want to do such a cleanup, it would be helpful to have some more
information about where you want to go, otherwise you may create a more
twisted maze of header files. The big question here is what further
cleanups are possible in this area?
What basically needs to be done is to separate the definitions from its
users, that doesn't mean every definition needs its own header file. Why
not create a single header file which collects a number of mm related
definitions? E.g. struct vm_area_struct is also used by a number of header
files, although its main users have already been separated into
asm/tlbflush.h and so created even more headers.
So to allow further header cleanup, we should look what other definitions
can be pulled out of mm.h and related headers. mm.h should probably stay a
high level header, but I'd also like to see a cleanup of asm/page.h. The
page table definitions in there should be available to every mm related
header.
I had to look closer at this, but I did this for struct task_struct and
making it available for lowlevel header files. I rediffed the patches and
put them at http://www.xs4all.nl/~zippel/task_patches/
bye, Roman
WARNING: multiple messages have this Message-ID (diff)
From: Roman Zippel <zippel@linux-m68k.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
geert@linux-m68k.org, ralf@linux-mips.org,
linux-mm <linux-mm@kvack.org>
Subject: Re: [patch] [RFC] make WANT_PAGE_VIRTUAL a config option
Date: Fri, 17 Dec 2004 14:26:11 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0412171132560.793@scrub.home> (raw)
In-Reply-To: <1103257482.13614.2817.camel@localhost>
Hi,
On Thu, 16 Dec 2004, Dave Hansen wrote:
> Sorry I didn't provide this. My recent effort started to clean up some
> ugliness in some current patches that worked around this actually
> happening a few months ago. The original example didn't survive :)
There are two points, which did originally catch my attention.
1) Where/why do you want to remove the dependency on asm/page.h?
2) Does every structure really needs its own header?
If you want to do such a cleanup, it would be helpful to have some more
information about where you want to go, otherwise you may create a more
twisted maze of header files. The big question here is what further
cleanups are possible in this area?
What basically needs to be done is to separate the definitions from its
users, that doesn't mean every definition needs its own header file. Why
not create a single header file which collects a number of mm related
definitions? E.g. struct vm_area_struct is also used by a number of header
files, although its main users have already been separated into
asm/tlbflush.h and so created even more headers.
So to allow further header cleanup, we should look what other definitions
can be pulled out of mm.h and related headers. mm.h should probably stay a
high level header, but I'd also like to see a cleanup of asm/page.h. The
page table definitions in there should be available to every mm related
header.
I had to look closer at this, but I did this for struct task_struct and
making it available for lowlevel header files. I rediffed the patches and
put them at http://www.xs4all.nl/~zippel/task_patches/
bye, Roman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-12-17 13:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 21:56 [patch] [RFC] make WANT_PAGE_VIRTUAL a config option Dave Hansen
2004-12-16 21:56 ` Dave Hansen
2004-12-17 0:36 ` Roman Zippel
2004-12-17 0:36 ` Roman Zippel
2004-12-17 0:42 ` Dave Hansen
2004-12-17 0:42 ` Dave Hansen
2004-12-17 0:51 ` Roman Zippel
2004-12-17 0:51 ` Roman Zippel
2004-12-17 1:14 ` Dave Hansen
2004-12-17 1:14 ` Dave Hansen
2004-12-17 2:50 ` Roman Zippel
2004-12-17 2:50 ` Roman Zippel
2004-12-17 4:24 ` Dave Hansen
2004-12-17 4:24 ` Dave Hansen
2004-12-17 13:26 ` Roman Zippel [this message]
2004-12-17 13:26 ` Roman Zippel
2004-12-17 15:59 ` Dave Hansen
2004-12-17 15:59 ` Dave Hansen
2004-12-17 20:27 ` Roman Zippel
2004-12-17 20:27 ` Roman Zippel
2004-12-17 21:48 ` Dave Hansen
2004-12-17 21:48 ` Dave Hansen
2004-12-18 0:52 ` Roman Zippel
2004-12-18 0:52 ` Roman Zippel
2004-12-20 14:49 ` Dave Hansen
2004-12-20 14:49 ` Dave Hansen
2004-12-20 20:45 ` Roman Zippel
2004-12-20 20:45 ` Roman Zippel
2004-12-17 2:01 ` Dave Hansen
2004-12-17 2:01 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0412171132560.793@scrub.home \
--to=zippel@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.