All of lore.kernel.org
 help / color / mirror / Atom feed
From: christophe varoqui <christophe.varoqui@free.fr>
To: device-mapper development <dm-devel@redhat.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"linux-hotplug-devel@lists.sourceforge.net"
	<linux-hotplug-devel@lists.sourceforge.net>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [dm-devel] [ANNOUNCE] multipath-tools-0.4.1
Date: Wed, 22 Dec 2004 02:09:40 +0100	[thread overview]
Message-ID: <1103677780.6030.4.camel@zezette> (raw)
In-Reply-To: <EA4DC661A6353747A2E5C0DE8792DDDE074BF47E@orsmsx404.amr.corp.intel.com>

Le mardi 21 d?embre 2004 à 14:02 -0800, Caushik, Ramesh a écrit :
> The devinfo.c file in the multipath-tools-0.4.1 appears to have a typo
> in the code to get the node_name attr in the fc_transport sysfs entry.
> Path below should fix it. BTW why does a failure to get a node_name
> attribute, result in failure of multipath discovery (because devinfo
> returns failure)even if the "group_by_node_name" policy is not used ?
> Can't we just NULL out the tgt_node_name string in the sysfs_devinfo
> routine and fail the group_by_node_name routine if that policy was
> chosen ? That is what happened in my case. Multipath discovery failed
> due to above reason even though node_name grouping was not specified. 
> 
You are absolutely right.

I was aware that introducing that FC-ism would break for iSCSI and other
transports. I just thought I'll get that right in a next release because
I wasn't aware someone was using the thing in such an "exotic"
environment.

I would gladly get a description of your topology, by the way.
It would help to get it right in the future.

Anyway, I'll fix that for 0.4.2

regards,
-- 
christophe varoqui <christophe.varoqui@free.fr>


-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: christophe varoqui <christophe.varoqui@free.fr>
To: device-mapper development <dm-devel@redhat.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"linux-hotplug-devel@lists.sourceforge.net"
	<linux-hotplug-devel@lists.sourceforge.net>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [dm-devel] [ANNOUNCE] multipath-tools-0.4.1
Date: Tue, 21 Dec 2004 23:03:56 +0000	[thread overview]
Message-ID: <1103677780.6030.4.camel@zezette> (raw)
In-Reply-To: <EA4DC661A6353747A2E5C0DE8792DDDE074BF47E@orsmsx404.amr.corp.intel.com>

Le mardi 21 d?embre 2004 à 14:02 -0800, Caushik, Ramesh a écrit :
> The devinfo.c file in the multipath-tools-0.4.1 appears to have a typo
> in the code to get the node_name attr in the fc_transport sysfs entry.
> Path below should fix it. BTW why does a failure to get a node_name
> attribute, result in failure of multipath discovery (because devinfo
> returns failure)even if the "group_by_node_name" policy is not used ?
> Can't we just NULL out the tgt_node_name string in the sysfs_devinfo
> routine and fail the group_by_node_name routine if that policy was
> chosen ? That is what happened in my case. Multipath discovery failed
> due to above reason even though node_name grouping was not specified. 
> 
You are absolutely right.

I was aware that introducing that FC-ism would break for iSCSI and other
transports. I just thought I'll get that right in a next release because
I wasn't aware someone was using the thing in such an "exotic"
environment.

I would gladly get a description of your topology, by the way.
It would help to get it right in the future.

Anyway, I'll fix that for 0.4.2

regards,
-- 
christophe varoqui <christophe.varoqui@free.fr>




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  reply	other threads:[~2004-12-22  1:09 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-21 22:02 [dm-devel] [ANNOUNCE] multipath-tools-0.4.1 Caushik, Ramesh
2004-12-21 22:02 ` Caushik, Ramesh
2004-12-21 23:03 ` christophe varoqui [this message]
2004-12-22  1:09   ` christophe varoqui
2004-12-21 23:19   ` christophe varoqui
2004-12-22  1:26     ` christophe varoqui
  -- strict thread matches above, loose matches on Subject: below --
2004-12-23 19:08 Duane Grigsby
2004-12-23 19:17 ` Christoph Hellwig
2004-12-23 19:17   ` Christoph Hellwig
2004-12-23 12:19 James.Smart
2004-12-23 12:19 ` James.Smart
2004-12-22 21:54 Caushik, Ramesh
2004-12-22 21:54 ` Caushik, Ramesh
2004-12-23 13:28 ` Christoph Hellwig
2004-12-23 13:28   ` Christoph Hellwig
2004-12-22 21:05 James.Smart
2004-12-22 21:05 ` James.Smart
2004-12-22 21:23 ` christophe varoqui
2004-12-22 23:30   ` christophe varoqui
2004-12-22 19:26 Caushik, Ramesh
2004-12-22 19:26 ` Caushik, Ramesh
2004-12-22 19:45 ` christophe varoqui
2004-12-22 21:52   ` christophe varoqui
2004-09-25  0:24 [ANNOUNCE] multipath-tools-0.2.9 christophe varoqui
2004-09-25  0:24 ` christophe varoqui
2004-10-06  9:22 ` [ANNOUNCE] multipath-tools-0.3.0 christophe.varoqui
2004-10-06  9:22   ` christophe.varoqui
2004-10-06  9:50   ` [dm-devel] " Lars Marowsky-Bree
2004-10-06  9:50     ` Lars Marowsky-Bree
2004-10-06 10:18     ` christophe.varoqui
2004-10-06 10:18       ` christophe.varoqui
2004-10-11 12:00       ` Lars Marowsky-Bree
2004-10-11 12:00         ` Lars Marowsky-Bree
2004-10-11 12:31         ` christophe.varoqui
2004-10-11 12:31           ` christophe.varoqui
2004-10-07 20:01   ` Dave Olien
2004-10-07 20:01     ` Dave Olien
2004-10-08 12:49     ` christophe.varoqui
2004-10-08 12:49       ` christophe.varoqui
2004-10-11 11:50   ` [ANNOUNCE] multipath-tools-0.3.1 christophe.varoqui
2004-10-11 11:50     ` christophe.varoqui
2004-10-12 18:35     ` Dave Olien
2004-10-12 18:35       ` Dave Olien
2004-10-17 14:03     ` multipath-tools-0.3.2 christophe varoqui
2004-10-17 14:03       ` multipath-tools-0.3.2 christophe varoqui
2004-10-20 10:46       ` [ANNOUNCE] multipath-tools-0.3.3 christophe.varoqui
2004-10-20 10:46         ` christophe.varoqui
2004-10-24 22:14         ` [ANNOUNCE] multipath-tools-0.3.4 christophe varoqui
2004-10-24 22:14           ` christophe varoqui
2004-10-25  8:22           ` Arjan van de Ven
2004-10-25  8:22             ` Arjan van de Ven
2004-10-25  9:38             ` christophe.varoqui
2004-10-25  9:38               ` christophe.varoqui
2004-10-25 10:39               ` Douglas Gilbert
2004-10-25 10:39                 ` Douglas Gilbert
2004-10-25 21:03               ` [dm-devel] " Lars Marowsky-Bree
2004-10-25 21:03                 ` Lars Marowsky-Bree
2004-10-26 17:52                 ` Mike Christie
2004-10-26 17:52                   ` Mike Christie
2004-10-26 10:06           ` [ANNOUNCE] multipath-tools-0.3.5 christophe.varoqui
2004-10-26 10:06             ` christophe.varoqui
2004-11-01 17:08             ` [ANNOUNCE] multipath-tools-0.3.6 christophe varoqui
2004-11-01 17:08               ` christophe varoqui
2004-11-11 23:10               ` [ANNOUNCE] multipath-tools-0.3.7 christophe varoqui
2004-11-11 23:10                 ` christophe varoqui
2004-11-25 14:55                 ` [ANNOUNCE] multipath-tools-0.3.8 christophe varoqui
2004-11-25 14:55                   ` christophe varoqui
2004-12-05 15:43                   ` [ANNOUNCE] multipath-tools-0.3.9 christophe varoqui
2004-12-05 15:43                     ` christophe varoqui
2004-12-12 17:20                     ` [ANNOUNCE] multipath-tools-0.4.0 christophe varoqui
2004-12-12 17:20                       ` christophe varoqui
2004-12-12 18:08                       ` ISCSI Guy
2004-12-12 18:55                         ` ISCSI Ming Zhang
2004-12-12 21:07                           ` ISCSI Guy
2004-12-12 21:12                             ` ISCSI Ming Zhang
2004-12-20 16:01                     ` [ANNOUNCE] multipath-tools-0.4.1 christophe varoqui
2004-12-20 16:01                       ` christophe varoqui
2005-01-23 23:03                       ` [ANNOUNCE] multipath-tools-0.4.2 christophe varoqui
2005-01-23 23:03                         ` christophe varoqui
2005-03-19 14:27                     ` [ANNOUNCE] multipath-tools-0.4.3 christophe varoqui
2005-03-19 14:27                       ` christophe varoqui
2005-04-24 22:26                       ` [ANNOUNCE] multipath-tools-0.4.4 christophe varoqui
2005-04-24 22:26                         ` christophe varoqui
2005-04-25  9:28                         ` Lars Marowsky-Bree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1103677780.6030.4.camel@zezette \
    --to=christophe.varoqui@free.fr \
    --cc=dm-devel@redhat.com \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.