From: Mark McLoughlin <markmc@redhat.com> To: Anthony Liguori <anthony@codemonkey.ws> Cc: Scott Tsai <scottt.tw@gmail.com>, Dustin Kirkland <kirkland@canonical.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, Rusty Russell <rusty@rustcorp.com.au> Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 14:48:39 +0000 [thread overview] Message-ID: <1256827719.10825.75.camel@blaa> (raw) In-Reply-To: <4AE9A90F.1060108@codemonkey.ws> On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>>> tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) > >>>> being called and get an mtu of 1500 on virbr0 using his birdge.sh script. > >>>> > >>>> virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size' + 10 'virtio_net_hdr') > >>>> and the guest only had 1524 bytes of space in its input descriptors. > >>>> > >>>> > >>> Okay, that sounds like a bug in Dustin's version of the guest virtio-net > >>> driver - if it is only supplying 1524 byte buffers, it should not be > >>> saying it supports the VIRTIO_NET_F_GUEST_TSO4 feature > >>> > >>> > >> See: > >> > >> commit 8eca6b1bc770982595db2f7207c65051572436cb > >> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> > >> Date: Sun Apr 5 17:40:08 2009 +0000 > >> > >> Fix oops on 2.6.25 guest (Rusty Russell) > >> > >> I believe this is behind the following: > >> https://bugs.edge.launchpad.net/ubuntu/jaunty/+source/linux/+bug/331128 > >> > >> virtio_pci in 2.6.25 didn't do feature negotiation correctly: it > >> acked every > >> bit. Fortunately, we can detect this. > >> > >> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > >> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> > >> > >> It looks like Rusty's fix wasn't enough. If I change virtio-net to only > >> advertise F_MAC, we don't run into this problem. > >> > > > > If it's not acking VBAD_FEATURE, then it doesn't sound like the same > > issue > > > > It was acking VBAD_FEATURE when I tested it. > > But if you look at the patch, it whitelists the following features: > > features |= (1 << VIRTIO_NET_F_MAC); > features |= (1 << VIRTIO_NET_F_GUEST_CSUM); > features |= (1 << VIRTIO_NET_F_GUEST_TSO4); > features |= (1 << VIRTIO_NET_F_GUEST_TSO6); > features |= (1 << VIRTIO_NET_F_GUEST_ECN); Ah, it all makes sense now. I was getting confused between HOST_* and GUEST_* this should have been: features |= (1 << VIRTIO_NET_F_MAC); features |= (1 << VIRTIO_NET_F_HOST_CSUM); features |= (1 << VIRTIO_NET_F_HOST_TSO4); features |= (1 << VIRTIO_NET_F_HOST_TSO6); features |= (1 << VIRTIO_NET_F_HOST_ECN); Could you try that Dustin? > Which is why it's ack'ing TSO4. Removing TSO4 didn't seem to fix it > for me. Odd. Cheers, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark McLoughlin <markmc@redhat.com> To: Anthony Liguori <anthony@codemonkey.ws> Cc: Rusty Russell <rusty@rustcorp.com.au>, Scott Tsai <scottt.tw@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, Dustin Kirkland <kirkland@canonical.com> Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 14:48:39 +0000 [thread overview] Message-ID: <1256827719.10825.75.camel@blaa> (raw) In-Reply-To: <4AE9A90F.1060108@codemonkey.ws> On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>>> tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) > >>>> being called and get an mtu of 1500 on virbr0 using his birdge.sh script. > >>>> > >>>> virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size' + 10 'virtio_net_hdr') > >>>> and the guest only had 1524 bytes of space in its input descriptors. > >>>> > >>>> > >>> Okay, that sounds like a bug in Dustin's version of the guest virtio-net > >>> driver - if it is only supplying 1524 byte buffers, it should not be > >>> saying it supports the VIRTIO_NET_F_GUEST_TSO4 feature > >>> > >>> > >> See: > >> > >> commit 8eca6b1bc770982595db2f7207c65051572436cb > >> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> > >> Date: Sun Apr 5 17:40:08 2009 +0000 > >> > >> Fix oops on 2.6.25 guest (Rusty Russell) > >> > >> I believe this is behind the following: > >> https://bugs.edge.launchpad.net/ubuntu/jaunty/+source/linux/+bug/331128 > >> > >> virtio_pci in 2.6.25 didn't do feature negotiation correctly: it > >> acked every > >> bit. Fortunately, we can detect this. > >> > >> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > >> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> > >> > >> It looks like Rusty's fix wasn't enough. If I change virtio-net to only > >> advertise F_MAC, we don't run into this problem. > >> > > > > If it's not acking VBAD_FEATURE, then it doesn't sound like the same > > issue > > > > It was acking VBAD_FEATURE when I tested it. > > But if you look at the patch, it whitelists the following features: > > features |= (1 << VIRTIO_NET_F_MAC); > features |= (1 << VIRTIO_NET_F_GUEST_CSUM); > features |= (1 << VIRTIO_NET_F_GUEST_TSO4); > features |= (1 << VIRTIO_NET_F_GUEST_TSO6); > features |= (1 << VIRTIO_NET_F_GUEST_ECN); Ah, it all makes sense now. I was getting confused between HOST_* and GUEST_* this should have been: features |= (1 << VIRTIO_NET_F_MAC); features |= (1 << VIRTIO_NET_F_HOST_CSUM); features |= (1 << VIRTIO_NET_F_HOST_TSO4); features |= (1 << VIRTIO_NET_F_HOST_TSO6); features |= (1 << VIRTIO_NET_F_HOST_ECN); Could you try that Dustin? > Which is why it's ack'ing TSO4. Removing TSO4 didn't seem to fix it > for me. Odd. Cheers, Mark.
next prev parent reply other threads:[~2009-10-29 14:50 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-28 19:22 qemu-kvm-0.11 regression, crashes on older guests with virtio network Dustin Kirkland 2009-10-28 19:22 ` [Qemu-devel] " Dustin Kirkland 2009-10-28 19:29 ` Dustin Kirkland 2009-10-28 19:29 ` [Qemu-devel] " Dustin Kirkland 2009-10-29 3:12 ` [Qemu-devel] " Scott Tsai 2009-10-29 3:12 ` Scott Tsai 2009-10-29 9:16 ` Mark McLoughlin 2009-10-29 9:16 ` Mark McLoughlin 2009-10-29 12:00 ` Scott Tsai 2009-10-29 12:00 ` Scott Tsai 2009-10-29 12:16 ` Mark McLoughlin 2009-10-29 12:16 ` Mark McLoughlin 2009-10-29 12:21 ` Scott Tsai 2009-10-29 12:21 ` Scott Tsai 2009-10-29 14:11 ` Anthony Liguori 2009-10-29 14:11 ` Anthony Liguori 2009-10-29 14:25 ` Mark McLoughlin 2009-10-29 14:25 ` Mark McLoughlin 2009-10-29 14:34 ` Dustin Kirkland 2009-10-29 14:34 ` Dustin Kirkland 2009-10-29 14:46 ` Dustin Kirkland 2009-10-29 14:46 ` Dustin Kirkland 2009-10-29 14:50 ` Mark McLoughlin 2009-10-29 14:50 ` Mark McLoughlin 2009-10-29 14:39 ` Anthony Liguori 2009-10-29 14:39 ` Anthony Liguori 2009-10-29 14:48 ` Mark McLoughlin [this message] 2009-10-29 14:48 ` Mark McLoughlin 2009-10-29 15:01 ` Dustin Kirkland 2009-10-29 15:01 ` Dustin Kirkland 2009-10-29 15:01 ` Mark McLoughlin 2009-10-29 15:01 ` Mark McLoughlin 2009-10-29 15:13 ` Dustin Kirkland 2009-10-29 15:13 ` Dustin Kirkland 2009-10-29 15:15 ` Mark McLoughlin 2009-10-29 15:15 ` Mark McLoughlin 2009-10-29 15:34 ` [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...] Dustin Kirkland 2009-10-29 15:34 ` [Qemu-devel] " Dustin Kirkland 2009-10-30 21:15 ` Dustin Kirkland 2009-10-30 21:15 ` [Qemu-devel] " Dustin Kirkland 2009-11-02 14:38 ` Mark McLoughlin 2009-11-02 14:38 ` [Qemu-devel] " Mark McLoughlin 2009-11-02 15:42 ` Anthony Liguori 2009-11-02 15:42 ` [Qemu-devel] " Anthony Liguori 2009-11-02 15:52 ` Jamie Lokier 2009-11-02 18:20 ` Michael Tokarev 2009-11-02 18:20 ` Michael Tokarev 2009-11-02 19:39 ` Jamie Lokier 2009-11-02 19:39 ` Jamie Lokier 2009-11-02 18:55 ` Anthony Liguori 2009-11-02 19:25 ` Dustin Kirkland 2009-11-02 19:25 ` Dustin Kirkland 2009-11-02 20:50 ` Anthony Liguori 2009-11-02 20:50 ` Anthony Liguori 2009-11-05 5:06 ` Jamie Lokier 2009-11-05 5:06 ` Jamie Lokier 2009-11-02 16:58 ` Dustin Kirkland 2009-11-02 16:58 ` [Qemu-devel] " Dustin Kirkland 2009-10-29 14:39 ` [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Dustin Kirkland 2009-10-29 14:39 ` Dustin Kirkland 2009-10-29 23:22 ` Scott Tsai 2009-10-29 23:22 ` Scott Tsai 2009-10-29 12:23 ` Michael S. Tsirkin 2009-10-29 12:23 ` [Qemu-devel] " Michael S. Tsirkin 2009-10-29 14:38 ` Avi Kivity 2009-10-29 14:38 ` [Qemu-devel] " Avi Kivity 2009-10-29 15:03 ` Michael S. Tsirkin 2009-10-29 15:03 ` [Qemu-devel] " Michael S. Tsirkin 2009-10-29 14:43 ` [Qemu-devel] " Dustin Kirkland 2009-10-29 14:43 ` Dustin Kirkland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1256827719.10825.75.camel@blaa \ --to=markmc@redhat.com \ --cc=anthony@codemonkey.ws \ --cc=kirkland@canonical.com \ --cc=kvm@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ --cc=rusty@rustcorp.com.au \ --cc=scottt.tw@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.