BKM on add SRC_URI MD5 and SHA256 checksum

BKM on add SRC_URI MD5 and SHA256 checksum

[Yu, Ke]

Hi Distro folks:

As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we upgrade the recipes, here is a simple how-to:

Two entry is needed for checksum, take meta/recipes-extended/tar/tar_1.23.bb as example:
SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
SRC_URI[sha256sum] = "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"

The md5sum and sha256sum value can be get by:

# md5sum /your_DL_DIR/ tar-1.23.tar.bz2
41e2ca4b924ec7860e51b43ad06cdb7e

# sha256sum /your_DL_DIR/ tar-1.23.tar.bz2
c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36

Regards
Ke

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Scott Garman]

On 11/17/2010 06:32 PM, Yu, Ke wrote:
> Hi Distro folks:
>
> As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we upgrade the recipes, here is a simple how-to:
>
> Two entry is needed for checksum, take meta/recipes-extended/tar/tar_1.23.bb as example:
> SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
> SRC_URI[sha256sum] = "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
>
> The md5sum and sha256sum value can be get by:
>
> # md5sum /your_DL_DIR/ tar-1.23.tar.bz2
> 41e2ca4b924ec7860e51b43ad06cdb7e
>
> # sha256sum /your_DL_DIR/ tar-1.23.tar.bz2
> c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36

Thanks Ke,

As a style note I'll mention that the usual place to put the entries in 
a recipe is after the SRC_URI line. Example:

http://git.pokylinux.org/cgit/cgit.cgi/poky/tree/meta/recipes-extended/grep/grep_2.7.bb

I tend to put a blank line between the SRC_URI and SRC_URI[checksum] 
fields, but that's just my personal preference. I think it looks best 
especially when a SRC_URI includes several patches.

Scott

-- 
Scott Garman
Embedded Linux Distro Engineer - Yocto Project

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Saul Wold]

On 11/17/2010 06:32 PM, Yu, Ke wrote:
> Hi Distro folks:
>
> As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we upgrade the recipes, here is a simple how-to:
>
> Two entry is needed for checksum, take meta/recipes-extended/tar/tar_1.23.bb as example:
> SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
> SRC_URI[sha256sum] = "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
>
Also, a clarification, these values should go at the END of the file, 
which I believe is the OE Style on this.

Sau!
> The md5sum and sha256sum value can be get by:
>
> # md5sum /your_DL_DIR/ tar-1.23.tar.bz2
> 41e2ca4b924ec7860e51b43ad06cdb7e
>
> # sha256sum /your_DL_DIR/ tar-1.23.tar.bz2
> c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36
>
> Regards
> Ke
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Yu Ke]

On Nov 17, 21:35, Saul Wold wrote:
> On 11/17/2010 09:30 PM, Scott Garman wrote:
> >On 11/17/2010 09:10 PM, Saul Wold wrote:
> >>On 11/17/2010 06:32 PM, Yu, Ke wrote:
> >>>Hi Distro folks:
> >>>
> >>>As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we
> >>>upgrade the recipes, here is a simple how-to:
> >>>
> >>>Two entry is needed for checksum, take
> >>>meta/recipes-extended/tar/tar_1.23.bb as example:
> >>>SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
> >>>SRC_URI[sha256sum] =
> >>>"c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
> >>>
> >>Also, a clarification, these values should go at the END of the file,
> >>which I believe is the OE Style on this.
> >
> >The reason you see many OE files with the checksums at the end of the
> >file is that at one point a member of the OE community wrote a script to
> >append the values to a ton of recipes and then checked it in.
> >
> Can we borrow that script?  That's what I would be doing also!
> 
> If you know where it is, it would save some of the work I need to do.

Yes, in this case, distro people would better not to add checksum info during the recipes upgradtion. This will save upgrade effort, and also simplify the script, in that the script don't need to check if the checksum already add or not.

Regards
Ke

> 
> Sau!
> 
> >I would think that keeping the SRC_URI fields relatively close to each
> >other makes more logical sense. But I'm not going to get religious about
> >it.
> >
> >Scott
> >
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Scott Garman]

On 11/17/2010 09:10 PM, Saul Wold wrote:
> On 11/17/2010 06:32 PM, Yu, Ke wrote:
>> Hi Distro folks:
>>
>> As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we upgrade the recipes, here is a simple how-to:
>>
>> Two entry is needed for checksum, take meta/recipes-extended/tar/tar_1.23.bb as example:
>> SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
>> SRC_URI[sha256sum] = "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
>>
> Also, a clarification, these values should go at the END of the file,
> which I believe is the OE Style on this.

The reason you see many OE files with the checksums at the end of the 
file is that at one point a member of the OE community wrote a script to 
append the values to a ton of recipes and then checked it in.

I would think that keeping the SRC_URI fields relatively close to each 
other makes more logical sense. But I'm not going to get religious about it.

Scott

-- 
Scott Garman
Embedded Linux Distro Engineer - Yocto Project

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Saul Wold]

On 11/17/2010 09:30 PM, Scott Garman wrote:
> On 11/17/2010 09:10 PM, Saul Wold wrote:
>> On 11/17/2010 06:32 PM, Yu, Ke wrote:
>>> Hi Distro folks:
>>>
>>> As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we
>>> upgrade the recipes, here is a simple how-to:
>>>
>>> Two entry is needed for checksum, take
>>> meta/recipes-extended/tar/tar_1.23.bb as example:
>>> SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
>>> SRC_URI[sha256sum] =
>>> "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
>>>
>> Also, a clarification, these values should go at the END of the file,
>> which I believe is the OE Style on this.
>
> The reason you see many OE files with the checksums at the end of the
> file is that at one point a member of the OE community wrote a script to
> append the values to a ton of recipes and then checked it in.
>
Can we borrow that script?  That's what I would be doing also!

If you know where it is, it would save some of the work I need to do.

Sau!

> I would think that keeping the SRC_URI fields relatively close to each
> other makes more logical sense. But I'm not going to get religious about
> it.
>
> Scott
>

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Joshua Lock]

On Wed, 2010-11-17 at 21:30 -0800, Scott Garman wrote:
> On 11/17/2010 09:10 PM, Saul Wold wrote:
> > On 11/17/2010 06:32 PM, Yu, Ke wrote:
> >> Hi Distro folks:
> >>
> >> As Saul suggest to add SRC_URI MD5 and SHA256 checksum when we upgrade the recipes, here is a simple how-to:
> >>
> >> Two entry is needed for checksum, take meta/recipes-extended/tar/tar_1.23.bb as example:
> >> SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
> >> SRC_URI[sha256sum] = "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
> >>
> > Also, a clarification, these values should go at the END of the file,
> > which I believe is the OE Style on this.
> 
> The reason you see many OE files with the checksums at the end of the 
> file is that at one point a member of the OE community wrote a script to 
> append the values to a ton of recipes and then checked it in.
> 
> I would think that keeping the SRC_URI fields relatively close to each 
> other makes more logical sense. But I'm not going to get religious about it.

I'm willing to be religious about it. A selling point of Poky has always
been the cleaner, better maintained, metadata. 

Therefore fields which logically fit together should be kept so. Let's
keep the SRC_URI fields together please.

Cheers,
Joshua
-- 
Joshua Lock
        Intel Open Source Technology Centre

Re: BKM on add SRC_URI MD5 and SHA256 checksum

[Scott Garman]

On 11/17/2010 09:35 PM, Saul Wold wrote:
>> The reason you see many OE files with the checksums at the end of the
>> file is that at one point a member of the OE community wrote a script to
>> append the values to a ton of recipes and then checked it in.
>>
> Can we borrow that script?  That's what I would be doing also!
>
> If you know where it is, it would save some of the work I need to do.

I believe Martin Jansa wrote it, based on his OE commits around this 
time frame:

http://git.openembedded.org/cgit.cgi/openembedded/commit/?id=01daac1be0f89f00495f920359edc4b39c7a100f

I'd recommend emailing him directly and asking if he still has it.

Scott

-- 
Scott Garman
Embedded Linux Distro Engineer - Yocto Project