From: Ezequiel Garcia <ezequiel@collabora.com> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, kernel@collabora.com, Philipp Zabel <p.zabel@pengutronix.de>, linux-media@vger.kernel.org, linux-rockchip <linux-rockchip@lists.infradead.org>, Nicolas Dufresne <nicolas.dufresne@collabora.com>, Benjamin Gaignard <benjamin.gaignard@collabora.com> Subject: Re: [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component Date: Mon, 08 Mar 2021 12:25:17 -0300 [thread overview] Message-ID: <12bd921ce856590f5a4426de45865ad007b791e9.camel@collabora.com> (raw) In-Reply-To: <CACvgo51peuKsuqx-NwZSWU4Ys1q5MuXb=BRx7GLo3tkWH+vb0w@mail.gmail.com> On Mon, 2021-03-08 at 13:07 +0000, Emil Velikov wrote: > Hi Ezequiel, > > Thanks for the prompt reply > > On Sat, 6 Mar 2021 at 11:25, Ezequiel Garcia <ezequiel@collabora.com> wrote: > > > > (adding another Nicolas) > > > > Hi Emil, > > > > Thanks a lot for the patch. > > > > On Fri, 2021-03-05 at 18:39 +0000, Emil Velikov wrote: > > > From: Emil Velikov <emil.velikov@collabora.com> > > > > > > The SoC features a Hantro G1 compatible video decoder. > > > > > > Cc: Ezequiel Garcia <ezequiel@collabora.com> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > > Cc: linux-media@vger.kernel.org > > > Cc: linux-rockchip@lists.infradead.org > > > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> [..] > > > +static const struct hantro_fmt sama5d4_vdec_postproc_fmts[] = { > > > + { > > > + .fourcc = V4L2_PIX_FMT_YUYV, > > > + .codec_mode = HANTRO_MODE_NONE, > > > + }, > > > +}; > > > + > > > > I haven't found information on how the series > > was tested in the cover letter, could you add that to the next > > iteration? > > > > Please test the YUYV post-processed output and MPEG-2 decoding as well. > > > Any recommendations for MPEG-2 and post-processing testing? For the > former I could use gstreamer on Big Buck Bunny or other media, yet not > sure about the latter. > The post-processed YUYV output can be requested like this in GStreamer: gst-launch-1.0 -v filesrc location=$something ! parsebin ! decodebin ! video/x-raw,format=YUY2 ! ... For MPEG-2 testing, I'm afraid there's no GStreamer yet for this, but Jonas' ffmpeg should work https://github.com/Kwiboo/FFmpeg/commits/v4l2-request-hwaccel-4.3. Thanks, Ezequiel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, kernel@collabora.com, Philipp Zabel <p.zabel@pengutronix.de>, linux-media@vger.kernel.org, linux-rockchip <linux-rockchip@lists.infradead.org>, Nicolas Dufresne <nicolas.dufresne@collabora.com>, Benjamin Gaignard <benjamin.gaignard@collabora.com> Subject: Re: [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component Date: Mon, 08 Mar 2021 12:25:17 -0300 [thread overview] Message-ID: <12bd921ce856590f5a4426de45865ad007b791e9.camel@collabora.com> (raw) In-Reply-To: <CACvgo51peuKsuqx-NwZSWU4Ys1q5MuXb=BRx7GLo3tkWH+vb0w@mail.gmail.com> On Mon, 2021-03-08 at 13:07 +0000, Emil Velikov wrote: > Hi Ezequiel, > > Thanks for the prompt reply > > On Sat, 6 Mar 2021 at 11:25, Ezequiel Garcia <ezequiel@collabora.com> wrote: > > > > (adding another Nicolas) > > > > Hi Emil, > > > > Thanks a lot for the patch. > > > > On Fri, 2021-03-05 at 18:39 +0000, Emil Velikov wrote: > > > From: Emil Velikov <emil.velikov@collabora.com> > > > > > > The SoC features a Hantro G1 compatible video decoder. > > > > > > Cc: Ezequiel Garcia <ezequiel@collabora.com> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > > Cc: linux-media@vger.kernel.org > > > Cc: linux-rockchip@lists.infradead.org > > > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> [..] > > > +static const struct hantro_fmt sama5d4_vdec_postproc_fmts[] = { > > > + { > > > + .fourcc = V4L2_PIX_FMT_YUYV, > > > + .codec_mode = HANTRO_MODE_NONE, > > > + }, > > > +}; > > > + > > > > I haven't found information on how the series > > was tested in the cover letter, could you add that to the next > > iteration? > > > > Please test the YUYV post-processed output and MPEG-2 decoding as well. > > > Any recommendations for MPEG-2 and post-processing testing? For the > former I could use gstreamer on Big Buck Bunny or other media, yet not > sure about the latter. > The post-processed YUYV output can be requested like this in GStreamer: gst-launch-1.0 -v filesrc location=$something ! parsebin ! decodebin ! video/x-raw,format=YUY2 ! ... For MPEG-2 testing, I'm afraid there's no GStreamer yet for this, but Jonas' ffmpeg should work https://github.com/Kwiboo/FFmpeg/commits/v4l2-request-hwaccel-4.3. Thanks, Ezequiel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-03-08 15:26 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-05 18:39 [PATCH 0/7] Microship SAMA5D4 VPU support et al Emil Velikov 2021-03-05 18:39 ` [PATCH 1/7] media: hantro: use G1_REG_INTERRUPT directly for the mpeg2 Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` [PATCH 2/7] media: hantro: imx: reuse MB_DIM define Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` [PATCH 3/7] media: hantro: imx: remove duplicate dec_base init Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` [PATCH 4/7] media: hantro: imx: remove unused include Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-08 13:57 ` Philipp Zabel 2021-03-08 13:57 ` Philipp Zabel 2021-03-08 13:57 ` Philipp Zabel 2021-03-08 16:01 ` Emil Velikov 2021-03-08 16:01 ` Emil Velikov 2021-03-08 16:01 ` Emil Velikov 2021-03-05 18:39 ` [PATCH 5/7] media: hantro: introduce hantro_g1.c for common API Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-08 13:59 ` Philipp Zabel 2021-03-08 13:59 ` Philipp Zabel 2021-03-08 13:59 ` Philipp Zabel 2021-03-05 18:39 ` [PATCH 6/7] ARM: configs: at91: sama5: update with savedefconfig Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-05 18:39 ` Emil Velikov 2021-03-06 11:25 ` Ezequiel Garcia 2021-03-06 11:25 ` Ezequiel Garcia 2021-03-08 13:07 ` Emil Velikov 2021-03-08 13:07 ` Emil Velikov 2021-03-08 13:21 ` Nicolas Ferre 2021-03-08 13:21 ` Nicolas Ferre 2021-03-08 15:57 ` Emil Velikov 2021-03-08 15:57 ` Emil Velikov 2021-03-08 17:42 ` Nicolas Ferre 2021-03-08 17:42 ` Nicolas Ferre 2021-03-08 15:25 ` Ezequiel Garcia [this message] 2021-03-08 15:25 ` Ezequiel Garcia 2021-03-05 22:58 ` [PATCH 0/7] Microship SAMA5D4 VPU support et al Emil Velikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=12bd921ce856590f5a4426de45865ad007b791e9.camel@collabora.com \ --to=ezequiel@collabora.com \ --cc=benjamin.gaignard@collabora.com \ --cc=emil.l.velikov@gmail.com \ --cc=kernel@collabora.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=nicolas.dufresne@collabora.com \ --cc=nicolas.ferre@microchip.com \ --cc=p.zabel@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.