All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Ezequiel Garcia <ezequiel@collabora.com>, <kernel@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	<linux-media@vger.kernel.org>,
	linux-rockchip <linux-rockchip@lists.infradead.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: Re: [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component
Date: Mon, 8 Mar 2021 18:42:03 +0100	[thread overview]
Message-ID: <5d6ce808-7353-be95-7d68-a56d01833dbe@microchip.com> (raw)
In-Reply-To: <CACvgo52dNRyiLDGDf8wQMKoxsCUyn3Ro=hHL7GAMtVXRdC_19A@mail.gmail.com>

On 08/03/2021 at 16:57, Emil Velikov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, 8 Mar 2021 at 13:21, Nicolas Ferre <nicolas.ferre@microchip.com> wrote:
>>
>> Hi Emil,
>>
> Greetings Nicolas,
> 
>> So nice to see this support! Thank you so much for handling that.
>>
>> Little comments below...
>>
> 
>> Nitpicking: I would use "microchip,sama5d4-vdec". We tend to use the
>> microchip name for new DT bidings and compatibility strings.
>>
> Should i use Microchip (instead of Atmel) only for the DT bindings or
> throughout the series?

Yes, everywhere you can (Kconfig, explanation text, ...). Only keep 
Atmel/atmel where you cannot do differently or if it would require to 
modify code or move file just for this purpose.

Regards,
   Nicolas

>> I'm fine with having a "staging" component. Maybe add the hantro vdec as
>> a module instead.
>>
> Ack, will do for v2.
> 
> Thanks
> Emil
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Ezequiel Garcia <ezequiel@collabora.com>, <kernel@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	<linux-media@vger.kernel.org>,
	linux-rockchip <linux-rockchip@lists.infradead.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: Re: [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component
Date: Mon, 8 Mar 2021 18:42:03 +0100	[thread overview]
Message-ID: <5d6ce808-7353-be95-7d68-a56d01833dbe@microchip.com> (raw)
In-Reply-To: <CACvgo52dNRyiLDGDf8wQMKoxsCUyn3Ro=hHL7GAMtVXRdC_19A@mail.gmail.com>

On 08/03/2021 at 16:57, Emil Velikov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, 8 Mar 2021 at 13:21, Nicolas Ferre <nicolas.ferre@microchip.com> wrote:
>>
>> Hi Emil,
>>
> Greetings Nicolas,
> 
>> So nice to see this support! Thank you so much for handling that.
>>
>> Little comments below...
>>
> 
>> Nitpicking: I would use "microchip,sama5d4-vdec". We tend to use the
>> microchip name for new DT bidings and compatibility strings.
>>
> Should i use Microchip (instead of Atmel) only for the DT bindings or
> throughout the series?

Yes, everywhere you can (Kconfig, explanation text, ...). Only keep 
Atmel/atmel where you cannot do differently or if it would require to 
modify code or move file just for this purpose.

Regards,
   Nicolas

>> I'm fine with having a "staging" component. Maybe add the hantro vdec as
>> a module instead.
>>
> Ack, will do for v2.
> 
> Thanks
> Emil
> 


-- 
Nicolas Ferre

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2021-03-08 17:42 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 18:39 [PATCH 0/7] Microship SAMA5D4 VPU support et al Emil Velikov
2021-03-05 18:39 ` [PATCH 1/7] media: hantro: use G1_REG_INTERRUPT directly for the mpeg2 Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39 ` [PATCH 2/7] media: hantro: imx: reuse MB_DIM define Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39 ` [PATCH 3/7] media: hantro: imx: remove duplicate dec_base init Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39 ` [PATCH 4/7] media: hantro: imx: remove unused include Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-08 13:57   ` Philipp Zabel
2021-03-08 13:57     ` Philipp Zabel
2021-03-08 13:57     ` Philipp Zabel
2021-03-08 16:01     ` Emil Velikov
2021-03-08 16:01       ` Emil Velikov
2021-03-08 16:01       ` Emil Velikov
2021-03-05 18:39 ` [PATCH 5/7] media: hantro: introduce hantro_g1.c for common API Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-08 13:59   ` Philipp Zabel
2021-03-08 13:59     ` Philipp Zabel
2021-03-08 13:59     ` Philipp Zabel
2021-03-05 18:39 ` [PATCH 6/7] ARM: configs: at91: sama5: update with savedefconfig Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39 ` [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-05 18:39   ` Emil Velikov
2021-03-06 11:25   ` Ezequiel Garcia
2021-03-06 11:25     ` Ezequiel Garcia
2021-03-08 13:07     ` Emil Velikov
2021-03-08 13:07       ` Emil Velikov
2021-03-08 13:21       ` Nicolas Ferre
2021-03-08 13:21         ` Nicolas Ferre
2021-03-08 15:57         ` Emil Velikov
2021-03-08 15:57           ` Emil Velikov
2021-03-08 17:42           ` Nicolas Ferre [this message]
2021-03-08 17:42             ` Nicolas Ferre
2021-03-08 15:25       ` Ezequiel Garcia
2021-03-08 15:25         ` Ezequiel Garcia
2021-03-05 22:58 ` [PATCH 0/7] Microship SAMA5D4 VPU support et al Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d6ce808-7353-be95-7d68-a56d01833dbe@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=emil.l.velikov@gmail.com \
    --cc=ezequiel@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.