* [PATCH] wireless: rt2x00: rt2800usb add more devices ids
@ 2012-04-15 0:09 Xose Vazquez Perez
2012-04-15 6:37 ` [rt2x00-users] " Andreas Hartmann
2012-04-15 12:25 ` Gertjan van Wingerde
0 siblings, 2 replies; 7+ messages in thread
From: Xose Vazquez Perez @ 2012-04-15 0:09 UTC (permalink / raw)
To: xose.vazquez, linux-wireless, users, IvDoorn, linville,
gwingerde, helmut.schaa
They were taken from ralink drivers:
2011_0719_RT3070_RT3370_RT5370_RT5372_Linux_STA_V2.5.0.3_DPO
2012_03_22_RT5572_Linux_STA_v2.6.0.0_DPO
0x1eda,0x2210 RT3070 Airties
0x083a,0xb511 RT3370 Panasonic
0x0471,0x20dd RT3370 Philips
0x1875,0x7733 RT3573 Air Live
0x7392,0x7733 RT3573 Edimax
0x0e66,0x0021 RT3573 Hawking
0x2019,0xed19 RT3573 Planex
0x148f,0x3573 RT3573 Ralink
0x0df6,0x0067 RT3573 Sitecom
0x1690,0x0764 RT35xx Askey
0x0df6,0x0065 RT35xx Sitecom
0x0df6,0x0066 RT35xx Sitecom
0x0df6,0x0068 RT35xx Sitecom
0x2001,0x3c1c RT5370 DLink
0x2001,0x3c1d RT5370 DLink
2001 is D-Link not Alpha
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
drivers/net/wireless/rt2x00/rt2800usb.c | 27 ++++++++++++++++++++++++---
1 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index 001735f..c4d7f6f 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -922,6 +922,7 @@ static struct usb_device_id rt2800usb_device_table[] = {
{ USB_DEVICE(0x1482, 0x3c09) },
/* AirTies */
{ USB_DEVICE(0x1eda, 0x2012) },
+ { USB_DEVICE(0x1eda, 0x2210) },
{ USB_DEVICE(0x1eda, 0x2310) },
/* Allwin */
{ USB_DEVICE(0x8516, 0x2070) },
@@ -1134,6 +1135,10 @@ static struct usb_device_id rt2800usb_device_table[] = {
#ifdef CONFIG_RT2800USB_RT33XX
/* Belkin */
{ USB_DEVICE(0x050d, 0x945b) },
+ /* Panasonic */
+ { USB_DEVICE(0x083a, 0xb511) },
+ /* Philips */
+ { USB_DEVICE(0x0471, 0x20dd) },
/* Ralink */
{ USB_DEVICE(0x148f, 0x3370) },
{ USB_DEVICE(0x148f, 0x8070) },
@@ -1141,38 +1146,54 @@ static struct usb_device_id rt2800usb_device_table[] = {
{ USB_DEVICE(0x0df6, 0x0050) },
#endif
#ifdef CONFIG_RT2800USB_RT35XX
+ /* Air Live */
+ { USB_DEVICE(0x1875, 0x7733) },
/* Allwin */
{ USB_DEVICE(0x8516, 0x3572) },
/* Askey */
{ USB_DEVICE(0x1690, 0x0744) },
+ { USB_DEVICE(0x1690, 0x0764) },
/* Cisco */
{ USB_DEVICE(0x167b, 0x4001) },
+ /* Edimax */
+ { USB_DEVICE(0x7392, 0x7733) },
/* EnGenius */
{ USB_DEVICE(0x1740, 0x9801) },
+ /* Hawking */
+ { USB_DEVICE(0x0e66, 0x0021) },
/* I-O DATA */
{ USB_DEVICE(0x04bb, 0x0944) },
/* Linksys */
{ USB_DEVICE(0x13b1, 0x002f) },
{ USB_DEVICE(0x1737, 0x0079) },
+ /* Planex */
+ { USB_DEVICE(0x2019, 0xed19) },
/* Ralink */
{ USB_DEVICE(0x148f, 0x3572) },
+ { USB_DEVICE(0x148f, 0x3573) },
/* Sitecom */
{ USB_DEVICE(0x0df6, 0x0041) },
{ USB_DEVICE(0x0df6, 0x0062) },
+ { USB_DEVICE(0x0df6, 0x0065) },
+ { USB_DEVICE(0x0df6, 0x0066) },
+ { USB_DEVICE(0x0df6, 0x0067) },
+ { USB_DEVICE(0x0df6, 0x0068) },
/* Toshiba */
{ USB_DEVICE(0x0930, 0x0a07) },
/* Zinwell */
{ USB_DEVICE(0x5a57, 0x0284) },
#endif
#ifdef CONFIG_RT2800USB_RT53XX
- /* Alpha */
- { USB_DEVICE(0x2001, 0x3c15) },
- { USB_DEVICE(0x2001, 0x3c19) },
/* Arcadyan */
{ USB_DEVICE(0x043e, 0x7a12) },
/* Azurewave */
{ USB_DEVICE(0x13d3, 0x3329) },
{ USB_DEVICE(0x13d3, 0x3365) },
+ /* D-Link */
+ { USB_DEVICE(0x2001, 0x3c15) },
+ { USB_DEVICE(0x2001, 0x3c19) },
+ { USB_DEVICE(0x2001, 0x3c1c) },
+ { USB_DEVICE(0x2001, 0x3c1d) },
/* LG innotek */
{ USB_DEVICE(0x043e, 0x7a22) },
/* Panasonic */
--
1.7.6.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [rt2x00-users] [PATCH] wireless: rt2x00: rt2800usb add more devices ids
2012-04-15 0:09 [PATCH] wireless: rt2x00: rt2800usb add more devices ids Xose Vazquez Perez
@ 2012-04-15 6:37 ` Andreas Hartmann
2012-04-15 9:19 ` Xose Vazquez Perez
2012-04-15 12:25 ` Gertjan van Wingerde
1 sibling, 1 reply; 7+ messages in thread
From: Andreas Hartmann @ 2012-04-15 6:37 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: linux-wireless, users, IvDoorn, linville, gwingerde, helmut.schaa
Xose Vazquez Perez wrote:
> They were taken from ralink drivers:
> 2011_0719_RT3070_RT3370_RT5370_RT5372_Linux_STA_V2.5.0.3_DPO
> 2012_03_22_RT5572_Linux_STA_v2.6.0.0_DPO
>
> 0x1eda,0x2210 RT3070 Airties
>
> 0x083a,0xb511 RT3370 Panasonic
> 0x0471,0x20dd RT3370 Philips
>
> 0x1875,0x7733 RT3573 Air Live
> 0x7392,0x7733 RT3573 Edimax
> 0x0e66,0x0021 RT3573 Hawking
> 0x2019,0xed19 RT3573 Planex
> 0x148f,0x3573 RT3573 Ralink
> 0x0df6,0x0067 RT3573 Sitecom
> 0x1690,0x0764 RT35xx Askey
> 0x0df6,0x0065 RT35xx Sitecom
> 0x0df6,0x0066 RT35xx Sitecom
> 0x0df6,0x0068 RT35xx Sitecom
>
> 0x2001,0x3c1c RT5370 DLink
> 0x2001,0x3c1d RT5370 DLink
>
> 2001 is D-Link not Alpha
Did you test them? What did you test exactly? What exactly works, what
does not?
It doesn't mean anything, if they work with the legacy driver. Linksys
WUSB600Nv2 e.g. works fine with the legacy driver, but only limited (if
at all) with rt2800usb yet.
Regards,
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [rt2x00-users] [PATCH] wireless: rt2x00: rt2800usb add more devices ids
2012-04-15 6:37 ` [rt2x00-users] " Andreas Hartmann
@ 2012-04-15 9:19 ` Xose Vazquez Perez
2012-04-15 12:03 ` Andreas Hartmann
0 siblings, 1 reply; 7+ messages in thread
From: Xose Vazquez Perez @ 2012-04-15 9:19 UTC (permalink / raw)
To: Andreas Hartmann
Cc: linux-wireless, users, IvDoorn, linville, gwingerde, helmut.schaa
On 04/15/2012 08:37 AM, Andreas Hartmann wrote:
> Did you test them? What did you test exactly? What exactly works, what
> does not?
NO. NOTHING . I DON'T KNOW. But...
> It doesn't mean anything, if they work with the legacy driver.
..., the chips in these devices are *identified* . They perform so well
or so badly like those that are already in the driver(rt2800usb).
> Linksys WUSB600Nv2 e.g. works fine with the legacy driver, but only
> limited (if at all) with rt2800usb yet.
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/rt2x00/Kconfig;h=299c3879582da14e12ca00d7f11184da8c61bed7;hb=HEAD#l83>
config RT2800USB_RT35XX
bool "rt2800usb - Include support for rt35xx devices ( *EXPERIMENTAL* )"
depends on *EXPERIMENTAL*
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [rt2x00-users] [PATCH] wireless: rt2x00: rt2800usb add more devices ids
2012-04-15 9:19 ` Xose Vazquez Perez
@ 2012-04-15 12:03 ` Andreas Hartmann
2012-04-15 13:04 ` Gertjan van Wingerde
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Hartmann @ 2012-04-15 12:03 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: linux-wireless, users, IvDoorn, linville, gwingerde, helmut.schaa
Hello Xose,
sorry for double post - I accidentally pressed the wrong answer button :-(.
Xose Vazquez Perez wrote:
> On 04/15/2012 08:37 AM, Andreas Hartmann wrote:
>
>> Did you test them? What did you test exactly? What exactly works, what
>> does not?
>
> NO. NOTHING . I DON'T KNOW. But...
>
>> It doesn't mean anything, if they work with the legacy driver.
>
> ..., the chips in these devices are *identified* . They perform so well
> or so badly like those that are already in the driver(rt2800usb).
This is an expectation. The mentioned WUSB600Nv2 is one proof, that it
isn't (always) enough to successfully identify chips and derive, that it
behaves like other brands using the same chip. There have been brands
with this chip, which have been working fine (supposedly), but this
special brand didn't work at all here - even though it uses an already
known chip.
>> Linksys WUSB600Nv2 e.g. works fine with the legacy driver, but only
>> limited (if at all) with rt2800usb yet.
>
> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/rt2x00/Kconfig;h=299c3879582da14e12ca00d7f11184da8c61bed7;hb=HEAD#l83>
>
> config RT2800USB_RT35XX
> bool "rt2800usb - Include support for rt35xx devices ( *EXPERIMENTAL* )"
> depends on *EXPERIMENTAL*
Chance :-)
rt2860 (PCI) chipset (rt2800pci) isn't experimental but is nevertheless
broken since 3.2 [1].
I'm seeing a fundamental problem (but not just here :-)) regarding QA. I
can't see any QA if there is done any change. Ok, I don't know all and
maybe, I'm blind, too. But I'm willing to learn .
That's why I'm wondering: When are all these appropriate devices going
to be tested? I think, a good point would be during development and not
after they have been released (means: "experimental" was removed). If
the ID's are committed, it should be ensured, that they really behave as
expected.
Kind regards,
Andreas
[1]
http://thread.gmane.org/gmane.linux.kernel.wireless.general/83297/focus=83304
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wireless: rt2x00: rt2800usb add more devices ids
2012-04-15 0:09 [PATCH] wireless: rt2x00: rt2800usb add more devices ids Xose Vazquez Perez
2012-04-15 6:37 ` [rt2x00-users] " Andreas Hartmann
@ 2012-04-15 12:25 ` Gertjan van Wingerde
1 sibling, 0 replies; 7+ messages in thread
From: Gertjan van Wingerde @ 2012-04-15 12:25 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: linux-wireless, users, IvDoorn, linville, helmut.schaa
On 04/15/12 02:09, Xose Vazquez Perez wrote:
> They were taken from ralink drivers:
> 2011_0719_RT3070_RT3370_RT5370_RT5372_Linux_STA_V2.5.0.3_DPO
> 2012_03_22_RT5572_Linux_STA_v2.6.0.0_DPO
>
> 0x1eda,0x2210 RT3070 Airties
>
> 0x083a,0xb511 RT3370 Panasonic
> 0x0471,0x20dd RT3370 Philips
>
> 0x1875,0x7733 RT3573 Air Live
> 0x7392,0x7733 RT3573 Edimax
> 0x0e66,0x0021 RT3573 Hawking
> 0x2019,0xed19 RT3573 Planex
> 0x148f,0x3573 RT3573 Ralink
> 0x0df6,0x0067 RT3573 Sitecom
> 0x1690,0x0764 RT35xx Askey
> 0x0df6,0x0065 RT35xx Sitecom
> 0x0df6,0x0066 RT35xx Sitecom
> 0x0df6,0x0068 RT35xx Sitecom
>
> 0x2001,0x3c1c RT5370 DLink
> 0x2001,0x3c1d RT5370 DLink
>
> 2001 is D-Link not Alpha
>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
Please do not add the RT3573 devices (yet). The RT3573 chipset is not
supported by rt2x00 at the moment and it is quite a different beast from
the other chipsets (different EEPROM layout, 3x3 device).
The other ones are OK to add.
> ---
> drivers/net/wireless/rt2x00/rt2800usb.c | 27 ++++++++++++++++++++++++---
> 1 files changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 001735f..c4d7f6f 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -922,6 +922,7 @@ static struct usb_device_id rt2800usb_device_table[] = {
> { USB_DEVICE(0x1482, 0x3c09) },
> /* AirTies */
> { USB_DEVICE(0x1eda, 0x2012) },
> + { USB_DEVICE(0x1eda, 0x2210) },
> { USB_DEVICE(0x1eda, 0x2310) },
> /* Allwin */
> { USB_DEVICE(0x8516, 0x2070) },
> @@ -1134,6 +1135,10 @@ static struct usb_device_id rt2800usb_device_table[] = {
> #ifdef CONFIG_RT2800USB_RT33XX
> /* Belkin */
> { USB_DEVICE(0x050d, 0x945b) },
> + /* Panasonic */
> + { USB_DEVICE(0x083a, 0xb511) },
> + /* Philips */
> + { USB_DEVICE(0x0471, 0x20dd) },
> /* Ralink */
> { USB_DEVICE(0x148f, 0x3370) },
> { USB_DEVICE(0x148f, 0x8070) },
> @@ -1141,38 +1146,54 @@ static struct usb_device_id rt2800usb_device_table[] = {
> { USB_DEVICE(0x0df6, 0x0050) },
> #endif
> #ifdef CONFIG_RT2800USB_RT35XX
> + /* Air Live */
> + { USB_DEVICE(0x1875, 0x7733) },
> /* Allwin */
> { USB_DEVICE(0x8516, 0x3572) },
> /* Askey */
> { USB_DEVICE(0x1690, 0x0744) },
> + { USB_DEVICE(0x1690, 0x0764) },
> /* Cisco */
> { USB_DEVICE(0x167b, 0x4001) },
> + /* Edimax */
> + { USB_DEVICE(0x7392, 0x7733) },
> /* EnGenius */
> { USB_DEVICE(0x1740, 0x9801) },
> + /* Hawking */
> + { USB_DEVICE(0x0e66, 0x0021) },
> /* I-O DATA */
> { USB_DEVICE(0x04bb, 0x0944) },
> /* Linksys */
> { USB_DEVICE(0x13b1, 0x002f) },
> { USB_DEVICE(0x1737, 0x0079) },
> + /* Planex */
> + { USB_DEVICE(0x2019, 0xed19) },
> /* Ralink */
> { USB_DEVICE(0x148f, 0x3572) },
> + { USB_DEVICE(0x148f, 0x3573) },
> /* Sitecom */
> { USB_DEVICE(0x0df6, 0x0041) },
> { USB_DEVICE(0x0df6, 0x0062) },
> + { USB_DEVICE(0x0df6, 0x0065) },
> + { USB_DEVICE(0x0df6, 0x0066) },
> + { USB_DEVICE(0x0df6, 0x0067) },
> + { USB_DEVICE(0x0df6, 0x0068) },
> /* Toshiba */
> { USB_DEVICE(0x0930, 0x0a07) },
> /* Zinwell */
> { USB_DEVICE(0x5a57, 0x0284) },
> #endif
> #ifdef CONFIG_RT2800USB_RT53XX
> - /* Alpha */
> - { USB_DEVICE(0x2001, 0x3c15) },
> - { USB_DEVICE(0x2001, 0x3c19) },
> /* Arcadyan */
> { USB_DEVICE(0x043e, 0x7a12) },
> /* Azurewave */
> { USB_DEVICE(0x13d3, 0x3329) },
> { USB_DEVICE(0x13d3, 0x3365) },
> + /* D-Link */
> + { USB_DEVICE(0x2001, 0x3c15) },
> + { USB_DEVICE(0x2001, 0x3c19) },
> + { USB_DEVICE(0x2001, 0x3c1c) },
> + { USB_DEVICE(0x2001, 0x3c1d) },
> /* LG innotek */
> { USB_DEVICE(0x043e, 0x7a22) },
> /* Panasonic */
---
Gertjan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [rt2x00-users] [PATCH] wireless: rt2x00: rt2800usb add more devices ids
2012-04-15 12:03 ` Andreas Hartmann
@ 2012-04-15 13:04 ` Gertjan van Wingerde
2012-04-15 18:09 ` Andreas Hartmann
0 siblings, 1 reply; 7+ messages in thread
From: Gertjan van Wingerde @ 2012-04-15 13:04 UTC (permalink / raw)
To: Andreas Hartmann
Cc: Xose Vazquez Perez, linux-wireless, users, IvDoorn, linville,
helmut.schaa
On 15 apr. 2012, at 14:03, Andreas Hartmann <andihartmann@01019freenet.de> wrote:
> Hello Xose,
>
> sorry for double post - I accidentally pressed the wrong answer button :-(.
>
> Xose Vazquez Perez wrote:
>> On 04/15/2012 08:37 AM, Andreas Hartmann wrote:
>>
>>> Did you test them? What did you test exactly? What exactly works, what
>>> does not?
>>
>> NO. NOTHING . I DON'T KNOW. But...
>>
>>> It doesn't mean anything, if they work with the legacy driver.
>>
>> ..., the chips in these devices are *identified* . They perform so well
>> or so badly like those that are already in the driver(rt2800usb).
>
> This is an expectation. The mentioned WUSB600Nv2 is one proof, that it
> isn't (always) enough to successfully identify chips and derive, that it
> behaves like other brands using the same chip. There have been brands
> with this chip, which have been working fine (supposedly), but this
> special brand didn't work at all here - even though it uses an already
> known chip.
>
>>> Linksys WUSB600Nv2 e.g. works fine with the legacy driver, but only
>>> limited (if at all) with rt2800usb yet.
>>
>> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/rt2x00/Kconfig;h=299c3879582da14e12ca00d7f11184da8c61bed7;hb=HEAD#l83>
>>
>> config RT2800USB_RT35XX
>> bool "rt2800usb - Include support for rt35xx devices ( *EXPERIMENTAL* )"
>> depends on *EXPERIMENTAL*
>
> Chance :-)
>
> rt2860 (PCI) chipset (rt2800pci) isn't experimental but is nevertheless
> broken since 3.2 [1].
>
> I'm seeing a fundamental problem (but not just here :-)) regarding QA. I
> can't see any QA if there is done any change. Ok, I don't know all and
> maybe, I'm blind, too. But I'm willing to learn .
>
> That's why I'm wondering: When are all these appropriate devices going
> to be tested? I think, a good point would be during development and not
> after they have been released (means: "experimental" was removed). If
> the ID's are committed, it should be ensured, that they really behave as
> expected.
Andreas,
It is impossible to test each and every device that uses a Ralink chipset. Therefore we run tests on the chipsets only, and simply list all devices that contain these chipsets.
Granted, we are having issues with some of the chipsets, but that should not prevent adding other devices that use the same chipset to the driver.
---
Gertjan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [rt2x00-users] [PATCH] wireless: rt2x00: rt2800usb add more devices ids
2012-04-15 13:04 ` Gertjan van Wingerde
@ 2012-04-15 18:09 ` Andreas Hartmann
0 siblings, 0 replies; 7+ messages in thread
From: Andreas Hartmann @ 2012-04-15 18:09 UTC (permalink / raw)
To: Gertjan van Wingerde
Cc: Xose Vazquez Perez, linux-wireless, users, IvDoorn, linville,
helmut.schaa
Hello Gertjan,
thank you for your response!
Gertjan van Wingerde wrote:
[...]
> It is impossible to test each and every device that uses a Ralink
> chipset. Therefore we run tests on the chipsets only, and simply list
> all devices that contain these chipsets.
>
> Granted, we are having issues with some of the chipsets, but that
> should not prevent adding other devices that use the same chipset to
> the driver.
It would help for making decisions on which brand to buy, if there were
a notice in the source code, e.g.: _device successfully tested
(802.11abgn)_ - other devices don't get any comment.
This way, I would be completely content with the practice to fire in
blindly every ID of each existing device containing a Ralink chipset.
Kind regards,
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-04-15 18:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-15 0:09 [PATCH] wireless: rt2x00: rt2800usb add more devices ids Xose Vazquez Perez
2012-04-15 6:37 ` [rt2x00-users] " Andreas Hartmann
2012-04-15 9:19 ` Xose Vazquez Perez
2012-04-15 12:03 ` Andreas Hartmann
2012-04-15 13:04 ` Gertjan van Wingerde
2012-04-15 18:09 ` Andreas Hartmann
2012-04-15 12:25 ` Gertjan van Wingerde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.