From: Mel Gorman <mgorman@suse.de> To: Linux-MM <linux-mm@kvack.org> Cc: Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>, Jim Schutt <jaschut@sandia.gov>, LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de> Subject: [PATCH 1/6] mm: compaction: Update comment in try_to_compact_pages Date: Tue, 7 Aug 2012 13:31:12 +0100 [thread overview] Message-ID: <1344342677-5845-2-git-send-email-mgorman@suse.de> (raw) In-Reply-To: <1344342677-5845-1-git-send-email-mgorman@suse.de> The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area. Signed-off-by: Mel Gorman <mgorman@suse.de> --- mm/compaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index b39ede1..95ca967 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -759,11 +759,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, struct zone *zone; int rc = COMPACT_SKIPPED; - /* - * Check whether it is worth even starting compaction. The order check is - * made because an assumption is made that the page allocator can satisfy - * the "cheaper" orders without taking special steps - */ + /* Check if the GFP flags allow compaction */ if (!order || !may_enter_fs || !may_perform_io) return rc; -- 1.7.9.2
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de> To: Linux-MM <linux-mm@kvack.org> Cc: Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>, Jim Schutt <jaschut@sandia.gov>, LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de> Subject: [PATCH 1/6] mm: compaction: Update comment in try_to_compact_pages Date: Tue, 7 Aug 2012 13:31:12 +0100 [thread overview] Message-ID: <1344342677-5845-2-git-send-email-mgorman@suse.de> (raw) In-Reply-To: <1344342677-5845-1-git-send-email-mgorman@suse.de> The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area. Signed-off-by: Mel Gorman <mgorman@suse.de> --- mm/compaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index b39ede1..95ca967 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -759,11 +759,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, struct zone *zone; int rc = COMPACT_SKIPPED; - /* - * Check whether it is worth even starting compaction. The order check is - * made because an assumption is made that the page allocator can satisfy - * the "cheaper" orders without taking special steps - */ + /* Check if the GFP flags allow compaction */ if (!order || !may_enter_fs || !may_perform_io) return rc; -- 1.7.9.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-07 12:31 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-07 12:31 [RFC PATCH 0/6] Improve hugepage allocation success rates under load Mel Gorman 2012-08-07 12:31 ` Mel Gorman 2012-08-07 12:31 ` Mel Gorman [this message] 2012-08-07 12:31 ` [PATCH 1/6] mm: compaction: Update comment in try_to_compact_pages Mel Gorman 2012-08-07 13:19 ` Rik van Riel 2012-08-07 13:19 ` Rik van Riel 2012-08-07 23:25 ` Minchan Kim 2012-08-07 23:25 ` Minchan Kim 2012-08-07 12:31 ` [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures Mel Gorman 2012-08-07 12:31 ` Mel Gorman 2012-08-07 13:23 ` Rik van Riel 2012-08-07 13:23 ` Rik van Riel 2012-08-08 1:48 ` Minchan Kim 2012-08-08 1:48 ` Minchan Kim 2012-08-08 7:55 ` Mel Gorman 2012-08-08 7:55 ` Mel Gorman 2012-08-08 8:27 ` Minchan Kim 2012-08-08 8:27 ` Minchan Kim 2012-08-08 8:51 ` Mel Gorman 2012-08-08 8:51 ` Mel Gorman 2012-08-08 23:51 ` Minchan Kim 2012-08-08 23:51 ` Minchan Kim 2012-08-09 7:49 ` Mel Gorman 2012-08-09 7:49 ` Mel Gorman 2012-08-09 8:27 ` Minchan Kim 2012-08-09 8:27 ` Minchan Kim 2012-08-09 9:20 ` Mel Gorman 2012-08-09 9:20 ` Mel Gorman 2012-08-09 20:29 ` Rik van Riel 2012-08-09 20:29 ` Rik van Riel 2012-08-10 8:14 ` Mel Gorman 2012-08-10 8:14 ` Mel Gorman 2012-08-09 23:27 ` Minchan Kim 2012-08-09 23:27 ` Minchan Kim 2012-08-10 8:34 ` Mel Gorman 2012-08-10 8:34 ` Mel Gorman 2012-08-10 8:48 ` Minchan Kim 2012-08-10 8:48 ` Minchan Kim 2012-08-07 12:31 ` [PATCH 3/6] mm: kswapd: Continue reclaiming for reclaim/compaction if the minimum number of pages have not been reclaimed Mel Gorman 2012-08-07 12:31 ` Mel Gorman 2012-08-07 13:26 ` Rik van Riel 2012-08-07 13:26 ` Rik van Riel 2012-08-08 2:07 ` Minchan Kim 2012-08-08 2:07 ` Minchan Kim 2012-08-08 9:07 ` Mel Gorman 2012-08-08 9:07 ` Mel Gorman 2012-08-08 9:58 ` Mel Gorman 2012-08-08 9:58 ` Mel Gorman 2012-08-07 12:31 ` [PATCH 4/6] mm: compaction: Capture a suitable high-order page immediately when it is made available Mel Gorman 2012-08-07 12:31 ` Mel Gorman 2012-08-07 13:30 ` Rik van Riel 2012-08-07 13:30 ` Rik van Riel 2012-08-07 12:31 ` [PATCH 5/6] mm: have order > 0 compaction start off where it left Mel Gorman 2012-08-07 12:31 ` Mel Gorman 2012-08-07 12:31 ` [PATCH 6/6] mm: have order > 0 compaction start near a pageblock with free pages Mel Gorman 2012-08-07 12:31 ` Mel Gorman 2012-08-07 14:45 ` Rik van Riel 2012-08-07 14:45 ` Rik van Riel 2012-08-07 14:52 ` Mel Gorman 2012-08-07 14:52 ` Mel Gorman 2012-08-07 15:20 ` Jim Schutt 2012-08-07 15:20 ` Jim Schutt 2012-08-07 15:45 ` Mel Gorman 2012-08-07 15:45 ` Mel Gorman 2012-08-08 4:36 ` Minchan Kim 2012-08-08 4:36 ` Minchan Kim 2012-08-08 10:18 ` Mel Gorman 2012-08-08 10:18 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1344342677-5845-2-git-send-email-mgorman@suse.de \ --to=mgorman@suse.de \ --cc=jaschut@sandia.gov \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan@kernel.org \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.