From: Arnd Bergmann <arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org Cc: arm@kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Stefan Roese <sr@denx.de>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org Subject: [PATCH 07/11] net/stmmac: mark probe function as __devinit Date: Wed, 8 Aug 2012 16:47:24 +0200 [thread overview] Message-ID: <1344437248-20560-8-git-send-email-arnd@arndb.de> (raw) In-Reply-To: <1344437248-20560-1-git-send-email-arnd@arndb.de> Driver probe functions are generally __devinit so they will be discarded after initialization for non-hotplug kernels. This was found by a new warning after patch 6a228452d "stmmac: Add device-tree support" adds a new __devinit function that is called from stmmac_pltfr_probe. Without this patch, building socfpga_defconfig results in: WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt() The function stmmac_pltfr_probe() references the function __devinit stmmac_probe_config_dt(). This is often because stmmac_pltfr_probe lacks a __devinit annotation or the annotation of stmmac_probe_config_dt is wrong. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Stefan Roese <sr@denx.de> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> Cc: David S. Miller <davem@davemloft.net> Cc: netdev@vger.kernel.org --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index cd01ee7..b93245c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -74,7 +74,7 @@ static int __devinit stmmac_probe_config_dt(struct platform_device *pdev, * the necessary resources and invokes the main to init * the net device, register the mdio bus etc. */ -static int stmmac_pltfr_probe(struct platform_device *pdev) +static int __devinit stmmac_pltfr_probe(struct platform_device *pdev) { int ret = 0; struct resource *res; -- 1.7.10
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/11] net/stmmac: mark probe function as __devinit Date: Wed, 8 Aug 2012 16:47:24 +0200 [thread overview] Message-ID: <1344437248-20560-8-git-send-email-arnd@arndb.de> (raw) In-Reply-To: <1344437248-20560-1-git-send-email-arnd@arndb.de> Driver probe functions are generally __devinit so they will be discarded after initialization for non-hotplug kernels. This was found by a new warning after patch 6a228452d "stmmac: Add device-tree support" adds a new __devinit function that is called from stmmac_pltfr_probe. Without this patch, building socfpga_defconfig results in: WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt() The function stmmac_pltfr_probe() references the function __devinit stmmac_probe_config_dt(). This is often because stmmac_pltfr_probe lacks a __devinit annotation or the annotation of stmmac_probe_config_dt is wrong. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Stefan Roese <sr@denx.de> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> Cc: David S. Miller <davem@davemloft.net> Cc: netdev at vger.kernel.org --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index cd01ee7..b93245c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -74,7 +74,7 @@ static int __devinit stmmac_probe_config_dt(struct platform_device *pdev, * the necessary resources and invokes the main to init * the net device, register the mdio bus etc. */ -static int stmmac_pltfr_probe(struct platform_device *pdev) +static int __devinit stmmac_pltfr_probe(struct platform_device *pdev) { int ret = 0; struct resource *res; -- 1.7.10
next prev parent reply other threads:[~2012-08-08 14:47 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-08 14:47 [PATCH 00/11] recently added ARM defconfig warnings Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 14:47 ` [PATCH 01/11] ARM: topology: mark init_cpu_topology as __init Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 17:53 ` Stephen Boyd 2012-08-08 17:53 ` Stephen Boyd 2012-08-08 19:14 ` Arnd Bergmann 2012-08-08 19:14 ` Arnd Bergmann 2012-08-08 14:47 ` [PATCH 02/11] mfd/asic3: fix asic3_mfd_probe return value Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 14:47 ` [PATCH 03/11] usb/ohci-omap: remove unused variable Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 15:25 ` Greg Kroah-Hartman 2012-08-08 15:25 ` Greg Kroah-Hartman 2012-08-08 15:34 ` Alan Stern 2012-08-08 15:34 ` Alan Stern 2012-08-08 14:47 ` [PATCH 04/11] ARM: ux500: really kill snowball_of_platform_devs Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 16:22 ` Lee Jones 2012-08-08 16:22 ` Lee Jones 2012-08-08 17:19 ` Arnd Bergmann 2012-08-08 17:19 ` Arnd Bergmann 2012-08-08 14:47 ` [PATCH 05/11] ARM: exynos: exynos_pm_add_dev_to_genpd may be unused Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-10 6:48 ` Kukjin Kim 2012-08-10 6:48 ` Kukjin Kim 2012-08-10 6:57 ` Thomas Abraham 2012-08-10 6:57 ` Thomas Abraham 2012-08-08 14:47 ` [PATCH 06/11] gpio: em: do not discard em_gio_irq_domain_cleanup Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-10 10:59 ` Linus Walleij 2012-08-10 10:59 ` Linus Walleij 2012-08-10 11:33 ` Arnd Bergmann 2012-08-10 11:33 ` Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann [this message] 2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann 2012-08-08 15:07 ` Stefan Roese 2012-08-08 15:07 ` Stefan Roese 2012-08-08 23:08 ` David Miller 2012-08-08 23:08 ` David Miller 2012-08-08 14:47 ` [PATCH 08/11] mtd/omap2: fix dmaengine_slave_config error handling Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 14:47 ` [PATCH 09/11] regulator/twl: remove fixed resource handling Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 14:50 ` Mark Brown 2012-08-08 14:50 ` Mark Brown 2012-08-08 15:06 ` Arnd Bergmann 2012-08-08 15:06 ` Arnd Bergmann 2012-08-08 14:47 ` [PATCH 10/11] spi/s3c64xx: improve error handling Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-10 6:39 ` Kukjin Kim 2012-08-10 6:39 ` Kukjin Kim 2012-08-10 7:34 ` Arnd Bergmann 2012-08-10 7:34 ` Arnd Bergmann 2012-08-10 6:58 ` Thomas Abraham 2012-08-10 6:58 ` Thomas Abraham 2012-08-08 14:47 ` [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS Arnd Bergmann 2012-08-08 14:47 ` Arnd Bergmann 2012-08-08 15:40 ` Stephen Warren 2012-08-08 15:40 ` Stephen Warren 2012-08-08 16:22 ` Arnd Bergmann 2012-08-08 16:22 ` Arnd Bergmann 2012-08-08 16:43 ` Takashi Iwai 2012-08-08 16:43 ` Takashi Iwai 2012-08-08 17:26 ` Arnd Bergmann 2012-08-08 17:26 ` Arnd Bergmann 2012-08-08 19:25 ` Rafael J. Wysocki 2012-08-08 19:25 ` Rafael J. Wysocki 2012-08-20 8:32 ` Herbert Xu 2012-08-20 8:32 ` Herbert Xu 2012-08-08 18:11 ` Kevin Hilman 2012-08-08 18:11 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1344437248-20560-8-git-send-email-arnd@arndb.de \ --to=arnd@arndb.de \ --cc=arm@kernel.org \ --cc=davem@davemloft.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=sr@denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.