From: Arnd Bergmann <arnd@arndb.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org, arm@kernel.org,
linux-kernel@vger.kernel.org,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Jaswinder Singh'" <jaswinder.singh@linaro.org>,
"'Grant Likely'" <grant.likely@secretlab.ca>
Subject: Re: [PATCH 10/11] spi/s3c64xx: improve error handling
Date: Fri, 10 Aug 2012 07:34:46 +0000 [thread overview]
Message-ID: <201208100734.47339.arnd@arndb.de> (raw)
In-Reply-To: <0de501cd76c2$ea07dfd0$be179f70$%kim@samsung.com>
On Friday 10 August 2012, Kukjin Kim wrote:
> BTW for same reason, probably, we need following fix?
>
> arch/arm/mach-tegra/tegra2_emc.c | 4 ++--
> arch/c6x/kernel/setup.c | 2 +-
> arch/powerpc/kernel/ibmebus.c | 2 +-
> arch/powerpc/kernel/pci_of_scan.c | 2 +-
> arch/powerpc/kernel/prom.c | 2 +-
> arch/powerpc/kernel/rtas_pci.c | 2 +-
> arch/powerpc/kernel/vio.c | 2 +-
> arch/powerpc/platforms/44x/warp.c | 2 +-
> ...
Actually not. The difference is that only s3c64xx_get_slave_ctrldata
accesses the node pointer outside of the look (after break).
This fails when there are no child nodes at all. In the other
cases, the only use of the node pointer is inside the loop,
where it is guaranteed to be valid.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] spi/s3c64xx: improve error handling
Date: Fri, 10 Aug 2012 07:34:46 +0000 [thread overview]
Message-ID: <201208100734.47339.arnd@arndb.de> (raw)
In-Reply-To: <0de501cd76c2$ea07dfd0$be179f70$%kim@samsung.com>
On Friday 10 August 2012, Kukjin Kim wrote:
> BTW for same reason, probably, we need following fix?
>
> arch/arm/mach-tegra/tegra2_emc.c | 4 ++--
> arch/c6x/kernel/setup.c | 2 +-
> arch/powerpc/kernel/ibmebus.c | 2 +-
> arch/powerpc/kernel/pci_of_scan.c | 2 +-
> arch/powerpc/kernel/prom.c | 2 +-
> arch/powerpc/kernel/rtas_pci.c | 2 +-
> arch/powerpc/kernel/vio.c | 2 +-
> arch/powerpc/platforms/44x/warp.c | 2 +-
> ...
Actually not. The difference is that only s3c64xx_get_slave_ctrldata
accesses the node pointer outside of the look (after break).
This fails when there are no child nodes at all. In the other
cases, the only use of the node pointer is inside the loop,
where it is guaranteed to be valid.
Arnd
next prev parent reply other threads:[~2012-08-10 7:35 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 14:47 [PATCH 00/11] recently added ARM defconfig warnings Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 01/11] ARM: topology: mark init_cpu_topology as __init Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 17:53 ` Stephen Boyd
2012-08-08 17:53 ` Stephen Boyd
2012-08-08 19:14 ` Arnd Bergmann
2012-08-08 19:14 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 02/11] mfd/asic3: fix asic3_mfd_probe return value Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 03/11] usb/ohci-omap: remove unused variable Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 15:25 ` Greg Kroah-Hartman
2012-08-08 15:25 ` Greg Kroah-Hartman
2012-08-08 15:34 ` Alan Stern
2012-08-08 15:34 ` Alan Stern
2012-08-08 14:47 ` [PATCH 04/11] ARM: ux500: really kill snowball_of_platform_devs Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 16:22 ` Lee Jones
2012-08-08 16:22 ` Lee Jones
2012-08-08 17:19 ` Arnd Bergmann
2012-08-08 17:19 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 05/11] ARM: exynos: exynos_pm_add_dev_to_genpd may be unused Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-10 6:48 ` Kukjin Kim
2012-08-10 6:48 ` Kukjin Kim
2012-08-10 6:57 ` Thomas Abraham
2012-08-10 6:57 ` Thomas Abraham
2012-08-08 14:47 ` [PATCH 06/11] gpio: em: do not discard em_gio_irq_domain_cleanup Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-10 10:59 ` Linus Walleij
2012-08-10 10:59 ` Linus Walleij
2012-08-10 11:33 ` Arnd Bergmann
2012-08-10 11:33 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 15:07 ` Stefan Roese
2012-08-08 15:07 ` Stefan Roese
2012-08-08 23:08 ` David Miller
2012-08-08 23:08 ` David Miller
2012-08-08 14:47 ` [PATCH 08/11] mtd/omap2: fix dmaengine_slave_config error handling Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 09/11] regulator/twl: remove fixed resource handling Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 14:50 ` Mark Brown
2012-08-08 14:50 ` Mark Brown
2012-08-08 15:06 ` Arnd Bergmann
2012-08-08 15:06 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 10/11] spi/s3c64xx: improve error handling Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-10 6:39 ` Kukjin Kim
2012-08-10 6:39 ` Kukjin Kim
2012-08-10 7:34 ` Arnd Bergmann [this message]
2012-08-10 7:34 ` Arnd Bergmann
2012-08-10 6:58 ` Thomas Abraham
2012-08-10 6:58 ` Thomas Abraham
2012-08-08 14:47 ` [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS Arnd Bergmann
2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 15:40 ` Stephen Warren
2012-08-08 15:40 ` Stephen Warren
2012-08-08 16:22 ` Arnd Bergmann
2012-08-08 16:22 ` Arnd Bergmann
2012-08-08 16:43 ` Takashi Iwai
2012-08-08 16:43 ` Takashi Iwai
2012-08-08 17:26 ` Arnd Bergmann
2012-08-08 17:26 ` Arnd Bergmann
2012-08-08 19:25 ` Rafael J. Wysocki
2012-08-08 19:25 ` Rafael J. Wysocki
2012-08-20 8:32 ` Herbert Xu
2012-08-20 8:32 ` Herbert Xu
2012-08-08 18:11 ` Kevin Hilman
2012-08-08 18:11 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208100734.47339.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=jaswinder.singh@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.