From: Eduardo Valentin <eduardo.valentin@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
Eduardo Valentin <eduardo.valentin@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Vaibhav Bedia <vaibhav.bedia@ti.com>
Subject: [PATCH 45/50] staging: omap-thermal: change Kconfig dependency method
Date: Fri, 15 Mar 2013 09:00:33 -0400 [thread overview]
Message-ID: <1363352438-15935-46-git-send-email-eduardo.valentin@ti.com> (raw)
In-Reply-To: <1363352438-15935-1-git-send-email-eduardo.valentin@ti.com>
Now arch code has to specify CONFIG_ARCH_HAS_BANDGAP. So, this driver
will be selectable only if the platform reports itself as having a
bandgap device.
Any OMAP variant or any other OMAP version needs to
select ARCH_HAS_BANDGAP
so that the driver will be applicable. A part from that it is
required to device the data structures that maps the registers
and their bitfields. The DT compatible list must also be updated.
CC: Santosh Shilimkar <santosh.shilimkar@ti.com>
CC: Vaibhav Bedia <vaibhav.bedia@ti.com>
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
drivers/staging/omap-thermal/Kconfig | 2 +-
drivers/staging/omap-thermal/TODO | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/omap-thermal/Kconfig b/drivers/staging/omap-thermal/Kconfig
index 30cbc3b..52170bf 100644
--- a/drivers/staging/omap-thermal/Kconfig
+++ b/drivers/staging/omap-thermal/Kconfig
@@ -1,7 +1,7 @@
config OMAP_BANDGAP
tristate "Texas Instruments OMAP4+ temperature sensor driver"
depends on THERMAL
- depends on ARCH_OMAP4 || SOC_OMAP5
+ depends on ARCH_HAS_BANDGAP
help
If you say yes here you get support for the Texas Instruments
OMAP4460+ on die bandgap temperature sensor support. The register
diff --git a/drivers/staging/omap-thermal/TODO b/drivers/staging/omap-thermal/TODO
index 9e23cc4..77b761b 100644
--- a/drivers/staging/omap-thermal/TODO
+++ b/drivers/staging/omap-thermal/TODO
@@ -20,7 +20,6 @@ on omap5-thermal.c
- Add support for GPU cooling
generally:
-- write Kconfig dependencies so that omap variants are covered
- make checkpatch.pl and sparse happy
- make sure this code works on OMAP4430, OMAP4460 and OMAP5430
- update documentation
--
1.7.7.1.488.ge8e1c
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Eduardo Valentin <eduardo.valentin@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Vaibhav Bedia <vaibhav.bedia@ti.com>
Subject: [PATCH 45/50] staging: omap-thermal: change Kconfig dependency method
Date: Fri, 15 Mar 2013 09:00:33 -0400 [thread overview]
Message-ID: <1363352438-15935-46-git-send-email-eduardo.valentin@ti.com> (raw)
In-Reply-To: <1363352438-15935-1-git-send-email-eduardo.valentin@ti.com>
Now arch code has to specify CONFIG_ARCH_HAS_BANDGAP. So, this driver
will be selectable only if the platform reports itself as having a
bandgap device.
Any OMAP variant or any other OMAP version needs to
select ARCH_HAS_BANDGAP
so that the driver will be applicable. A part from that it is
required to device the data structures that maps the registers
and their bitfields. The DT compatible list must also be updated.
CC: Santosh Shilimkar <santosh.shilimkar@ti.com>
CC: Vaibhav Bedia <vaibhav.bedia@ti.com>
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
drivers/staging/omap-thermal/Kconfig | 2 +-
drivers/staging/omap-thermal/TODO | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/omap-thermal/Kconfig b/drivers/staging/omap-thermal/Kconfig
index 30cbc3b..52170bf 100644
--- a/drivers/staging/omap-thermal/Kconfig
+++ b/drivers/staging/omap-thermal/Kconfig
@@ -1,7 +1,7 @@
config OMAP_BANDGAP
tristate "Texas Instruments OMAP4+ temperature sensor driver"
depends on THERMAL
- depends on ARCH_OMAP4 || SOC_OMAP5
+ depends on ARCH_HAS_BANDGAP
help
If you say yes here you get support for the Texas Instruments
OMAP4460+ on die bandgap temperature sensor support. The register
diff --git a/drivers/staging/omap-thermal/TODO b/drivers/staging/omap-thermal/TODO
index 9e23cc4..77b761b 100644
--- a/drivers/staging/omap-thermal/TODO
+++ b/drivers/staging/omap-thermal/TODO
@@ -20,7 +20,6 @@ on omap5-thermal.c
- Add support for GPU cooling
generally:
-- write Kconfig dependencies so that omap variants are covered
- make checkpatch.pl and sparse happy
- make sure this code works on OMAP4430, OMAP4460 and OMAP5430
- update documentation
--
1.7.7.1.488.ge8e1c
next prev parent reply other threads:[~2013-03-15 13:17 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 12:59 [PATCH 00/50] staging: omap-thermal: several code refactoring Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 01/50] staging: omap-thermal: use BIT() macro Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 02/50] staging: omap-thermal: remove unused _SHIFT macros Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 03/50] staging: omap-thermal: create header for register, bitfields and definitions Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 04/50] staging: omap-thermal: update documentation of omap-bandgap.h Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 05/50] staging: omap-thermal: style cleanup on omap-bandgap.c Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 06/50] staging: omap-thermal: fix error checking Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 21:09 ` Dan Carpenter
2013-03-16 12:36 ` Eduardo Valentin
2013-03-16 12:36 ` Eduardo Valentin
2013-03-16 14:00 ` Dan Carpenter
2013-03-15 12:59 ` [PATCH 08/50] staging: omap-thermal: add documentation for register access functions Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 21:22 ` Dan Carpenter
2013-03-16 12:39 ` Eduardo Valentin
2013-03-16 12:39 ` Eduardo Valentin
2013-03-16 13:56 ` Dan Carpenter
2013-03-15 12:59 ` [PATCH 10/50] staging: omap-thermal: add documentation for omap_bandgap_power Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 11/50] staging: omap-thermal: add documentation for omap_bandgap_read_temp Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 12/50] staging: omap-thermal: rename talert handler Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 13/50] staging: omap-thermal: update documentation for talert irq handler Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 14/50] staging: omap-thermal: update tshut IRQ handler documentation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 15/50] staging: omap-thermal: remove duplicated code Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 16/50] staging: omap-thermal: read status only once inside alert IRQ Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 17/50] staging: omap-thermal: add a section of register manipulation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 18/50] staging: omap-thermal: section of basic helpers Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 19/50] staging: omap-thermal: IRQ handler section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 20/50] staging: omap-thermal: ADC section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 21/50] staging: omap-thermal: name adc_to_temp_conversion in a better way Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 22/50] staging: omap-thermal: rewrite omap_bandgap_adc_to_mcelsius on kernel coding style Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:27 ` Dan Carpenter
2013-03-16 8:27 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 23/50] staging: omap-thermal: add documentation for omap_bandgap_adc_to_mcelsius Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 24/50] staging: omap-thermal: name temp_to_adc_conversion in a better way Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 25/50] staging: omap-thermal: rewrite omap_bandgap_mcelsius_to_adc on kernel coding style Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:33 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 26/50] staging: omap-thermal: move conv table limits out of sensor data Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 27/50] staging: omap-thermal: add documentation for omap_bandgap_mcelsius_to_adc Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 28/50] staging: omap-thermal: rename add_hyst to omap_bandgap_add_hyst Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 29/50] staging: omap-thermal: document omap_bandgap_add_hyst function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 30/50] staging: omap-thermal: threshold manipulation section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 31/50] staging: omap-thermal: refactor temp_sensor_unmask_interrupts Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 32/50] staging: omap-thermal: update omap_bandgap_unmask_interrupts documentation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:39 ` Dan Carpenter
2013-03-16 12:49 ` Eduardo Valentin
2013-03-16 12:49 ` Eduardo Valentin
2013-03-16 13:58 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 34/50] staging: omap-thermal: device initialization section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 35/50] staging: omap-thermal: section of device driver callbacks Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 36/50] staging: omap-thermal: rename enable_continuous_mode Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 37/50] staging: omap-thermal: update omap_bandgap_set_continous_mode documentation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 38/50] staging: omap-thermal: document omap_bandgap_force_single_read Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 39/50] staging: omap-thermal: document omap_bandgap_update_alert_threshold function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 40/50] staging: omap-thermal: document _omap_bandgap_write_threshold function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 41/50] staging: omap-thermal: document _omap_bandgap_read_threshold function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 42/50] staging: omap-thermal: document omap_bandgap_tshut_init function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 43/50] staging: omap-thermal: document omap_bandgap_alert_init function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 44/50] staging: omap-thermal: document omap_bandgap_build function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin [this message]
2013-03-15 13:00 ` [PATCH 45/50] staging: omap-thermal: change Kconfig dependency method Eduardo Valentin
2013-03-15 13:00 ` [PATCH 46/50] staging: Add a MAINTAINERS entry for TI bandgap and thermal driver Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:59 ` Dan Carpenter
2013-03-16 8:59 ` Dan Carpenter
2013-03-16 12:41 ` Eduardo Valentin
2013-03-16 12:41 ` Eduardo Valentin
2013-03-16 14:22 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 48/50] staging: omap-thermal: remove TODO entry suggesting regmap usage Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 49/50] staging: omap-thermal: remove TODO entry for exposed APIs Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 50/50] staging: omap-thermal: add documentation for omap_bandgap_validate Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 9:05 ` [PATCH 00/50] staging: omap-thermal: several code refactoring Dan Carpenter
2013-03-16 12:46 ` Eduardo Valentin
2013-03-16 12:46 ` Eduardo Valentin
2013-03-16 16:16 ` Greg KH
2013-03-18 14:44 ` Eduardo Valentin
2013-03-18 14:44 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363352438-15935-46-git-send-email-eduardo.valentin@ti.com \
--to=eduardo.valentin@ti.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.