From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
<devel@driverdev.osuosl.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
Date: Mon, 18 Mar 2013 10:44:59 -0400 [thread overview]
Message-ID: <5147286B.9090705@ti.com> (raw)
In-Reply-To: <20130316161641.GA2630@kroah.com>
Greg, Dan,
On 16-03-2013 12:16, Greg KH wrote:
> On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote:
>> Hello Dan,
>>
>> On 16-03-2013 05:05, Dan Carpenter wrote:
>>> I've reviewed this set.
>>>
>>> I hate to make people redo whole patchset sets, and I hate
>>> re-reviewing code. Obviously, I don't really like the bunny hop
>>> patches and I'm trying to discourage that going forward. ;P But
>>> I wouldn't say it's a "Redo the whole thing" kind of problem.
>>>
>>> Could just resend patch 33 and 47? You should probably be able to
>>> redo those without changing the rest.
>>
>> I could of course change them if the comment is better clarified. As
>> I mentioned as reply to one of your comments, those changes are
>> following what is suggested in CodingStyle file.
>>
>> I can of course send a diff on top of 33, to fix the introduce bug.
>>
>> For 47, I'm not sure the comment is fully applicable.
>
> As I've taken all of these already (sorry Dan, I was fast and I didn't
> review them as well as you did), you will have to just send incremental
> patches on top of the whole series in order for me to be able to apply
> them.
No issues here, I am going to send soon incremental patches, copying
Dan, to fix the above mentioned issues on 33 and 47.
>
> thanks,
>
> greg k-h
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
Date: Mon, 18 Mar 2013 10:44:59 -0400 [thread overview]
Message-ID: <5147286B.9090705@ti.com> (raw)
In-Reply-To: <20130316161641.GA2630@kroah.com>
Greg, Dan,
On 16-03-2013 12:16, Greg KH wrote:
> On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote:
>> Hello Dan,
>>
>> On 16-03-2013 05:05, Dan Carpenter wrote:
>>> I've reviewed this set.
>>>
>>> I hate to make people redo whole patchset sets, and I hate
>>> re-reviewing code. Obviously, I don't really like the bunny hop
>>> patches and I'm trying to discourage that going forward. ;P But
>>> I wouldn't say it's a "Redo the whole thing" kind of problem.
>>>
>>> Could just resend patch 33 and 47? You should probably be able to
>>> redo those without changing the rest.
>>
>> I could of course change them if the comment is better clarified. As
>> I mentioned as reply to one of your comments, those changes are
>> following what is suggested in CodingStyle file.
>>
>> I can of course send a diff on top of 33, to fix the introduce bug.
>>
>> For 47, I'm not sure the comment is fully applicable.
>
> As I've taken all of these already (sorry Dan, I was fast and I didn't
> review them as well as you did), you will have to just send incremental
> patches on top of the whole series in order for me to be able to apply
> them.
No issues here, I am going to send soon incremental patches, copying
Dan, to fix the above mentioned issues on 33 and 47.
>
> thanks,
>
> greg k-h
>
>
next prev parent reply other threads:[~2013-03-18 14:45 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 12:59 [PATCH 00/50] staging: omap-thermal: several code refactoring Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 01/50] staging: omap-thermal: use BIT() macro Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 02/50] staging: omap-thermal: remove unused _SHIFT macros Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 03/50] staging: omap-thermal: create header for register, bitfields and definitions Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 04/50] staging: omap-thermal: update documentation of omap-bandgap.h Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 05/50] staging: omap-thermal: style cleanup on omap-bandgap.c Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 06/50] staging: omap-thermal: fix error checking Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 21:09 ` Dan Carpenter
2013-03-16 12:36 ` Eduardo Valentin
2013-03-16 12:36 ` Eduardo Valentin
2013-03-16 14:00 ` Dan Carpenter
2013-03-15 12:59 ` [PATCH 08/50] staging: omap-thermal: add documentation for register access functions Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 21:22 ` Dan Carpenter
2013-03-16 12:39 ` Eduardo Valentin
2013-03-16 12:39 ` Eduardo Valentin
2013-03-16 13:56 ` Dan Carpenter
2013-03-15 12:59 ` [PATCH 10/50] staging: omap-thermal: add documentation for omap_bandgap_power Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 12:59 ` [PATCH 11/50] staging: omap-thermal: add documentation for omap_bandgap_read_temp Eduardo Valentin
2013-03-15 12:59 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 12/50] staging: omap-thermal: rename talert handler Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 13/50] staging: omap-thermal: update documentation for talert irq handler Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 14/50] staging: omap-thermal: update tshut IRQ handler documentation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 15/50] staging: omap-thermal: remove duplicated code Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 16/50] staging: omap-thermal: read status only once inside alert IRQ Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 17/50] staging: omap-thermal: add a section of register manipulation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 18/50] staging: omap-thermal: section of basic helpers Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 19/50] staging: omap-thermal: IRQ handler section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 20/50] staging: omap-thermal: ADC section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 21/50] staging: omap-thermal: name adc_to_temp_conversion in a better way Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 22/50] staging: omap-thermal: rewrite omap_bandgap_adc_to_mcelsius on kernel coding style Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:27 ` Dan Carpenter
2013-03-16 8:27 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 23/50] staging: omap-thermal: add documentation for omap_bandgap_adc_to_mcelsius Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 24/50] staging: omap-thermal: name temp_to_adc_conversion in a better way Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 25/50] staging: omap-thermal: rewrite omap_bandgap_mcelsius_to_adc on kernel coding style Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:33 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 26/50] staging: omap-thermal: move conv table limits out of sensor data Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 27/50] staging: omap-thermal: add documentation for omap_bandgap_mcelsius_to_adc Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 28/50] staging: omap-thermal: rename add_hyst to omap_bandgap_add_hyst Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 29/50] staging: omap-thermal: document omap_bandgap_add_hyst function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 30/50] staging: omap-thermal: threshold manipulation section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 31/50] staging: omap-thermal: refactor temp_sensor_unmask_interrupts Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 32/50] staging: omap-thermal: update omap_bandgap_unmask_interrupts documentation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:39 ` Dan Carpenter
2013-03-16 12:49 ` Eduardo Valentin
2013-03-16 12:49 ` Eduardo Valentin
2013-03-16 13:58 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 34/50] staging: omap-thermal: device initialization section Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 35/50] staging: omap-thermal: section of device driver callbacks Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 36/50] staging: omap-thermal: rename enable_continuous_mode Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 37/50] staging: omap-thermal: update omap_bandgap_set_continous_mode documentation Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 38/50] staging: omap-thermal: document omap_bandgap_force_single_read Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 39/50] staging: omap-thermal: document omap_bandgap_update_alert_threshold function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 40/50] staging: omap-thermal: document _omap_bandgap_write_threshold function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 41/50] staging: omap-thermal: document _omap_bandgap_read_threshold function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 42/50] staging: omap-thermal: document omap_bandgap_tshut_init function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 43/50] staging: omap-thermal: document omap_bandgap_alert_init function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 44/50] staging: omap-thermal: document omap_bandgap_build function Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 45/50] staging: omap-thermal: change Kconfig dependency method Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 46/50] staging: Add a MAINTAINERS entry for TI bandgap and thermal driver Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 8:59 ` Dan Carpenter
2013-03-16 8:59 ` Dan Carpenter
2013-03-16 12:41 ` Eduardo Valentin
2013-03-16 12:41 ` Eduardo Valentin
2013-03-16 14:22 ` Dan Carpenter
2013-03-15 13:00 ` [PATCH 48/50] staging: omap-thermal: remove TODO entry suggesting regmap usage Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 49/50] staging: omap-thermal: remove TODO entry for exposed APIs Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-15 13:00 ` [PATCH 50/50] staging: omap-thermal: add documentation for omap_bandgap_validate Eduardo Valentin
2013-03-15 13:00 ` Eduardo Valentin
2013-03-16 9:05 ` [PATCH 00/50] staging: omap-thermal: several code refactoring Dan Carpenter
2013-03-16 12:46 ` Eduardo Valentin
2013-03-16 12:46 ` Eduardo Valentin
2013-03-16 16:16 ` Greg KH
2013-03-18 14:44 ` Eduardo Valentin [this message]
2013-03-18 14:44 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5147286B.9090705@ti.com \
--to=eduardo.valentin@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.