[PATCH bluez] attrib: Fix interactive gatttool segfault

[PATCH bluez] attrib: Fix interactive gatttool segfault

[Sathish N]

From: sathish N <sathish.n@globaledgesoft.com>

---
 bluez/attrib/interactive.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bluez/attrib/interactive.c b/bluez/attrib/interactive.c
index f28dc22..4fd7276 100644
--- a/bluez/attrib/interactive.c
+++ b/bluez/attrib/interactive.c
@@ -867,7 +867,8 @@ static void parse_line(char *line_read)
 
 	add_history(line_read);
 
-	g_shell_parse_argv(line_read, &argcp, &argvp, NULL);
+	if (g_shell_parse_argv(line_read, &argcp, &argvp, NULL) == FALSE)
+		goto done;
 
 	for (i = 0; commands[i].cmd; i++)
 		if (strcasecmp(commands[i].cmd, argvp[0]) == 0)
-- 
1.7.9.5

Re: [PATCH bluez] attrib: Fix interactive gatttool segfault

[Johan Hedberg]

Hi Satish,

On Thu, Jul 18, 2013, Sathish N wrote:
> From: sathish N <sathish.n@globaledgesoft.com>

Since this seems to be your first submission let me confirm these git
author details: is this really how you want your author name to be, i.e.
with a lower case "s" and just "N" as your surname? At least in your
email "From" header your name was with a capital "S".

> ---
>  bluez/attrib/interactive.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

There seems to be something strange with your tree that generates this
extra bluez/* path component. It makes "git am" fail to apply this
patch:

Applying: attrib: Fix interactive gatttool segfault
error: bluez/attrib/interactive.c: does not exist in index
Patch failed at 0001 attrib: Fix interactive gatttool segfault

Besides the above issues the actual change to the code itself looks fine
to me.

Johan

Re: [PATCH bluez] attrib: Fix interactive gatttool segfault

[Sathish N]

Hi johan,

Yes it is my first submission. The full name is Sathish Narasimman.
solved the "git am" error and the patch is resubmitted(extra bluez/* 
directory removed).

Thanks,
Sathish Narasimman

On Thursday 18 July 2013 04:46 PM, Johan Hedberg wrote:
> Hi Satish,
>
> On Thu, Jul 18, 2013, Sathish N wrote:
>> From: sathish N <sathish.n@globaledgesoft.com>
> Since this seems to be your first submission let me confirm these git
> author details: is this really how you want your author name to be, i.e.
> with a lower case "s" and just "N" as your surname? At least in your
> email "From" header your name was with a capital "S".
>
>> ---
>>   bluez/attrib/interactive.c |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
> There seems to be something strange with your tree that generates this
> extra bluez/* path component. It makes "git am" fail to apply this
> patch:
>
> Applying: attrib: Fix interactive gatttool segfault
> error: bluez/attrib/interactive.c: does not exist in index
> Patch failed at 0001 attrib: Fix interactive gatttool segfault
>
> Besides the above issues the actual change to the code itself looks fine
> to me.
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[PATCH BlueZ] attrib: Fix interactive gatttool Segfault

[Sathish Narasimman]

From: Sathish N <sathish.n@globaledgesoft.com>

passing the special character single quote

$gatttool -I
[   ][                 ][LE]> '
Segmentation fault (core dumped)

Checking g_shell_parse_argv fail status(return FALSE on failure), works fine.

hope the fix to the previous "git am" error is solved

---
 attrib/interactive.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/attrib/interactive.c b/attrib/interactive.c
index f28dc22..df5dc52 100644
--- a/attrib/interactive.c
+++ b/attrib/interactive.c
@@ -867,7 +867,8 @@ static void parse_line(char *line_read)
 
 	add_history(line_read);
 
-	g_shell_parse_argv(line_read, &argcp, &argvp, NULL);
+	if (g_shell_parse_argv(line_read, &argcp, &argvp, NULL) = FALSE)
+		goto done;
 
 	for (i = 0; commands[i].cmd; i++)
 		if (strcasecmp(commands[i].cmd, argvp[0]) == 0)
-- 
1.7.9.5

[PATCH BlueZ] attrib: Fix interactive gatttool segfault

[Sathish Narasimman]

passing the special character single quote

$gatttool -I
[   ][                 ][LE]> '
Segmentation fault (core dumped)

Checking g_shell_parse_argv fail status(return FALSE on failure), works fine.

hope the fix to the previous "git am" error is solved

---
 attrib/interactive.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/attrib/interactive.c b/attrib/interactive.c
index f28dc22..4fd7276 100644
--- a/attrib/interactive.c
+++ b/attrib/interactive.c
@@ -867,7 +867,8 @@ static void parse_line(char *line_read)
 
 	add_history(line_read);
 
-	g_shell_parse_argv(line_read, &argcp, &argvp, NULL);
+	if (g_shell_parse_argv(line_read, &argcp, &argvp, NULL) == FALSE)
+		goto done;
 
 	for (i = 0; commands[i].cmd; i++)
 		if (strcasecmp(commands[i].cmd, argvp[0]) == 0)
-- 
1.7.9.5

Re: [PATCH BlueZ] attrib: Fix interactive gatttool segfault

[Anderson Lizardo]

Hi Sathish,

On Fri, Jul 19, 2013 at 12:31 AM, Sathish Narasimman
<sathish.n@globaledgesoft.com> wrote:
> passing the special character single quote
>
> $gatttool -I
> [   ][                 ][LE]> '
> Segmentation fault (core dumped)
>
> Checking g_shell_parse_argv fail status(return FALSE on failure), works fine.
>
> hope the fix to the previous "git am" error is solved

"git am" on this patch worked here. But one small note (for future
patches; I think there is no need to resend this one as it is easily
fixed locally): if you need to put a comment like the above that you
don't want to appear on the GIT commit message, you should put it
after "---" so it is ignored by "git am". They way I do this is use
"git format-patch" to generate a *.patch file, then I edit this file
to add the note after the "---" and send the patch using git send-mail
<file>.patch.

Best Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Re: [PATCH BlueZ] attrib: Fix interactive gatttool segfault

[Johan Hedberg]

Hi Satish,

On Fri, Jul 19, 2013, Sathish Narasimman wrote:
> passing the special character single quote
> 
> $gatttool -I
> [   ][                 ][LE]> '
> Segmentation fault (core dumped)
> 
> Checking g_shell_parse_argv fail status(return FALSE on failure), works fine.
> 
> hope the fix to the previous "git am" error is solved
> 
> ---
>  attrib/interactive.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

The patch has now been applied (after manually removing the last comment
that doesn't belong in the commit message). Thanks.

Johan