From: Julia Lawall <Julia.Lawall@lip6.fr> To: James Smart <james.smart@emulex.com> Cc: kernel-janitors@vger.kernel.org, "James E.J. Bottomley" <JBottomley@parallels.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers/scsi/lpfc/lpfc_init.c: adjust code alignment Date: Mon, 5 Aug 2013 16:47:37 +0200 [thread overview] Message-ID: <1375714059-29567-3-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1375714059-29567-1-git-send-email-Julia.Lawall@lip6.fr> From: Julia Lawall <Julia.Lawall@lip6.fr> Adjust code alignment so that each statement is lined up with its neighbor. In the second case, it could be desirable to put the call to lpfc_destroy_vport_work_array under the if. The call, is, however, safe in case vports is NULL, so the patch just adjusts the indentation to reflect the current semantics. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index e0b20fa..f870421 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -692,7 +692,7 @@ lpfc_hba_init_link_fc_topology(struct lpfc_hba *phba, uint32_t fc_topology, "1302 Invalid speed for this board:%d " "Reset link speed to auto.\n", phba->cfg_link_speed); - phba->cfg_link_speed = LPFC_USER_LINK_SPEED_AUTO; + phba->cfg_link_speed = LPFC_USER_LINK_SPEED_AUTO; } lpfc_init_link(phba, pmb, fc_topology, phba->cfg_link_speed); pmb->mbox_cmpl = lpfc_sli_def_mbox_cmpl; @@ -2702,7 +2702,7 @@ lpfc_online(struct lpfc_hba *phba) } spin_unlock_irq(shost->host_lock); } - lpfc_destroy_vport_work_array(phba, vports); + lpfc_destroy_vport_work_array(phba, vports); lpfc_unblock_mgmt_io(phba); return 0;
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr> To: James Smart <james.smart@emulex.com> Cc: kernel-janitors@vger.kernel.org, "James E.J. Bottomley" <JBottomley@parallels.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers/scsi/lpfc/lpfc_init.c: adjust code alignment Date: Mon, 05 Aug 2013 14:47:37 +0000 [thread overview] Message-ID: <1375714059-29567-3-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1375714059-29567-1-git-send-email-Julia.Lawall@lip6.fr> From: Julia Lawall <Julia.Lawall@lip6.fr> Adjust code alignment so that each statement is lined up with its neighbor. In the second case, it could be desirable to put the call to lpfc_destroy_vport_work_array under the if. The call, is, however, safe in case vports is NULL, so the patch just adjusts the indentation to reflect the current semantics. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index e0b20fa..f870421 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -692,7 +692,7 @@ lpfc_hba_init_link_fc_topology(struct lpfc_hba *phba, uint32_t fc_topology, "1302 Invalid speed for this board:%d " "Reset link speed to auto.\n", phba->cfg_link_speed); - phba->cfg_link_speed = LPFC_USER_LINK_SPEED_AUTO; + phba->cfg_link_speed = LPFC_USER_LINK_SPEED_AUTO; } lpfc_init_link(phba, pmb, fc_topology, phba->cfg_link_speed); pmb->mbox_cmpl = lpfc_sli_def_mbox_cmpl; @@ -2702,7 +2702,7 @@ lpfc_online(struct lpfc_hba *phba) } spin_unlock_irq(shost->host_lock); } - lpfc_destroy_vport_work_array(phba, vports); + lpfc_destroy_vport_work_array(phba, vports); lpfc_unblock_mgmt_io(phba); return 0;
next prev parent reply other threads:[~2013-08-05 14:47 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-05 14:47 [PATCH] adjust code alignment Julia Lawall 2013-08-05 14:47 ` Julia Lawall 2013-08-05 14:47 ` [PATCH] fs/nfs/inode.c: " Julia Lawall 2013-08-05 14:47 ` Julia Lawall 2013-08-05 14:59 ` Myklebust, Trond 2013-08-05 14:59 ` Myklebust, Trond 2013-08-05 14:59 ` Myklebust, Trond 2013-08-06 18:04 ` Steve Dickson 2013-08-06 18:04 ` Steve Dickson 2013-08-07 1:58 ` Dave Quigley 2013-08-07 1:58 ` Dave Quigley 2013-08-05 14:47 ` Julia Lawall [this message] 2013-08-05 14:47 ` [PATCH] drivers/scsi/lpfc/lpfc_init.c: " Julia Lawall 2013-08-05 14:47 ` [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon Julia Lawall 2013-08-05 14:47 ` Julia Lawall 2013-08-05 18:08 ` David Miller 2013-08-05 18:08 ` David Miller 2013-08-05 14:47 ` [PATCH] trivial: adjust code alignment Julia Lawall 2013-08-05 14:47 ` Julia Lawall 2013-08-05 16:06 ` Dan Carpenter 2013-08-05 16:06 ` Dan Carpenter 2013-08-05 16:17 ` Joe Perches 2013-08-05 16:17 ` Joe Perches 2013-08-05 16:30 ` Dan Carpenter 2013-08-05 16:30 ` Dan Carpenter 2013-08-06 0:51 ` Joe Perches 2013-08-06 0:51 ` Joe Perches 2013-08-05 16:19 ` Julia Lawall 2013-08-05 16:19 ` Julia Lawall 2013-08-05 16:24 ` walter harms 2013-08-05 16:24 ` walter harms 2013-08-05 16:28 ` Julia Lawall 2013-08-05 16:28 ` Julia Lawall 2013-08-05 17:05 ` Dan Carpenter 2013-08-05 17:05 ` Dan Carpenter 2013-08-05 16:52 ` Jonathan Corbet 2013-08-05 16:52 ` Jonathan Corbet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1375714059-29567-3-git-send-email-Julia.Lawall@lip6.fr \ --to=julia.lawall@lip6.fr \ --cc=JBottomley@parallels.com \ --cc=james.smart@emulex.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.