All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
	trivial@kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: adjust code alignment
Date: Mon, 05 Aug 2013 17:51:09 -0700	[thread overview]
Message-ID: <1375750269.1968.18.camel@joe-AO722> (raw)
In-Reply-To: <20130805163054.GN5102@mwanda>

On Mon, 2013-08-05 at 19:30 +0300, Dan Carpenter wrote:
> On Mon, Aug 05, 2013 at 09:17:07AM -0700, Joe Perches wrote:
> > ov7670_read via i2c_transfer can return a positive # too.
> > Perhaps all of these should be individually tested for "< 0".
> You're misreading something.  ov7670_read_i2c() only returns zero
> and negative error codes.

Yup, right, thanks, I skimmed over the

	if (ret >= 0) {
		...
		ret = 0;
	}

bit in ov7670_read_i2c

though I think this function via the i2c_transfer
can return 0 messages transferred as "success".



WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
	trivial@kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: adjust code alignment
Date: Tue, 06 Aug 2013 00:51:09 +0000	[thread overview]
Message-ID: <1375750269.1968.18.camel@joe-AO722> (raw)
In-Reply-To: <20130805163054.GN5102@mwanda>

On Mon, 2013-08-05 at 19:30 +0300, Dan Carpenter wrote:
> On Mon, Aug 05, 2013 at 09:17:07AM -0700, Joe Perches wrote:
> > ov7670_read via i2c_transfer can return a positive # too.
> > Perhaps all of these should be individually tested for "< 0".
> You're misreading something.  ov7670_read_i2c() only returns zero
> and negative error codes.

Yup, right, thanks, I skimmed over the

	if (ret >= 0) {
		...
		ret = 0;
	}

bit in ov7670_read_i2c

though I think this function via the i2c_transfer
can return 0 messages transferred as "success".



  reply	other threads:[~2013-08-06  0:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 14:47 [PATCH] adjust code alignment Julia Lawall
2013-08-05 14:47 ` Julia Lawall
2013-08-05 14:47 ` [PATCH] fs/nfs/inode.c: " Julia Lawall
2013-08-05 14:47   ` Julia Lawall
2013-08-05 14:59   ` Myklebust, Trond
2013-08-05 14:59     ` Myklebust, Trond
2013-08-05 14:59     ` Myklebust, Trond
2013-08-06 18:04     ` Steve Dickson
2013-08-06 18:04       ` Steve Dickson
2013-08-07  1:58       ` Dave Quigley
2013-08-07  1:58         ` Dave Quigley
2013-08-05 14:47 ` [PATCH] drivers/scsi/lpfc/lpfc_init.c: " Julia Lawall
2013-08-05 14:47   ` Julia Lawall
2013-08-05 14:47 ` [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon Julia Lawall
2013-08-05 14:47   ` Julia Lawall
2013-08-05 18:08   ` David Miller
2013-08-05 18:08     ` David Miller
2013-08-05 14:47 ` [PATCH] trivial: adjust code alignment Julia Lawall
2013-08-05 14:47   ` Julia Lawall
2013-08-05 16:06   ` Dan Carpenter
2013-08-05 16:06     ` Dan Carpenter
2013-08-05 16:17     ` Joe Perches
2013-08-05 16:17       ` Joe Perches
2013-08-05 16:30       ` Dan Carpenter
2013-08-05 16:30         ` Dan Carpenter
2013-08-06  0:51         ` Joe Perches [this message]
2013-08-06  0:51           ` Joe Perches
2013-08-05 16:19     ` Julia Lawall
2013-08-05 16:19       ` Julia Lawall
2013-08-05 16:24       ` walter harms
2013-08-05 16:24         ` walter harms
2013-08-05 16:28         ` Julia Lawall
2013-08-05 16:28           ` Julia Lawall
2013-08-05 17:05         ` Dan Carpenter
2013-08-05 17:05           ` Dan Carpenter
2013-08-05 16:52       ` Jonathan Corbet
2013-08-05 16:52         ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375750269.1968.18.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.