From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
trivial@kernel.org, kernel-janitors@vger.kernel.org,
corbet@lwn.net, m.chehab@samsung.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: adjust code alignment
Date: Mon, 5 Aug 2013 20:05:45 +0300 [thread overview]
Message-ID: <20130805170544.GO5102@mwanda> (raw)
In-Reply-To: <51FFD1CB.4080907@bfs.de>
On Mon, Aug 05, 2013 at 06:24:43PM +0200, walter harms wrote:
> Hello Julia,
>
> IMHO keep the patch as it is.
> It does not change any code that is good.
> Suspicious code that comes up here can be addressed
> in a separate patch.
>
Gar... No, if we silence static checker warnings without fixing the
bug then we are hiding real problems and making them more difficult
to find.
Just drop this chunk.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
trivial@kernel.org, kernel-janitors@vger.kernel.org,
corbet@lwn.net, m.chehab@samsung.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: adjust code alignment
Date: Mon, 05 Aug 2013 17:05:45 +0000 [thread overview]
Message-ID: <20130805170544.GO5102@mwanda> (raw)
In-Reply-To: <51FFD1CB.4080907@bfs.de>
On Mon, Aug 05, 2013 at 06:24:43PM +0200, walter harms wrote:
> Hello Julia,
>
> IMHO keep the patch as it is.
> It does not change any code that is good.
> Suspicious code that comes up here can be addressed
> in a separate patch.
>
Gar... No, if we silence static checker warnings without fixing the
bug then we are hiding real problems and making them more difficult
to find.
Just drop this chunk.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-05 17:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 14:47 [PATCH] adjust code alignment Julia Lawall
2013-08-05 14:47 ` Julia Lawall
2013-08-05 14:47 ` [PATCH] fs/nfs/inode.c: " Julia Lawall
2013-08-05 14:47 ` Julia Lawall
2013-08-05 14:59 ` Myklebust, Trond
2013-08-05 14:59 ` Myklebust, Trond
2013-08-05 14:59 ` Myklebust, Trond
2013-08-06 18:04 ` Steve Dickson
2013-08-06 18:04 ` Steve Dickson
2013-08-07 1:58 ` Dave Quigley
2013-08-07 1:58 ` Dave Quigley
2013-08-05 14:47 ` [PATCH] drivers/scsi/lpfc/lpfc_init.c: " Julia Lawall
2013-08-05 14:47 ` Julia Lawall
2013-08-05 14:47 ` [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon Julia Lawall
2013-08-05 14:47 ` Julia Lawall
2013-08-05 18:08 ` David Miller
2013-08-05 18:08 ` David Miller
2013-08-05 14:47 ` [PATCH] trivial: adjust code alignment Julia Lawall
2013-08-05 14:47 ` Julia Lawall
2013-08-05 16:06 ` Dan Carpenter
2013-08-05 16:06 ` Dan Carpenter
2013-08-05 16:17 ` Joe Perches
2013-08-05 16:17 ` Joe Perches
2013-08-05 16:30 ` Dan Carpenter
2013-08-05 16:30 ` Dan Carpenter
2013-08-06 0:51 ` Joe Perches
2013-08-06 0:51 ` Joe Perches
2013-08-05 16:19 ` Julia Lawall
2013-08-05 16:19 ` Julia Lawall
2013-08-05 16:24 ` walter harms
2013-08-05 16:24 ` walter harms
2013-08-05 16:28 ` Julia Lawall
2013-08-05 16:28 ` Julia Lawall
2013-08-05 17:05 ` Dan Carpenter [this message]
2013-08-05 17:05 ` Dan Carpenter
2013-08-05 16:52 ` Jonathan Corbet
2013-08-05 16:52 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805170544.GO5102@mwanda \
--to=dan.carpenter@oracle.com \
--cc=corbet@lwn.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=trivial@kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.