* [PATCH] arm: dts: vf610-twr: Add support for sdhc1
@ 2014-02-28 12:46 Stoica Cosmin Stefan
2014-03-03 5:12 ` Shawn Guo
2014-03-03 15:29 ` [PATCH v2] ARM: " Stoica Cosmin Stefan
0 siblings, 2 replies; 4+ messages in thread
From: Stoica Cosmin Stefan @ 2014-02-28 12:46 UTC (permalink / raw)
To: linux-arm-kernel
From: Cosmin Stoica <cosminstefan.stoica@freescale.com>
The kernel was not able to boot from SD card because sdhc support
was not present into the dts.
A new entry for sdhc1 was added for vf610-twr board based on the
compatible entry present on imx53.
After applying these changes, the kernel is able to boot successfully
from SD card.
Signed-off-by: Cosmin Stoica <cosminstefan.stoica@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 7 +++++++
arch/arm/boot/dts/vf610.dtsi | 10 ++++++++++
2 files changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index 7dd1d6e..fa4cf48 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -227,3 +227,10 @@
pinctrl-0 = <&pinctrl_uart1>;
status = "okay";
};
+
+&esdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_esdhc1_1>;
+ bus-width = <4>;
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index c63d26d..516b6d2 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -344,6 +344,16 @@
status = "disabled";
};
+ esdhc1: esdhc at 400b2000 {
+ compatible = "fsl,imx53-esdhc";
+ reg = <0x400b2000 0x4000>;
+ interrupts = <0 28 0x04>;
+ clocks = <&clks VF610_CLK_IPG_BUS>, <&clks VF610_CLK_PLATFORM_BUS>, <&clks VF610_CLK_ESDHC1>;
+ clock-names = "ipg", "ahb", "per";
+ bus-width = <4>;
+ status = "disabled";
+ };
+
fec0: ethernet at 400d0000 {
compatible = "fsl,mvf600-fec";
reg = <0x400d0000 0x1000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm: dts: vf610-twr: Add support for sdhc1
2014-02-28 12:46 [PATCH] arm: dts: vf610-twr: Add support for sdhc1 Stoica Cosmin Stefan
@ 2014-03-03 5:12 ` Shawn Guo
2014-03-03 15:29 ` [PATCH v2] ARM: " Stoica Cosmin Stefan
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-03-03 5:12 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 28, 2014 at 02:46:51PM +0200, Stoica Cosmin Stefan wrote:
> From: Cosmin Stoica <cosminstefan.stoica@freescale.com>
>
> The kernel was not able to boot from SD card because sdhc support
> was not present into the dts.
>
> A new entry for sdhc1 was added for vf610-twr board based on the
> compatible entry present on imx53.
>
> After applying these changes, the kernel is able to boot successfully
> from SD card.
>
> Signed-off-by: Cosmin Stoica <cosminstefan.stoica@freescale.com>
Use "ARM:" instead of "arm:" in patch subject please.
> ---
> arch/arm/boot/dts/vf610-twr.dts | 7 +++++++
> arch/arm/boot/dts/vf610.dtsi | 10 ++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index 7dd1d6e..fa4cf48 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -227,3 +227,10 @@
> pinctrl-0 = <&pinctrl_uart1>;
> status = "okay";
> };
> +
> +&esdhc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_esdhc1_1>;
> + bus-width = <4>;
> + status = "okay";
> +};
Sort the node alphabetically. IOW, it should be put right before &fec0.
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index c63d26d..516b6d2 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -344,6 +344,16 @@
> status = "disabled";
> };
>
> + esdhc1: esdhc at 400b2000 {
> + compatible = "fsl,imx53-esdhc";
> + reg = <0x400b2000 0x4000>;
> + interrupts = <0 28 0x04>;
> + clocks = <&clks VF610_CLK_IPG_BUS>, <&clks VF610_CLK_PLATFORM_BUS>, <&clks VF610_CLK_ESDHC1>;
The line is too long. You can split it like:
clocks = <&clks VF610_CLK_IPG_BUS>,
<&clks VF610_CLK_PLATFORM_BUS>,
<&clks VF610_CLK_ESDHC1>;
> + clock-names = "ipg", "ahb", "per";
> + bus-width = <4>;
This property can be dropped, since you have it in board dts.
Shawn
> + status = "disabled";
> + };
> +
> fec0: ethernet at 400d0000 {
> compatible = "fsl,mvf600-fec";
> reg = <0x400d0000 0x1000>;
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: dts: vf610-twr: Add support for sdhc1
2014-02-28 12:46 [PATCH] arm: dts: vf610-twr: Add support for sdhc1 Stoica Cosmin Stefan
2014-03-03 5:12 ` Shawn Guo
@ 2014-03-03 15:29 ` Stoica Cosmin Stefan
2014-03-05 5:33 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Stoica Cosmin Stefan @ 2014-03-03 15:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Cosmin Stoica <cosminstefan.stoica@freescale.com>
The kernel was not able to boot from SD card because sdhc support
was not present into the dts.
A new entry for sdhc1 was added for vf610-twr board based on the
compatible entry present on imx53.
After applying these changes, the kernel is able to boot successfully
from SD card.
Changes v1-v2:
According to Shawn Guo's comments:
- moved esdhc1 node before fec0 in board dts file;
- reformatted clocks line;
- removed duplicate property (bus-width) in dtsi file.
Signed-off-by: Cosmin Stoica <cosminstefan.stoica@freescale.com>
Signed-off-by: Chircu Bogdan <Bogdan.Chircu@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 8 ++++++++
arch/arm/boot/dts/vf610.dtsi | 11 +++++++++++
2 files changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index 7dd1d6e..e77c98e 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -111,6 +111,13 @@
};
};
+&esdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_esdhc1_1>;
+ bus-width = <4>;
+ status = "okay";
+};
+
&fec0 {
phy-mode = "rmii";
pinctrl-names = "default";
@@ -227,3 +234,4 @@
pinctrl-0 = <&pinctrl_uart1>;
status = "okay";
};
+
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index c63d26d..70de377 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -344,6 +344,17 @@
status = "disabled";
};
+ esdhc1: esdhc at 400b2000 {
+ compatible = "fsl,imx53-esdhc";
+ reg = <0x400b2000 0x4000>;
+ interrupts = <0 28 0x04>;
+ clocks = <&clks VF610_CLK_IPG_BUS>,
+ <&clks VF610_CLK_PLATFORM_BUS>,
+ <&clks VF610_CLK_ESDHC1>;
+ clock-names = "ipg", "ahb", "per";
+ status = "disabled";
+ };
+
fec0: ethernet at 400d0000 {
compatible = "fsl,mvf600-fec";
reg = <0x400d0000 0x1000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: dts: vf610-twr: Add support for sdhc1
2014-03-03 15:29 ` [PATCH v2] ARM: " Stoica Cosmin Stefan
@ 2014-03-05 5:33 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-03-05 5:33 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 03, 2014 at 05:29:33PM +0200, Stoica Cosmin Stefan wrote:
> From: Cosmin Stoica <cosminstefan.stoica@freescale.com>
>
> The kernel was not able to boot from SD card because sdhc support
> was not present into the dts.
>
> A new entry for sdhc1 was added for vf610-twr board based on the
> compatible entry present on imx53.
>
> After applying these changes, the kernel is able to boot successfully
> from SD card.
>
> Changes v1-v2:
> According to Shawn Guo's comments:
> - moved esdhc1 node before fec0 in board dts file;
> - reformatted clocks line;
> - removed duplicate property (bus-width) in dtsi file.
>
> Signed-off-by: Cosmin Stoica <cosminstefan.stoica@freescale.com>
> Signed-off-by: Chircu Bogdan <Bogdan.Chircu@freescale.com>
> ---
> arch/arm/boot/dts/vf610-twr.dts | 8 ++++++++
> arch/arm/boot/dts/vf610.dtsi | 11 +++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index 7dd1d6e..e77c98e 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -111,6 +111,13 @@
> };
> };
>
> +&esdhc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_esdhc1_1>;
Please base the patch on my for-next branch below, where stuff
like pinctrl_esdhc1_1 have gone into board dts.
git://git.linaro.org/people/shawnguo/linux-2.6.git for-next
> + bus-width = <4>;
> + status = "okay";
> +};
> +
> &fec0 {
> phy-mode = "rmii";
> pinctrl-names = "default";
> @@ -227,3 +234,4 @@
> pinctrl-0 = <&pinctrl_uart1>;
> status = "okay";
> };
> +
You shouldn't add this new line.
Shawn
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index c63d26d..70de377 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -344,6 +344,17 @@
> status = "disabled";
> };
>
> + esdhc1: esdhc at 400b2000 {
> + compatible = "fsl,imx53-esdhc";
> + reg = <0x400b2000 0x4000>;
> + interrupts = <0 28 0x04>;
> + clocks = <&clks VF610_CLK_IPG_BUS>,
> + <&clks VF610_CLK_PLATFORM_BUS>,
> + <&clks VF610_CLK_ESDHC1>;
> + clock-names = "ipg", "ahb", "per";
> + status = "disabled";
> + };
> +
> fec0: ethernet at 400d0000 {
> compatible = "fsl,mvf600-fec";
> reg = <0x400d0000 0x1000>;
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-05 5:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-28 12:46 [PATCH] arm: dts: vf610-twr: Add support for sdhc1 Stoica Cosmin Stefan
2014-03-03 5:12 ` Shawn Guo
2014-03-03 15:29 ` [PATCH v2] ARM: " Stoica Cosmin Stefan
2014-03-05 5:33 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.