From: Thor Thayer <tthayer@altera.com> To: Dinh Nguyen <dinguyen@altera.com> Cc: ZY - pavel <pavel@denx.de>, linux-can@vger.kernel.org, mkl@pengutronix.de, linux-arm-kernel@lists.infradead.org, socketcan@hartkopp.net, tthayer.linux@gmail.com, Steffen Trumtrar <s.trumtrar@pengutronix.de>, wg@grandegger.com Subject: Re: can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Date: Fri, 25 Apr 2014 16:31:58 -0500 [thread overview] Message-ID: <1398461518.3587.11.camel@dinh-ubuntu> (raw) In-Reply-To: <1398457446.26387.0.camel@linux-builds1> On Fri, 2014-04-25 at 15:24 -0500, Dinh Nguyen wrote: > On Fri, 2014-04-25 at 21:53 +0200, ZY - pavel wrote: > > Hi! > > > > > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > > > > > I have had similar patch here, except that it only listed 2 interrupts > > > for each d_can controller. > > > > > > Otherwise it looks identical. > > > > > > Reviewed-by: Pavel Machek <pavel@denx.de> > > > > Actually, does it work for you? Here it produces warnings during boot > > > > c_can_platform ffc00000.d_can: invalid resource > > c_can_platform ffc00000.d_can: control memory is not used for raminit > > c_can_platform ffc00000.d_can: c_can_platform device registered > > (regs=9085c000, irq=163) Hi! Yes, these warnings are being addressed in a patch I submitted that is currently being reviewed. (http://article.gmane.org/gmane.linux.can/5620/match=tthayer) > > ... > > can: controller area network core (rev 20120528 abi 9) > > NET: Registered protocol family 29 > > can: raw protocol (rev 20120528) > > can: broadcast manager protocol (rev 20120528 t) > > can: netlink gateway (rev 20130117) max_hops=1 > > > > . Then can0 is correctly registered, and seems to even receive > > packets, but only when enter is pressed on serial console... which is > > kind of weird. I suspected irq problems, but same symptomps with > > "irqpoll" -- it leads to generate 2000 irqs/second, but still waits > > for enter. > > > > [Aha, and we have just two interrupts listed, but I don't think that > > explains all the problems. Unfortunately, that particular target uses > > human for remote power switch...]. > > > > Any ideas? > > CC'ing Thor Thayer. He's done the CAN testing on the SOCFPGA platform. > > Dinh To get this working well, I had to install a few of the patches that Benedict Spranger submitted ([PATCH 05/16] c_can: use 32 bit access for D_CAN) on 9/9/2013. I have the patches on our rocketboard branch (rocketboards.org/gitweb/?p=linux-socfpga-git;a=summary) I planned to upstream these changes but there have been some major changes to CAN recently that may require some refactoring. Thor > > > > Thanks, > > Pavel > >
WARNING: multiple messages have this Message-ID (diff)
From: tthayer@altera.com (Thor Thayer) To: linux-arm-kernel@lists.infradead.org Subject: can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Date: Fri, 25 Apr 2014 16:31:58 -0500 [thread overview] Message-ID: <1398461518.3587.11.camel@dinh-ubuntu> (raw) In-Reply-To: <1398457446.26387.0.camel@linux-builds1> On Fri, 2014-04-25 at 15:24 -0500, Dinh Nguyen wrote: > On Fri, 2014-04-25 at 21:53 +0200, ZY - pavel wrote: > > Hi! > > > > > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > > > > > I have had similar patch here, except that it only listed 2 interrupts > > > for each d_can controller. > > > > > > Otherwise it looks identical. > > > > > > Reviewed-by: Pavel Machek <pavel@denx.de> > > > > Actually, does it work for you? Here it produces warnings during boot > > > > c_can_platform ffc00000.d_can: invalid resource > > c_can_platform ffc00000.d_can: control memory is not used for raminit > > c_can_platform ffc00000.d_can: c_can_platform device registered > > (regs=9085c000, irq=163) Hi! Yes, these warnings are being addressed in a patch I submitted that is currently being reviewed. (http://article.gmane.org/gmane.linux.can/5620/match=tthayer) > > ... > > can: controller area network core (rev 20120528 abi 9) > > NET: Registered protocol family 29 > > can: raw protocol (rev 20120528) > > can: broadcast manager protocol (rev 20120528 t) > > can: netlink gateway (rev 20130117) max_hops=1 > > > > . Then can0 is correctly registered, and seems to even receive > > packets, but only when enter is pressed on serial console... which is > > kind of weird. I suspected irq problems, but same symptomps with > > "irqpoll" -- it leads to generate 2000 irqs/second, but still waits > > for enter. > > > > [Aha, and we have just two interrupts listed, but I don't think that > > explains all the problems. Unfortunately, that particular target uses > > human for remote power switch...]. > > > > Any ideas? > > CC'ing Thor Thayer. He's done the CAN testing on the SOCFPGA platform. > > Dinh To get this working well, I had to install a few of the patches that Benedict Spranger submitted ([PATCH 05/16] c_can: use 32 bit access for D_CAN) on 9/9/2013. I have the patches on our rocketboard branch (rocketboards.org/gitweb/?p=linux-socfpga-git;a=summary) I planned to upstream these changes but there have been some major changes to CAN recently that may require some refactoring. Thor > > > > Thanks, > > Pavel > >
next prev parent reply other threads:[~2014-04-25 21:31 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-02 7:11 [PATCH v2 1/6] ARM: socfpga: dts: fix pdma interrupt Steffen Trumtrar 2014-04-02 7:11 ` [PATCH v2 2/6] ARM: socfpga: dts: add remaining interrupts for pdma Steffen Trumtrar 2014-04-02 7:11 ` [PATCH v2 3/6] ARM: socfpga: dts: add i2c busses Steffen Trumtrar 2014-04-02 7:11 ` [PATCH v2 4/6] ARM: socfpga: dts: add can0+1 Steffen Trumtrar 2014-04-04 10:28 ` Pavel Machek 2014-04-25 19:53 ` can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Pavel Machek 2014-04-25 19:53 ` Pavel Machek 2014-04-25 20:24 ` Dinh Nguyen 2014-04-25 20:24 ` Dinh Nguyen 2014-04-25 21:31 ` Thor Thayer [this message] 2014-04-25 21:31 ` Thor Thayer 2014-04-26 8:57 ` Pavel Machek 2014-04-26 8:57 ` Pavel Machek 2014-04-26 9:16 ` Pavel Machek 2014-04-26 9:16 ` Pavel Machek 2014-04-26 9:36 ` Pavel Machek 2014-04-26 9:36 ` Pavel Machek 2014-04-26 20:31 ` Pavel Machek 2014-04-26 20:31 ` Pavel Machek 2014-04-26 20:51 ` Oliver Hartkopp 2014-04-26 20:51 ` Oliver Hartkopp 2014-04-26 22:37 ` Marc Kleine-Budde 2014-04-26 22:37 ` Marc Kleine-Budde 2014-04-27 12:25 ` [patch] Fix CAN on socfpga, for net/master Pavel Machek 2014-04-27 12:25 ` Pavel Machek 2014-04-28 20:20 ` Thor Thayer 2014-04-28 20:20 ` Thor Thayer 2014-04-28 21:15 ` Pavel Machek 2014-04-28 21:15 ` Pavel Machek 2014-04-28 23:37 ` T Thayer 2014-04-28 23:37 ` T Thayer [not found] ` <CAF03EBd19PC5RAsLR6-dMPF2x3XRf9X4bFPgX2kRdCYWUQBYcA@mail.gmail.com> 2014-04-30 21:53 ` Pavel Machek 2014-04-30 21:53 ` Pavel Machek 2014-05-01 13:15 ` Thor Thayer 2014-05-01 13:15 ` Thor Thayer 2014-05-02 8:48 ` [PATCHv2] " Pavel Machek 2014-05-02 8:48 ` Pavel Machek 2014-05-02 12:27 ` Marc Kleine-Budde 2014-05-02 12:27 ` Marc Kleine-Budde 2014-05-05 12:07 ` Pavel Machek 2014-05-05 12:07 ` Pavel Machek 2014-05-13 12:07 ` Pavel Machek 2014-05-13 12:07 ` Pavel Machek 2014-05-05 12:08 ` [PATCH 2/2] Add 32-bit accesses Pavel Machek 2014-05-05 12:08 ` Pavel Machek 2014-05-05 12:40 ` Marc Kleine-Budde 2014-05-05 12:40 ` Marc Kleine-Budde 2014-05-06 13:57 ` [PATCHv3] C_CAN: " Pavel Machek 2014-05-06 13:57 ` Pavel Machek 2014-05-12 15:47 ` Marc Kleine-Budde 2014-05-12 15:47 ` Marc Kleine-Budde 2014-05-13 11:29 ` Pavel Machek 2014-05-13 11:29 ` Pavel Machek 2014-05-13 13:09 ` [PATCHv3] C_CAN: hwinit support for non-TI devices Pavel Machek 2014-05-13 13:09 ` Pavel Machek 2014-05-13 13:36 ` Marc Kleine-Budde 2014-05-13 13:36 ` Marc Kleine-Budde 2014-05-13 15:08 ` Pavel Machek 2014-05-13 15:08 ` Pavel Machek 2014-05-13 15:18 ` Marc Kleine-Budde 2014-05-13 15:18 ` Marc Kleine-Budde 2014-05-05 12:08 ` [PATCH 1/2] " Pavel Machek 2014-05-05 12:08 ` Pavel Machek 2014-05-05 12:21 ` Marc Kleine-Budde 2014-05-05 12:21 ` Marc Kleine-Budde 2014-05-05 12:22 ` Marc Kleine-Budde 2014-05-05 12:22 ` Marc Kleine-Budde 2014-05-05 12:58 ` Pavel Machek 2014-05-05 12:58 ` Pavel Machek 2014-05-05 13:00 ` Marc Kleine-Budde 2014-05-05 13:00 ` Marc Kleine-Budde 2014-05-05 13:00 ` Pavel Machek 2014-05-05 13:00 ` Pavel Machek 2014-04-02 7:11 ` [PATCH v2 5/6] ARM: socfpga: dts: add support for EBV SOCrates Steffen Trumtrar 2014-04-04 10:28 ` Pavel Machek 2014-04-02 7:11 ` [PATCH v2 6/6] ARM: socfpga: dts: add rtc on i2c0 to socrates Steffen Trumtrar 2014-04-02 17:33 ` [PATCH v2 1/6] ARM: socfpga: dts: fix pdma interrupt Dinh Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1398461518.3587.11.camel@dinh-ubuntu \ --to=tthayer@altera.com \ --cc=dinguyen@altera.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-can@vger.kernel.org \ --cc=mkl@pengutronix.de \ --cc=pavel@denx.de \ --cc=s.trumtrar@pengutronix.de \ --cc=socketcan@hartkopp.net \ --cc=tthayer.linux@gmail.com \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.