From: Oliver Hartkopp <socketcan@hartkopp.net> To: Pavel Machek <pavel@denx.de>, Thor Thayer <tthayer@altera.com> Cc: Dinh Nguyen <dinguyen@altera.com>, Steffen Trumtrar <s.trumtrar@pengutronix.de>, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, tthayer.linux@gmail.com Subject: Re: can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Date: Sat, 26 Apr 2014 22:51:02 +0200 [thread overview] Message-ID: <535C1C36.40007@hartkopp.net> (raw) In-Reply-To: <20140426203131.GA21832@amd.pavel.ucw.cz> On 26.04.2014 22:31, Pavel Machek wrote: > On Sat 2014-04-26 11:36:46, Pavel Machek wrote: >> Hi! >> >>> To get this working well, I had to install a few of the patches that >>> Benedict Spranger submitted ([PATCH 05/16] c_can: use 32 bit access for >>> D_CAN) on 9/9/2013. >>> >>> I have the patches on our rocketboard branch >>> (rocketboards.org/gitweb/?p=linux-socfpga-git;a=summary) >>> >>> I planned to upstream these changes but there have been some major >>> changes to CAN recently that may require some refactoring. >> >> I ported those changes to 3.15-rc2 (but can't test them at the >> moment). > > Ok, it seems it is possible to test CAN without actual can hardware > using loopback: > > ip link set can0 up type can bitrate 125000 loopback on > ifconfig can0 up > candump can0 & > cansend can0 "123#DEADBEEF" > > Moreover, it seems that previous two patches do the trick. Packets are > now echoed as expected. (Ok, small question is "why twice", but I > guess that's just CAN...?) Usually the CAN frame is echo'ed back when the CAN frame is successfully sent on the medium (tx ok interrupt, see: echo skb functionality in drivers/net/can/dev.c and in can.txt for multiuser capabilites). The second CAN frame is obviouly created by some rx interrupt which occurs due to the loopback functionality inside the C_CAN controller - which is usually not enabled. So it's a correct behaviour. Best regards, Oliver > > root@sockit:~# ip link set can0 up type can bitrate 125000 loopback on > c_can_platform ffc00000.d_can can0: setting BTR=1c31 BRPE=0000 > root@sockit:~# ifconfig can0 up > root@sockit:~# candump can0 & > root@sockit:~# cansend can0 "123#DEADBEEF" > can0 123 [4] DE AD BE EF > can0 123 [4] DE AD BE EF > root@sockit:~# > > Best regards, > Pavel >
WARNING: multiple messages have this Message-ID (diff)
From: socketcan@hartkopp.net (Oliver Hartkopp) To: linux-arm-kernel@lists.infradead.org Subject: can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Date: Sat, 26 Apr 2014 22:51:02 +0200 [thread overview] Message-ID: <535C1C36.40007@hartkopp.net> (raw) In-Reply-To: <20140426203131.GA21832@amd.pavel.ucw.cz> On 26.04.2014 22:31, Pavel Machek wrote: > On Sat 2014-04-26 11:36:46, Pavel Machek wrote: >> Hi! >> >>> To get this working well, I had to install a few of the patches that >>> Benedict Spranger submitted ([PATCH 05/16] c_can: use 32 bit access for >>> D_CAN) on 9/9/2013. >>> >>> I have the patches on our rocketboard branch >>> (rocketboards.org/gitweb/?p=linux-socfpga-git;a=summary) >>> >>> I planned to upstream these changes but there have been some major >>> changes to CAN recently that may require some refactoring. >> >> I ported those changes to 3.15-rc2 (but can't test them at the >> moment). > > Ok, it seems it is possible to test CAN without actual can hardware > using loopback: > > ip link set can0 up type can bitrate 125000 loopback on > ifconfig can0 up > candump can0 & > cansend can0 "123#DEADBEEF" > > Moreover, it seems that previous two patches do the trick. Packets are > now echoed as expected. (Ok, small question is "why twice", but I > guess that's just CAN...?) Usually the CAN frame is echo'ed back when the CAN frame is successfully sent on the medium (tx ok interrupt, see: echo skb functionality in drivers/net/can/dev.c and in can.txt for multiuser capabilites). The second CAN frame is obviouly created by some rx interrupt which occurs due to the loopback functionality inside the C_CAN controller - which is usually not enabled. So it's a correct behaviour. Best regards, Oliver > > root at sockit:~# ip link set can0 up type can bitrate 125000 loopback on > c_can_platform ffc00000.d_can can0: setting BTR=1c31 BRPE=0000 > root at sockit:~# ifconfig can0 up > root at sockit:~# candump can0 & > root at sockit:~# cansend can0 "123#DEADBEEF" > can0 123 [4] DE AD BE EF > can0 123 [4] DE AD BE EF > root at sockit:~# > > Best regards, > Pavel >
next prev parent reply other threads:[~2014-04-26 20:51 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-02 7:11 [PATCH v2 1/6] ARM: socfpga: dts: fix pdma interrupt Steffen Trumtrar 2014-04-02 7:11 ` [PATCH v2 2/6] ARM: socfpga: dts: add remaining interrupts for pdma Steffen Trumtrar 2014-04-02 7:11 ` [PATCH v2 3/6] ARM: socfpga: dts: add i2c busses Steffen Trumtrar 2014-04-02 7:11 ` [PATCH v2 4/6] ARM: socfpga: dts: add can0+1 Steffen Trumtrar 2014-04-04 10:28 ` Pavel Machek 2014-04-25 19:53 ` can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Pavel Machek 2014-04-25 19:53 ` Pavel Machek 2014-04-25 20:24 ` Dinh Nguyen 2014-04-25 20:24 ` Dinh Nguyen 2014-04-25 21:31 ` Thor Thayer 2014-04-25 21:31 ` Thor Thayer 2014-04-26 8:57 ` Pavel Machek 2014-04-26 8:57 ` Pavel Machek 2014-04-26 9:16 ` Pavel Machek 2014-04-26 9:16 ` Pavel Machek 2014-04-26 9:36 ` Pavel Machek 2014-04-26 9:36 ` Pavel Machek 2014-04-26 20:31 ` Pavel Machek 2014-04-26 20:31 ` Pavel Machek 2014-04-26 20:51 ` Oliver Hartkopp [this message] 2014-04-26 20:51 ` Oliver Hartkopp 2014-04-26 22:37 ` Marc Kleine-Budde 2014-04-26 22:37 ` Marc Kleine-Budde 2014-04-27 12:25 ` [patch] Fix CAN on socfpga, for net/master Pavel Machek 2014-04-27 12:25 ` Pavel Machek 2014-04-28 20:20 ` Thor Thayer 2014-04-28 20:20 ` Thor Thayer 2014-04-28 21:15 ` Pavel Machek 2014-04-28 21:15 ` Pavel Machek 2014-04-28 23:37 ` T Thayer 2014-04-28 23:37 ` T Thayer [not found] ` <CAF03EBd19PC5RAsLR6-dMPF2x3XRf9X4bFPgX2kRdCYWUQBYcA@mail.gmail.com> 2014-04-30 21:53 ` Pavel Machek 2014-04-30 21:53 ` Pavel Machek 2014-05-01 13:15 ` Thor Thayer 2014-05-01 13:15 ` Thor Thayer 2014-05-02 8:48 ` [PATCHv2] " Pavel Machek 2014-05-02 8:48 ` Pavel Machek 2014-05-02 12:27 ` Marc Kleine-Budde 2014-05-02 12:27 ` Marc Kleine-Budde 2014-05-05 12:07 ` Pavel Machek 2014-05-05 12:07 ` Pavel Machek 2014-05-13 12:07 ` Pavel Machek 2014-05-13 12:07 ` Pavel Machek 2014-05-05 12:08 ` [PATCH 2/2] Add 32-bit accesses Pavel Machek 2014-05-05 12:08 ` Pavel Machek 2014-05-05 12:40 ` Marc Kleine-Budde 2014-05-05 12:40 ` Marc Kleine-Budde 2014-05-06 13:57 ` [PATCHv3] C_CAN: " Pavel Machek 2014-05-06 13:57 ` Pavel Machek 2014-05-12 15:47 ` Marc Kleine-Budde 2014-05-12 15:47 ` Marc Kleine-Budde 2014-05-13 11:29 ` Pavel Machek 2014-05-13 11:29 ` Pavel Machek 2014-05-13 13:09 ` [PATCHv3] C_CAN: hwinit support for non-TI devices Pavel Machek 2014-05-13 13:09 ` Pavel Machek 2014-05-13 13:36 ` Marc Kleine-Budde 2014-05-13 13:36 ` Marc Kleine-Budde 2014-05-13 15:08 ` Pavel Machek 2014-05-13 15:08 ` Pavel Machek 2014-05-13 15:18 ` Marc Kleine-Budde 2014-05-13 15:18 ` Marc Kleine-Budde 2014-05-05 12:08 ` [PATCH 1/2] " Pavel Machek 2014-05-05 12:08 ` Pavel Machek 2014-05-05 12:21 ` Marc Kleine-Budde 2014-05-05 12:21 ` Marc Kleine-Budde 2014-05-05 12:22 ` Marc Kleine-Budde 2014-05-05 12:22 ` Marc Kleine-Budde 2014-05-05 12:58 ` Pavel Machek 2014-05-05 12:58 ` Pavel Machek 2014-05-05 13:00 ` Marc Kleine-Budde 2014-05-05 13:00 ` Marc Kleine-Budde 2014-05-05 13:00 ` Pavel Machek 2014-05-05 13:00 ` Pavel Machek 2014-04-02 7:11 ` [PATCH v2 5/6] ARM: socfpga: dts: add support for EBV SOCrates Steffen Trumtrar 2014-04-04 10:28 ` Pavel Machek 2014-04-02 7:11 ` [PATCH v2 6/6] ARM: socfpga: dts: add rtc on i2c0 to socrates Steffen Trumtrar 2014-04-02 17:33 ` [PATCH v2 1/6] ARM: socfpga: dts: fix pdma interrupt Dinh Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=535C1C36.40007@hartkopp.net \ --to=socketcan@hartkopp.net \ --cc=dinguyen@altera.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-can@vger.kernel.org \ --cc=mkl@pengutronix.de \ --cc=pavel@denx.de \ --cc=s.trumtrar@pengutronix.de \ --cc=tthayer.linux@gmail.com \ --cc=tthayer@altera.com \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.