All of lore.kernel.org
 help / color / mirror / Atom feed
From: T Thayer <tthayer.linux@gmail.com>
To: Pavel Machek <pavel@denx.de>
Cc: Thor Thayer <tthayer@altera.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Dinh Nguyen <dinguyen@altera.com>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
	socketcan@hartkopp.net, wg@grandegger.com
Subject: Re: [patch] Fix CAN on socfpga, for net/master
Date: Mon, 28 Apr 2014 18:37:21 -0500	[thread overview]
Message-ID: <CAF03EBf9KXqB4W9GuDduhLwp_kwFjUEi3syU7fX3KpXfZEFxHg@mail.gmail.com> (raw)
In-Reply-To: <20140428211505.GA28242@amd.pavel.ucw.cz>

On Mon, Apr 28, 2014 at 4:15 PM, Pavel Machek <pavel@denx.de> wrote:
> Hi!
>
> On Mon 2014-04-28 15:20:49, Thor Thayer wrote:
>> On Sun, 2014-04-27 at 14:25 +0200, ZY - pavel wrote:
>> > Apparently, socfpga CAN needs 32-bit accesses and different raminit
>> > sequence.
>> >
>> > Signed-off-by: Pavel Machek <pavel@denx.de>
>> >
>> > ---
>> >
>> > >
>> > > I'm not in the office (and fighting with my phone's email client) until 5th of May, however please rebase all your patches against the latest net/master from David Miller, as this tree includes all c_can fixes by Thomas.
>> > >
>> >
>> > Ok, combined patch is here. Lightly tested using loopback on Arrow
>> > SocKit.
>>
>> Hi Pavel.
>>
>> Thanks for your help on the SOCFPGA support! I can test this on the
>> Altera Development Kit but I'm not able to cleanly apply to the latest
>> David Miller net-next branch. Is there a different branch I should
>> use?
>
> It should have been against net-next branch... but perhaps I made a
> mistake somewhere. I should get some sleep now.
>
> Or ... let me upload my tree so that you can generate the diff.
>
> You should be able to get it using:
>
> git pull git://git.denx.de/linux-denx-pavel.git my_net_master
>
>> I also like your updates to my patch as shown below - much cleaner.
>
> Thanks :-).
>
> Best regards,
>
>                                                                 Pavel

Hi Pavel,

I didn't get a chance to pull and test your patch but a visual
inspection looks good.

Since you based this patch on my original code, feel free to add my signed-off.

Thor

>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: tthayer.linux@gmail.com (T Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] Fix CAN on socfpga, for net/master
Date: Mon, 28 Apr 2014 18:37:21 -0500	[thread overview]
Message-ID: <CAF03EBf9KXqB4W9GuDduhLwp_kwFjUEi3syU7fX3KpXfZEFxHg@mail.gmail.com> (raw)
In-Reply-To: <20140428211505.GA28242@amd.pavel.ucw.cz>

On Mon, Apr 28, 2014 at 4:15 PM, Pavel Machek <pavel@denx.de> wrote:
> Hi!
>
> On Mon 2014-04-28 15:20:49, Thor Thayer wrote:
>> On Sun, 2014-04-27 at 14:25 +0200, ZY - pavel wrote:
>> > Apparently, socfpga CAN needs 32-bit accesses and different raminit
>> > sequence.
>> >
>> > Signed-off-by: Pavel Machek <pavel@denx.de>
>> >
>> > ---
>> >
>> > >
>> > > I'm not in the office (and fighting with my phone's email client) until 5th of May, however please rebase all your patches against the latest net/master from David Miller, as this tree includes all c_can fixes by Thomas.
>> > >
>> >
>> > Ok, combined patch is here. Lightly tested using loopback on Arrow
>> > SocKit.
>>
>> Hi Pavel.
>>
>> Thanks for your help on the SOCFPGA support! I can test this on the
>> Altera Development Kit but I'm not able to cleanly apply to the latest
>> David Miller net-next branch. Is there a different branch I should
>> use?
>
> It should have been against net-next branch... but perhaps I made a
> mistake somewhere. I should get some sleep now.
>
> Or ... let me upload my tree so that you can generate the diff.
>
> You should be able to get it using:
>
> git pull git://git.denx.de/linux-denx-pavel.git my_net_master
>
>> I also like your updates to my patch as shown below - much cleaner.
>
> Thanks :-).
>
> Best regards,
>
>                                                                 Pavel

Hi Pavel,

I didn't get a chance to pull and test your patch but a visual
inspection looks good.

Since you based this patch on my original code, feel free to add my signed-off.

Thor

>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2014-04-28 23:37 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02  7:11 [PATCH v2 1/6] ARM: socfpga: dts: fix pdma interrupt Steffen Trumtrar
2014-04-02  7:11 ` [PATCH v2 2/6] ARM: socfpga: dts: add remaining interrupts for pdma Steffen Trumtrar
2014-04-02  7:11 ` [PATCH v2 3/6] ARM: socfpga: dts: add i2c busses Steffen Trumtrar
2014-04-02  7:11 ` [PATCH v2 4/6] ARM: socfpga: dts: add can0+1 Steffen Trumtrar
2014-04-04 10:28   ` Pavel Machek
2014-04-25 19:53     ` can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Pavel Machek
2014-04-25 19:53       ` Pavel Machek
2014-04-25 20:24       ` Dinh Nguyen
2014-04-25 20:24         ` Dinh Nguyen
2014-04-25 21:31         ` Thor Thayer
2014-04-25 21:31           ` Thor Thayer
2014-04-26  8:57           ` Pavel Machek
2014-04-26  8:57             ` Pavel Machek
2014-04-26  9:16           ` Pavel Machek
2014-04-26  9:16             ` Pavel Machek
2014-04-26  9:36           ` Pavel Machek
2014-04-26  9:36             ` Pavel Machek
2014-04-26 20:31             ` Pavel Machek
2014-04-26 20:31               ` Pavel Machek
2014-04-26 20:51               ` Oliver Hartkopp
2014-04-26 20:51                 ` Oliver Hartkopp
2014-04-26 22:37               ` Marc Kleine-Budde
2014-04-26 22:37                 ` Marc Kleine-Budde
2014-04-27 12:25                 ` [patch] Fix CAN on socfpga, for net/master Pavel Machek
2014-04-27 12:25                   ` Pavel Machek
2014-04-28 20:20                   ` Thor Thayer
2014-04-28 20:20                     ` Thor Thayer
2014-04-28 21:15                     ` Pavel Machek
2014-04-28 21:15                       ` Pavel Machek
2014-04-28 23:37                       ` T Thayer [this message]
2014-04-28 23:37                         ` T Thayer
     [not found]                         ` <CAF03EBd19PC5RAsLR6-dMPF2x3XRf9X4bFPgX2kRdCYWUQBYcA@mail.gmail.com>
2014-04-30 21:53                           ` Pavel Machek
2014-04-30 21:53                             ` Pavel Machek
2014-05-01 13:15                             ` Thor Thayer
2014-05-01 13:15                               ` Thor Thayer
2014-05-02  8:48                               ` [PATCHv2] " Pavel Machek
2014-05-02  8:48                                 ` Pavel Machek
2014-05-02 12:27                                 ` Marc Kleine-Budde
2014-05-02 12:27                                   ` Marc Kleine-Budde
2014-05-05 12:07                                   ` Pavel Machek
2014-05-05 12:07                                     ` Pavel Machek
2014-05-13 12:07                                   ` Pavel Machek
2014-05-13 12:07                                     ` Pavel Machek
2014-05-05 12:08                                 ` [PATCH 2/2] Add 32-bit accesses Pavel Machek
2014-05-05 12:08                                   ` Pavel Machek
2014-05-05 12:40                                   ` Marc Kleine-Budde
2014-05-05 12:40                                     ` Marc Kleine-Budde
2014-05-06 13:57                                   ` [PATCHv3] C_CAN: " Pavel Machek
2014-05-06 13:57                                     ` Pavel Machek
2014-05-12 15:47                                     ` Marc Kleine-Budde
2014-05-12 15:47                                       ` Marc Kleine-Budde
2014-05-13 11:29                                       ` Pavel Machek
2014-05-13 11:29                                         ` Pavel Machek
2014-05-13 13:09                                       ` [PATCHv3] C_CAN: hwinit support for non-TI devices Pavel Machek
2014-05-13 13:09                                         ` Pavel Machek
2014-05-13 13:36                                         ` Marc Kleine-Budde
2014-05-13 13:36                                           ` Marc Kleine-Budde
2014-05-13 15:08                                           ` Pavel Machek
2014-05-13 15:08                                             ` Pavel Machek
2014-05-13 15:18                                             ` Marc Kleine-Budde
2014-05-13 15:18                                               ` Marc Kleine-Budde
2014-05-05 12:08                                 ` [PATCH 1/2] " Pavel Machek
2014-05-05 12:08                                   ` Pavel Machek
2014-05-05 12:21                                   ` Marc Kleine-Budde
2014-05-05 12:21                                     ` Marc Kleine-Budde
2014-05-05 12:22                                     ` Marc Kleine-Budde
2014-05-05 12:22                                       ` Marc Kleine-Budde
2014-05-05 12:58                                     ` Pavel Machek
2014-05-05 12:58                                       ` Pavel Machek
2014-05-05 13:00                                       ` Marc Kleine-Budde
2014-05-05 13:00                                         ` Marc Kleine-Budde
2014-05-05 13:00                                     ` Pavel Machek
2014-05-05 13:00                                       ` Pavel Machek
2014-04-02  7:11 ` [PATCH v2 5/6] ARM: socfpga: dts: add support for EBV SOCrates Steffen Trumtrar
2014-04-04 10:28   ` Pavel Machek
2014-04-02  7:11 ` [PATCH v2 6/6] ARM: socfpga: dts: add rtc on i2c0 to socrates Steffen Trumtrar
2014-04-02 17:33 ` [PATCH v2 1/6] ARM: socfpga: dts: fix pdma interrupt Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF03EBf9KXqB4W9GuDduhLwp_kwFjUEi3syU7fX3KpXfZEFxHg@mail.gmail.com \
    --to=tthayer.linux@gmail.com \
    --cc=dinguyen@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=pavel@denx.de \
    --cc=s.trumtrar@pengutronix.de \
    --cc=socketcan@hartkopp.net \
    --cc=tthayer@altera.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.