From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> To: Lee Jones <lee.jones@linaro.org> Cc: Mark Brown <broonie@kernel.org>, Mike Turquette <mturquette@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Alessandro Zummo <a.zummo@towertech.it>, Kukjin Kim <kgene.kim@samsung.com>, Doug Anderson <dianders@chromium.org>, Olof Johansson <olof@lixom.net>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Yadwinder Singh Brar <yadi.brar01@gmail.com>, Tushar Behera <trblinux@gmail.com>, Andreas Farber <afaerber@suse.de>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas <javier.martinez@collabora.co.uk> Subject: [PATCH v7 07/24] mfd: max77686: Remove unneeded OOM error message Date: Fri, 4 Jul 2014 22:24:10 +0200 [thread overview] Message-ID: <1404505467-26526-8-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1404505467-26526-1-git-send-email-javier.martinez@collabora.co.uk> There is no need to print out-of-memory errors since this is already done by the memory management subsystem which even calls dump_stack(). Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/mfd/max77686.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 87fe52e..8650832 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -107,10 +107,8 @@ static struct max77686_platform_data *max77686_i2c_parse_dt_pdata(struct device struct max77686_platform_data *pd; pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); - if (!pd) { - dev_err(dev, "could not allocate memory for pdata\n"); + if (!pd) return NULL; - } dev->platform_data = pd; return pd; -- 2.0.0.rc2
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 07/24] mfd: max77686: Remove unneeded OOM error message Date: Fri, 4 Jul 2014 22:24:10 +0200 [thread overview] Message-ID: <1404505467-26526-8-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1404505467-26526-1-git-send-email-javier.martinez@collabora.co.uk> There is no need to print out-of-memory errors since this is already done by the memory management subsystem which even calls dump_stack(). Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/mfd/max77686.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 87fe52e..8650832 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -107,10 +107,8 @@ static struct max77686_platform_data *max77686_i2c_parse_dt_pdata(struct device struct max77686_platform_data *pd; pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); - if (!pd) { - dev_err(dev, "could not allocate memory for pdata\n"); + if (!pd) return NULL; - } dev->platform_data = pd; return pd; -- 2.0.0.rc2
next prev parent reply other threads:[~2014-07-04 20:25 UTC|newest] Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-04 20:24 [PATCH v7 00/24] Add Maxim 77802 PMIC support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 01/24] mfd: max77686: Convert to use regmap_irq Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 02/24] mfd: max77686: Add power management support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:44 ` Lee Jones 2014-07-09 14:44 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 03/24] mfd: max77686: Don't define dummy function if OF isn't enabled Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:50 ` Lee Jones 2014-07-09 14:50 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 04/24] mfd: max77686: Make platform data over-rule DT Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:52 ` Lee Jones 2014-07-09 14:52 ` Lee Jones 2014-07-09 18:15 ` Javier Martinez Canillas 2014-07-09 18:15 ` Javier Martinez Canillas 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 05/24] mfd: max77686: Return correct error when pdata isn't found Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:53 ` Lee Jones 2014-07-09 14:53 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 06/24] mfd: max77686: Make error checking consistent Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:54 ` Lee Jones 2014-07-09 14:54 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-04 20:24 ` Javier Martinez Canillas [this message] 2014-07-04 20:24 ` [PATCH v7 07/24] mfd: max77686: Remove unneeded OOM error message Javier Martinez Canillas 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 08/24] mfd: max77686: Add Dynamic Voltage Scaling (DVS) support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 15:13 ` Lee Jones 2014-07-09 15:13 ` Lee Jones 2014-07-09 18:40 ` Javier Martinez Canillas 2014-07-09 18:40 ` Javier Martinez Canillas 2014-07-10 9:46 ` Linus Walleij 2014-07-10 9:46 ` Linus Walleij 2014-07-11 0:51 ` Javier Martinez Canillas 2014-07-10 9:59 ` amit daniel kachhap 2014-07-10 9:59 ` amit daniel kachhap 2014-07-10 9:59 ` amit daniel kachhap 2014-07-11 1:45 ` Javier Martinez Canillas 2014-07-11 1:45 ` Javier Martinez Canillas 2014-07-11 1:45 ` Javier Martinez Canillas 2014-07-11 4:02 ` Doug Anderson 2014-07-11 4:02 ` Doug Anderson 2014-07-11 4:02 ` Doug Anderson 2014-07-11 9:37 ` amit daniel kachhap 2014-07-11 9:37 ` amit daniel kachhap 2014-07-11 9:37 ` amit daniel kachhap 2014-07-11 9:43 ` Tomasz Figa 2014-07-11 9:43 ` Tomasz Figa 2014-07-11 9:43 ` Tomasz Figa 2014-07-11 10:15 ` Javier Martinez Canillas 2014-07-11 10:15 ` Javier Martinez Canillas 2014-07-11 10:15 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 09/24] rtc: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 10/24] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-07 6:09 ` Krzysztof Kozlowski 2014-07-07 6:09 ` Krzysztof Kozlowski 2014-07-04 20:24 ` [PATCH v7 11/24] clk: max77686: Add DT include for MAX77686 PMIC clock Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 12/24] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 13/24] clk: max77686: Convert to the generic max clock driver Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 14/24] clk: max77686: Improve Maxim 77686 PMIC clocks binding Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 15/24] regmap: Add regmap_reg_copy function Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 16/24] regulator: max77686: Setup DVS-related GPIOs on probe Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 17/24] mfd: max77686: Add documentation for DVS bindings Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 18/24] mfd: max77686: Add Maxim 77802 PMIC support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 15:31 ` Lee Jones 2014-07-09 15:31 ` Lee Jones 2014-07-09 18:43 ` Javier Martinez Canillas 2014-07-09 18:43 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 19/24] mfd: max77802: Add DT binding documentation Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 20/24] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 21/24] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 22/24] clk: max77802: Add DT binding documentation Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 23/24] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-07 6:06 ` Krzysztof Kozlowski 2014-07-07 6:06 ` Krzysztof Kozlowski 2014-07-07 6:57 ` Javier Martinez Canillas 2014-07-07 6:57 ` Javier Martinez Canillas 2014-07-07 6:57 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 24/24] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1404505467-26526-8-git-send-email-javier.martinez@collabora.co.uk \ --to=javier.martinez@collabora.co.uk \ --cc=a.zummo@towertech.it \ --cc=afaerber@suse.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=k.kozlowski@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=olof@lixom.net \ --cc=tomeu.vizoso@collabora.com \ --cc=trblinux@gmail.com \ --cc=yadi.brar01@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.