From: Lee Jones <lee.jones@linaro.org> To: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Cc: Mark Brown <broonie@kernel.org>, Mike Turquette <mturquette@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Alessandro Zummo <a.zummo@towertech.it>, Kukjin Kim <kgene.kim@samsung.com>, Doug Anderson <dianders@chromium.org>, Olof Johansson <olof@lixom.net>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Yadwinder Singh Brar <yadi.brar01@gmail.com>, Tushar Behera <trblinux@gmail.com>, Andreas Farber <afaerber@suse.de>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 06/24] mfd: max77686: Make error checking consistent Date: Fri, 18 Jul 2014 09:18:36 +0100 [thread overview] Message-ID: <20140718081836.GP30888@lee--X1> (raw) In-Reply-To: <1404505467-26526-7-git-send-email-javier.martinez@collabora.co.uk> On Fri, 04 Jul 2014, Javier Martinez Canillas wrote: > Error checking across the driver is mostly consistent besides > a few exceptions, so change these exceptions for consistency. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/max77686.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied now, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index ada4976..87fe52e 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -134,7 +134,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > > max77686 = devm_kzalloc(&i2c->dev, > sizeof(struct max77686_dev), GFP_KERNEL); > - if (max77686 == NULL) > + if (!max77686) > return -ENOMEM; > > i2c_set_clientdata(i2c, max77686); > @@ -153,8 +153,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > return ret; > } > > - if (regmap_read(max77686->regmap, > - MAX77686_REG_DEVICE_ID, &data) < 0) { > + ret = regmap_read(max77686->regmap, MAX77686_REG_DEVICE_ID, &data); > + if (ret < 0) { > dev_err(max77686->dev, > "device not found on this channel (this is not an error)\n"); > return -ENODEV; > @@ -180,7 +180,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > IRQF_TRIGGER_FALLING | IRQF_ONESHOT | > IRQF_SHARED, 0, &max77686_irq_chip, > &max77686->irq_data); > - if (ret != 0) { > + if (ret) { > dev_err(&i2c->dev, "failed to add PMIC irq chip: %d\n", ret); > goto err_unregister_i2c; > } > @@ -188,7 +188,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > IRQF_TRIGGER_FALLING | IRQF_ONESHOT | > IRQF_SHARED, 0, &max77686_rtc_irq_chip, > &max77686->rtc_irq_data); > - if (ret != 0) { > + if (ret) { > dev_err(&i2c->dev, "failed to add RTC irq chip: %d\n", ret); > goto err_del_irqc; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 06/24] mfd: max77686: Make error checking consistent Date: Fri, 18 Jul 2014 09:18:36 +0100 [thread overview] Message-ID: <20140718081836.GP30888@lee--X1> (raw) In-Reply-To: <1404505467-26526-7-git-send-email-javier.martinez@collabora.co.uk> On Fri, 04 Jul 2014, Javier Martinez Canillas wrote: > Error checking across the driver is mostly consistent besides > a few exceptions, so change these exceptions for consistency. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/max77686.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied now, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index ada4976..87fe52e 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -134,7 +134,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > > max77686 = devm_kzalloc(&i2c->dev, > sizeof(struct max77686_dev), GFP_KERNEL); > - if (max77686 == NULL) > + if (!max77686) > return -ENOMEM; > > i2c_set_clientdata(i2c, max77686); > @@ -153,8 +153,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > return ret; > } > > - if (regmap_read(max77686->regmap, > - MAX77686_REG_DEVICE_ID, &data) < 0) { > + ret = regmap_read(max77686->regmap, MAX77686_REG_DEVICE_ID, &data); > + if (ret < 0) { > dev_err(max77686->dev, > "device not found on this channel (this is not an error)\n"); > return -ENODEV; > @@ -180,7 +180,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > IRQF_TRIGGER_FALLING | IRQF_ONESHOT | > IRQF_SHARED, 0, &max77686_irq_chip, > &max77686->irq_data); > - if (ret != 0) { > + if (ret) { > dev_err(&i2c->dev, "failed to add PMIC irq chip: %d\n", ret); > goto err_unregister_i2c; > } > @@ -188,7 +188,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > IRQF_TRIGGER_FALLING | IRQF_ONESHOT | > IRQF_SHARED, 0, &max77686_rtc_irq_chip, > &max77686->rtc_irq_data); > - if (ret != 0) { > + if (ret) { > dev_err(&i2c->dev, "failed to add RTC irq chip: %d\n", ret); > goto err_del_irqc; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-18 8:18 UTC|newest] Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-04 20:24 [PATCH v7 00/24] Add Maxim 77802 PMIC support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 01/24] mfd: max77686: Convert to use regmap_irq Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 02/24] mfd: max77686: Add power management support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:44 ` Lee Jones 2014-07-09 14:44 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 03/24] mfd: max77686: Don't define dummy function if OF isn't enabled Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:50 ` Lee Jones 2014-07-09 14:50 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 04/24] mfd: max77686: Make platform data over-rule DT Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:52 ` Lee Jones 2014-07-09 14:52 ` Lee Jones 2014-07-09 18:15 ` Javier Martinez Canillas 2014-07-09 18:15 ` Javier Martinez Canillas 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-18 8:17 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 05/24] mfd: max77686: Return correct error when pdata isn't found Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:53 ` Lee Jones 2014-07-09 14:53 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 06/24] mfd: max77686: Make error checking consistent Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 14:54 ` Lee Jones 2014-07-09 14:54 ` Lee Jones 2014-07-18 8:18 ` Lee Jones [this message] 2014-07-18 8:18 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 07/24] mfd: max77686: Remove unneeded OOM error message Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-18 8:18 ` Lee Jones 2014-07-04 20:24 ` [PATCH v7 08/24] mfd: max77686: Add Dynamic Voltage Scaling (DVS) support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 15:13 ` Lee Jones 2014-07-09 15:13 ` Lee Jones 2014-07-09 18:40 ` Javier Martinez Canillas 2014-07-09 18:40 ` Javier Martinez Canillas 2014-07-10 9:46 ` Linus Walleij 2014-07-10 9:46 ` Linus Walleij 2014-07-11 0:51 ` Javier Martinez Canillas 2014-07-10 9:59 ` amit daniel kachhap 2014-07-10 9:59 ` amit daniel kachhap 2014-07-10 9:59 ` amit daniel kachhap 2014-07-11 1:45 ` Javier Martinez Canillas 2014-07-11 1:45 ` Javier Martinez Canillas 2014-07-11 1:45 ` Javier Martinez Canillas 2014-07-11 4:02 ` Doug Anderson 2014-07-11 4:02 ` Doug Anderson 2014-07-11 4:02 ` Doug Anderson 2014-07-11 9:37 ` amit daniel kachhap 2014-07-11 9:37 ` amit daniel kachhap 2014-07-11 9:37 ` amit daniel kachhap 2014-07-11 9:43 ` Tomasz Figa 2014-07-11 9:43 ` Tomasz Figa 2014-07-11 9:43 ` Tomasz Figa 2014-07-11 10:15 ` Javier Martinez Canillas 2014-07-11 10:15 ` Javier Martinez Canillas 2014-07-11 10:15 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 09/24] rtc: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 10/24] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-07 6:09 ` Krzysztof Kozlowski 2014-07-07 6:09 ` Krzysztof Kozlowski 2014-07-04 20:24 ` [PATCH v7 11/24] clk: max77686: Add DT include for MAX77686 PMIC clock Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 12/24] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 13/24] clk: max77686: Convert to the generic max clock driver Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 14/24] clk: max77686: Improve Maxim 77686 PMIC clocks binding Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 15/24] regmap: Add regmap_reg_copy function Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 16/24] regulator: max77686: Setup DVS-related GPIOs on probe Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 17/24] mfd: max77686: Add documentation for DVS bindings Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 18/24] mfd: max77686: Add Maxim 77802 PMIC support Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-09 15:31 ` Lee Jones 2014-07-09 15:31 ` Lee Jones 2014-07-09 18:43 ` Javier Martinez Canillas 2014-07-09 18:43 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 19/24] mfd: max77802: Add DT binding documentation Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 20/24] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 21/24] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 22/24] clk: max77802: Add DT binding documentation Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 23/24] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas 2014-07-07 6:06 ` Krzysztof Kozlowski 2014-07-07 6:06 ` Krzysztof Kozlowski 2014-07-07 6:57 ` Javier Martinez Canillas 2014-07-07 6:57 ` Javier Martinez Canillas 2014-07-07 6:57 ` Javier Martinez Canillas 2014-07-04 20:24 ` [PATCH v7 24/24] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Javier Martinez Canillas 2014-07-04 20:24 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140718081836.GP30888@lee--X1 \ --to=lee.jones@linaro.org \ --cc=a.zummo@towertech.it \ --cc=afaerber@suse.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=javier.martinez@collabora.co.uk \ --cc=k.kozlowski@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=olof@lixom.net \ --cc=tomeu.vizoso@collabora.com \ --cc=trblinux@gmail.com \ --cc=yadi.brar01@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.