From: Zhou Yanjie <zhouyanjie@wanyeetech.com> To: Mark Brown <broonie@kernel.org> Cc: tudor.ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aidanmacdonald.0x0@gmail.com, tmn505@gmail.com, paul@crapouillou.net, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, jinghui.liu@ingenic.com, sernia.zhou@foxmail.com, reimu@sudomaker.com Subject: Re: [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs. Date: Sun, 24 Jul 2022 09:24:43 +0800 [thread overview] Message-ID: <1404dd8d-475e-b3b6-a3da-4eeddca3070b@wanyeetech.com> (raw) In-Reply-To: <YtxMwyRghFKS/vu5@sirena.org.uk> Hi Mark, On 2022/7/24 上午3:32, Mark Brown wrote: > On Sun, Jul 24, 2022 at 01:06:16AM +0800, Zhou Yanjie wrote: >> On 2022/7/23 上午2:38, Mark Brown wrote: >>>> +++ b/drivers/spi/spi-ingenic-sfc.c >>>> @@ -0,0 +1,662 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +/* >>>> + * Ingenic SoCs SPI Flash Controller Driver >>> Please make the entire comment a C++ one so things look more >>> intentional. >> I'm sorry, I didn't understand well what you meant :( >> Could you please explain a little more detail? > The above comment block uses both C /* */ and C++ // style comments, > please make it just use the C++ style. Sure, will do in the next version. >>>> +static irqreturn_t ingenic_sfc_irq_handler(int irq, void *data) >>>> +{ >>>> + struct ingenic_sfc *sfc = data; >>>> + >>>> + writel(0x1f, sfc->base + SFC_REG_INTC); >>>> + >>>> + complete(&sfc->completion); >>>> + >>>> + return IRQ_HANDLED; >>>> +} >>> This doesn't pay any attention to any status registers in the chip so >>> won't work if the interrupt is shared and won't notice any error reports >>> from the device... >> This interrupt is exclusively owned by SFC, do we still >> need to perform the operation you said? I haven't done >> these operations before because I want to minimize the >> overhead and avoid affecting performance. > Even if the device is not shared is there no possibility that the > device can report an unexpected interrupt status? It's not just > the sharing case, it's also the fact that it looks like there's a > status being reported but we're not checking it so if anything > goes wrong then we're less likely to notice. I'd worry about > data corruption. Sure, I will change this in the next version. Thanks and best regards!
WARNING: multiple messages have this Message-ID (diff)
From: Zhou Yanjie <zhouyanjie@wanyeetech.com> To: Mark Brown <broonie@kernel.org> Cc: tudor.ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aidanmacdonald.0x0@gmail.com, tmn505@gmail.com, paul@crapouillou.net, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, jinghui.liu@ingenic.com, sernia.zhou@foxmail.com, reimu@sudomaker.com Subject: Re: [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs. Date: Sun, 24 Jul 2022 09:24:43 +0800 [thread overview] Message-ID: <1404dd8d-475e-b3b6-a3da-4eeddca3070b@wanyeetech.com> (raw) In-Reply-To: <YtxMwyRghFKS/vu5@sirena.org.uk> Hi Mark, On 2022/7/24 上午3:32, Mark Brown wrote: > On Sun, Jul 24, 2022 at 01:06:16AM +0800, Zhou Yanjie wrote: >> On 2022/7/23 上午2:38, Mark Brown wrote: >>>> +++ b/drivers/spi/spi-ingenic-sfc.c >>>> @@ -0,0 +1,662 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +/* >>>> + * Ingenic SoCs SPI Flash Controller Driver >>> Please make the entire comment a C++ one so things look more >>> intentional. >> I'm sorry, I didn't understand well what you meant :( >> Could you please explain a little more detail? > The above comment block uses both C /* */ and C++ // style comments, > please make it just use the C++ style. Sure, will do in the next version. >>>> +static irqreturn_t ingenic_sfc_irq_handler(int irq, void *data) >>>> +{ >>>> + struct ingenic_sfc *sfc = data; >>>> + >>>> + writel(0x1f, sfc->base + SFC_REG_INTC); >>>> + >>>> + complete(&sfc->completion); >>>> + >>>> + return IRQ_HANDLED; >>>> +} >>> This doesn't pay any attention to any status registers in the chip so >>> won't work if the interrupt is shared and won't notice any error reports >>> from the device... >> This interrupt is exclusively owned by SFC, do we still >> need to perform the operation you said? I haven't done >> these operations before because I want to minimize the >> overhead and avoid affecting performance. > Even if the device is not shared is there no possibility that the > device can report an unexpected interrupt status? It's not just > the sharing case, it's also the fact that it looks like there's a > status being reported but we're not checking it so if anything > goes wrong then we're less likely to notice. I'd worry about > data corruption. Sure, I will change this in the next version. Thanks and best regards! ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-24 1:24 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-22 16:48 [PATCH 0/3] Add SFC support for Ingenic SoCs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` [PATCH 1/3] mtd: spi-nor: Use the spi-mem poll status APIs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-23 8:30 ` Sergey Shtylyov 2022-07-23 8:30 ` Sergey Shtylyov 2022-07-22 16:48 ` [PATCH 2/3] dt-bindings: SPI: Add Ingenic SFC bindings 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-22 17:46 ` Krzysztof Kozlowski 2022-07-22 17:46 ` Krzysztof Kozlowski 2022-07-23 16:50 ` Zhou Yanjie 2022-07-23 16:50 ` Zhou Yanjie 2022-07-23 17:43 ` Krzysztof Kozlowski 2022-07-23 17:43 ` Krzysztof Kozlowski 2022-07-23 18:47 ` Mike Yang 2022-07-23 18:47 ` Mike Yang 2022-07-23 19:27 ` Mark Brown 2022-07-23 19:27 ` Mark Brown 2022-07-23 20:07 ` Krzysztof Kozlowski 2022-07-23 20:07 ` Krzysztof Kozlowski 2022-07-23 20:49 ` Mike Yang 2022-07-23 20:49 ` Mike Yang 2022-07-24 15:33 ` Zhou Yanjie 2022-07-24 15:33 ` Zhou Yanjie 2022-07-25 18:30 ` Rob Herring 2022-07-25 18:30 ` Rob Herring 2022-07-23 20:05 ` Krzysztof Kozlowski 2022-07-23 20:05 ` Krzysztof Kozlowski 2022-07-24 14:52 ` Zhou Yanjie 2022-07-24 14:52 ` Zhou Yanjie 2022-07-22 22:44 ` Rob Herring 2022-07-22 22:44 ` Rob Herring 2022-07-22 16:48 ` [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-22 18:07 ` Krzysztof Kozlowski 2022-07-22 18:07 ` Krzysztof Kozlowski 2022-07-23 16:53 ` Zhou Yanjie 2022-07-23 16:53 ` Zhou Yanjie 2022-07-22 18:38 ` Mark Brown 2022-07-22 18:38 ` Mark Brown 2022-07-23 17:06 ` Zhou Yanjie 2022-07-23 17:06 ` Zhou Yanjie 2022-07-23 19:32 ` Mark Brown 2022-07-23 19:32 ` Mark Brown 2022-07-24 1:24 ` Zhou Yanjie [this message] 2022-07-24 1:24 ` Zhou Yanjie 2022-07-22 20:03 ` Paul Cercueil 2022-07-22 20:03 ` Paul Cercueil 2022-07-23 17:26 ` Zhou Yanjie 2022-07-23 17:26 ` Zhou Yanjie 2022-07-23 20:24 ` Paul Cercueil 2022-07-23 20:24 ` Paul Cercueil 2022-07-24 15:29 ` Zhou Yanjie 2022-07-24 15:29 ` Zhou Yanjie 2022-07-23 15:15 ` Christophe JAILLET 2022-07-23 15:15 ` Christophe JAILLET 2022-07-23 15:15 ` Christophe JAILLET 2022-07-24 1:22 ` Zhou Yanjie 2022-07-24 1:22 ` Zhou Yanjie 2022-07-24 0:43 ` kernel test robot 2022-07-24 0:43 ` kernel test robot 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-25 16:58 ` Vanessa Page 2022-07-23 14:47 ` [PATCH 0/3] " Tomasz Maciej Nowak 2022-07-23 14:47 ` Tomasz Maciej Nowak 2022-07-24 1:25 ` Zhou Yanjie 2022-07-24 1:25 ` Zhou Yanjie 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:30 ` Vanessa Page 2022-07-24 1:30 ` Vanessa Page 2022-07-24 1:32 ` Vee Page 2022-07-24 1:32 ` Vee Page 2022-07-26 6:13 ` Vee Page 2022-07-26 6:13 ` Vee Page
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1404dd8d-475e-b3b6-a3da-4eeddca3070b@wanyeetech.com \ --to=zhouyanjie@wanyeetech.com \ --cc=aidanmacdonald.0x0@gmail.com \ --cc=aric.pzqi@ingenic.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dongsheng.qiu@ingenic.com \ --cc=jinghui.liu@ingenic.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=p.yadav@ti.com \ --cc=paul@crapouillou.net \ --cc=reimu@sudomaker.com \ --cc=richard@nod.at \ --cc=rick.tyliu@ingenic.com \ --cc=robh+dt@kernel.org \ --cc=sernia.zhou@foxmail.com \ --cc=tmn505@gmail.com \ --cc=tudor.ambarus@microchip.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.