From: Zhou Yanjie <zhouyanjie@wanyeetech.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, tudor.ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aidanmacdonald.0x0@gmail.com, tmn505@gmail.com, paul@crapouillou.net, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, jinghui.liu@ingenic.com, sernia.zhou@foxmail.com, reimu@sudomaker.com Subject: Re: [PATCH 2/3] dt-bindings: SPI: Add Ingenic SFC bindings. Date: Sun, 24 Jul 2022 00:50:40 +0800 [thread overview] Message-ID: <37062a5d-9da3-fbaf-89bd-776f32be36d9@wanyeetech.com> (raw) In-Reply-To: <487a93c4-3301-aefd-abba-aabf4cb8ec90@linaro.org> Hi Krzysztof, On 2022/7/23 上午1:46, Krzysztof Kozlowski wrote: > On 22/07/2022 18:48, 周琰杰 (Zhou Yanjie) wrote: >> Add the SFC bindings for the X1000 SoC, the X1600 SoC, the X1830 SoC, >> and the X2000 SoC from Ingenic. >> >> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> >> --- >> .../devicetree/bindings/spi/ingenic,sfc.yaml | 64 ++++++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml b/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >> new file mode 100644 >> index 00000000..b7c4cf4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/ingenic,sfc.yaml# > File name should be rather based on first compatible, so > ingenic,x1000-sfc.yaml No offense, does it really need to be named that way? I can't seem to find documentation with instructions on this :( The use of "ingenic,sfc.yaml" indicates that this is the documentation for the SFC module for all Ingenic SoCs, without misleading people into thinking it's only for a specific model of SoC. And there seem to be many other yaml documents that use similar names (eg. fsl,spi-fsl-qspi.yaml, spi-rockchip.yaml, spi-nxp-fspi.yaml, ingenic,spi.yaml, spi-sifive.yaml, omap-spi.yaml), maybe these yaml files that are not named with first compatible are also for the same consideration. :) >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bindings for SFC in Ingenic SoCs >> + >> +maintainers: >> + - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> >> + >> +description: >> + The SPI Flash Controller in Ingenic SoCs. >> + > You miss here allOf referencing spi-controller. Sure, will add it in the next version. >> +properties: >> + compatible: >> + oneOf: >> + - enum: >> + - ingenic,x1000-sfc >> + - ingenic,x1600-sfc >> + - ingenic,x2000-sfc >> + - items: >> + - enum: >> + - ingenic,x1830-sfc >> + - const: ingenic,x1000-sfc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + const: sfc > Remove the clock-names entirely, no benefits. Sure. >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/ingenic,x1000-cgu.h> >> + >> + sfc: spi@13440000 { >> + compatible = "ingenic,x1000-sfc"; > > Use 4 spaces for example indentation. My fault, will fix it in the next version. >> + reg = <0x13440000 0x1000>; >> + >> + interrupt-parent = <&intc>; >> + interrupts = <7>; >> + >> + clocks = <&cgu X1000_CLK_SFC>; >> + clock-names = "sfc"; >> + >> + status = "disabled"; > No status in example. Sure, will remove it in the next version. Thanks and beset regards! > >> + }; >> +... > > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Zhou Yanjie <zhouyanjie@wanyeetech.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, tudor.ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aidanmacdonald.0x0@gmail.com, tmn505@gmail.com, paul@crapouillou.net, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, jinghui.liu@ingenic.com, sernia.zhou@foxmail.com, reimu@sudomaker.com Subject: Re: [PATCH 2/3] dt-bindings: SPI: Add Ingenic SFC bindings. Date: Sun, 24 Jul 2022 00:50:40 +0800 [thread overview] Message-ID: <37062a5d-9da3-fbaf-89bd-776f32be36d9@wanyeetech.com> (raw) In-Reply-To: <487a93c4-3301-aefd-abba-aabf4cb8ec90@linaro.org> Hi Krzysztof, On 2022/7/23 上午1:46, Krzysztof Kozlowski wrote: > On 22/07/2022 18:48, 周琰杰 (Zhou Yanjie) wrote: >> Add the SFC bindings for the X1000 SoC, the X1600 SoC, the X1830 SoC, >> and the X2000 SoC from Ingenic. >> >> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> >> --- >> .../devicetree/bindings/spi/ingenic,sfc.yaml | 64 ++++++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml b/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >> new file mode 100644 >> index 00000000..b7c4cf4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/ingenic,sfc.yaml# > File name should be rather based on first compatible, so > ingenic,x1000-sfc.yaml No offense, does it really need to be named that way? I can't seem to find documentation with instructions on this :( The use of "ingenic,sfc.yaml" indicates that this is the documentation for the SFC module for all Ingenic SoCs, without misleading people into thinking it's only for a specific model of SoC. And there seem to be many other yaml documents that use similar names (eg. fsl,spi-fsl-qspi.yaml, spi-rockchip.yaml, spi-nxp-fspi.yaml, ingenic,spi.yaml, spi-sifive.yaml, omap-spi.yaml), maybe these yaml files that are not named with first compatible are also for the same consideration. :) >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bindings for SFC in Ingenic SoCs >> + >> +maintainers: >> + - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> >> + >> +description: >> + The SPI Flash Controller in Ingenic SoCs. >> + > You miss here allOf referencing spi-controller. Sure, will add it in the next version. >> +properties: >> + compatible: >> + oneOf: >> + - enum: >> + - ingenic,x1000-sfc >> + - ingenic,x1600-sfc >> + - ingenic,x2000-sfc >> + - items: >> + - enum: >> + - ingenic,x1830-sfc >> + - const: ingenic,x1000-sfc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + const: sfc > Remove the clock-names entirely, no benefits. Sure. >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/ingenic,x1000-cgu.h> >> + >> + sfc: spi@13440000 { >> + compatible = "ingenic,x1000-sfc"; > > Use 4 spaces for example indentation. My fault, will fix it in the next version. >> + reg = <0x13440000 0x1000>; >> + >> + interrupt-parent = <&intc>; >> + interrupts = <7>; >> + >> + clocks = <&cgu X1000_CLK_SFC>; >> + clock-names = "sfc"; >> + >> + status = "disabled"; > No status in example. Sure, will remove it in the next version. Thanks and beset regards! > >> + }; >> +... > > Best regards, > Krzysztof ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-23 16:51 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-22 16:48 [PATCH 0/3] Add SFC support for Ingenic SoCs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` [PATCH 1/3] mtd: spi-nor: Use the spi-mem poll status APIs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-23 8:30 ` Sergey Shtylyov 2022-07-23 8:30 ` Sergey Shtylyov 2022-07-22 16:48 ` [PATCH 2/3] dt-bindings: SPI: Add Ingenic SFC bindings 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-22 17:46 ` Krzysztof Kozlowski 2022-07-22 17:46 ` Krzysztof Kozlowski 2022-07-23 16:50 ` Zhou Yanjie [this message] 2022-07-23 16:50 ` Zhou Yanjie 2022-07-23 17:43 ` Krzysztof Kozlowski 2022-07-23 17:43 ` Krzysztof Kozlowski 2022-07-23 18:47 ` Mike Yang 2022-07-23 18:47 ` Mike Yang 2022-07-23 19:27 ` Mark Brown 2022-07-23 19:27 ` Mark Brown 2022-07-23 20:07 ` Krzysztof Kozlowski 2022-07-23 20:07 ` Krzysztof Kozlowski 2022-07-23 20:49 ` Mike Yang 2022-07-23 20:49 ` Mike Yang 2022-07-24 15:33 ` Zhou Yanjie 2022-07-24 15:33 ` Zhou Yanjie 2022-07-25 18:30 ` Rob Herring 2022-07-25 18:30 ` Rob Herring 2022-07-23 20:05 ` Krzysztof Kozlowski 2022-07-23 20:05 ` Krzysztof Kozlowski 2022-07-24 14:52 ` Zhou Yanjie 2022-07-24 14:52 ` Zhou Yanjie 2022-07-22 22:44 ` Rob Herring 2022-07-22 22:44 ` Rob Herring 2022-07-22 16:48 ` [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` 周琰杰 (Zhou Yanjie) 2022-07-22 18:07 ` Krzysztof Kozlowski 2022-07-22 18:07 ` Krzysztof Kozlowski 2022-07-23 16:53 ` Zhou Yanjie 2022-07-23 16:53 ` Zhou Yanjie 2022-07-22 18:38 ` Mark Brown 2022-07-22 18:38 ` Mark Brown 2022-07-23 17:06 ` Zhou Yanjie 2022-07-23 17:06 ` Zhou Yanjie 2022-07-23 19:32 ` Mark Brown 2022-07-23 19:32 ` Mark Brown 2022-07-24 1:24 ` Zhou Yanjie 2022-07-24 1:24 ` Zhou Yanjie 2022-07-22 20:03 ` Paul Cercueil 2022-07-22 20:03 ` Paul Cercueil 2022-07-23 17:26 ` Zhou Yanjie 2022-07-23 17:26 ` Zhou Yanjie 2022-07-23 20:24 ` Paul Cercueil 2022-07-23 20:24 ` Paul Cercueil 2022-07-24 15:29 ` Zhou Yanjie 2022-07-24 15:29 ` Zhou Yanjie 2022-07-23 15:15 ` Christophe JAILLET 2022-07-23 15:15 ` Christophe JAILLET 2022-07-23 15:15 ` Christophe JAILLET 2022-07-24 1:22 ` Zhou Yanjie 2022-07-24 1:22 ` Zhou Yanjie 2022-07-24 0:43 ` kernel test robot 2022-07-24 0:43 ` kernel test robot 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-25 16:58 ` Vanessa Page 2022-07-23 14:47 ` [PATCH 0/3] " Tomasz Maciej Nowak 2022-07-23 14:47 ` Tomasz Maciej Nowak 2022-07-24 1:25 ` Zhou Yanjie 2022-07-24 1:25 ` Zhou Yanjie 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:30 ` Vanessa Page 2022-07-24 1:30 ` Vanessa Page 2022-07-24 1:32 ` Vee Page 2022-07-24 1:32 ` Vee Page 2022-07-26 6:13 ` Vee Page 2022-07-26 6:13 ` Vee Page
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=37062a5d-9da3-fbaf-89bd-776f32be36d9@wanyeetech.com \ --to=zhouyanjie@wanyeetech.com \ --cc=aidanmacdonald.0x0@gmail.com \ --cc=aric.pzqi@ingenic.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dongsheng.qiu@ingenic.com \ --cc=jinghui.liu@ingenic.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=p.yadav@ti.com \ --cc=paul@crapouillou.net \ --cc=reimu@sudomaker.com \ --cc=richard@nod.at \ --cc=rick.tyliu@ingenic.com \ --cc=robh+dt@kernel.org \ --cc=sernia.zhou@foxmail.com \ --cc=tmn505@gmail.com \ --cc=tudor.ambarus@microchip.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.