From: Mark Einon <mark.einon@gmail.com> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Mark Einon <mark.einon@gmail.com> Subject: [PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality Date: Wed, 20 Aug 2014 23:17:51 +0100 [thread overview] Message-ID: <1408573078-9320-2-git-send-email-mark.einon@gmail.com> (raw) In-Reply-To: <1408573078-9320-1-git-send-email-mark.einon@gmail.com> There's already working code to set the mac address, so let's use it. Signed-off-by: Mark Einon <mark.einon@gmail.com> --- drivers/staging/et131x/et131x.c | 53 +---------------------------------------- 1 file changed, 1 insertion(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 831b7c6..ac6700b 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -4468,57 +4468,6 @@ static int et131x_change_mtu(struct net_device *netdev, int new_mtu) return result; } -/* et131x_set_mac_addr - handler to change the MAC address for the device */ -static int et131x_set_mac_addr(struct net_device *netdev, void *new_mac) -{ - int result = 0; - struct et131x_adapter *adapter = netdev_priv(netdev); - struct sockaddr *address = new_mac; - - if (adapter == NULL) - return -ENODEV; - - /* Make sure the requested MAC is valid */ - if (!is_valid_ether_addr(address->sa_data)) - return -EADDRNOTAVAIL; - - et131x_disable_txrx(netdev); - et131x_handle_send_interrupt(adapter); - et131x_handle_recv_interrupt(adapter); - - /* Set the new MAC */ - /* netdev->set_mac_address = &new_mac; */ - - memcpy(netdev->dev_addr, address->sa_data, netdev->addr_len); - - netdev_info(netdev, "Setting MAC address to %pM\n", - netdev->dev_addr); - - /* Free Rx DMA memory */ - et131x_adapter_memory_free(adapter); - - et131x_soft_reset(adapter); - - /* Alloc and init Rx DMA memory */ - result = et131x_adapter_memory_alloc(adapter); - if (result != 0) { - dev_err(&adapter->pdev->dev, - "Change MAC failed; couldn't re-alloc DMA memory\n"); - return result; - } - - et131x_init_send(adapter); - - et131x_hwaddr_init(adapter); - - /* Init the device with the new settings */ - et131x_adapter_setup(adapter); - - et131x_enable_txrx(netdev); - - return result; -} - static const struct net_device_ops et131x_netdev_ops = { .ndo_open = et131x_open, .ndo_stop = et131x_close, @@ -4526,7 +4475,7 @@ static const struct net_device_ops et131x_netdev_ops = { .ndo_set_rx_mode = et131x_multicast, .ndo_tx_timeout = et131x_tx_timeout, .ndo_change_mtu = et131x_change_mtu, - .ndo_set_mac_address = et131x_set_mac_addr, + .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, .ndo_get_stats = et131x_stats, .ndo_do_ioctl = et131x_ioctl, -- 2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: Mark Einon <mark.einon@gmail.com> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Einon <mark.einon@gmail.com> Subject: [PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality Date: Wed, 20 Aug 2014 23:17:51 +0100 [thread overview] Message-ID: <1408573078-9320-2-git-send-email-mark.einon@gmail.com> (raw) In-Reply-To: <1408573078-9320-1-git-send-email-mark.einon@gmail.com> There's already working code to set the mac address, so let's use it. Signed-off-by: Mark Einon <mark.einon@gmail.com> --- drivers/staging/et131x/et131x.c | 53 +---------------------------------------- 1 file changed, 1 insertion(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 831b7c6..ac6700b 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -4468,57 +4468,6 @@ static int et131x_change_mtu(struct net_device *netdev, int new_mtu) return result; } -/* et131x_set_mac_addr - handler to change the MAC address for the device */ -static int et131x_set_mac_addr(struct net_device *netdev, void *new_mac) -{ - int result = 0; - struct et131x_adapter *adapter = netdev_priv(netdev); - struct sockaddr *address = new_mac; - - if (adapter == NULL) - return -ENODEV; - - /* Make sure the requested MAC is valid */ - if (!is_valid_ether_addr(address->sa_data)) - return -EADDRNOTAVAIL; - - et131x_disable_txrx(netdev); - et131x_handle_send_interrupt(adapter); - et131x_handle_recv_interrupt(adapter); - - /* Set the new MAC */ - /* netdev->set_mac_address = &new_mac; */ - - memcpy(netdev->dev_addr, address->sa_data, netdev->addr_len); - - netdev_info(netdev, "Setting MAC address to %pM\n", - netdev->dev_addr); - - /* Free Rx DMA memory */ - et131x_adapter_memory_free(adapter); - - et131x_soft_reset(adapter); - - /* Alloc and init Rx DMA memory */ - result = et131x_adapter_memory_alloc(adapter); - if (result != 0) { - dev_err(&adapter->pdev->dev, - "Change MAC failed; couldn't re-alloc DMA memory\n"); - return result; - } - - et131x_init_send(adapter); - - et131x_hwaddr_init(adapter); - - /* Init the device with the new settings */ - et131x_adapter_setup(adapter); - - et131x_enable_txrx(netdev); - - return result; -} - static const struct net_device_ops et131x_netdev_ops = { .ndo_open = et131x_open, .ndo_stop = et131x_close, @@ -4526,7 +4475,7 @@ static const struct net_device_ops et131x_netdev_ops = { .ndo_set_rx_mode = et131x_multicast, .ndo_tx_timeout = et131x_tx_timeout, .ndo_change_mtu = et131x_change_mtu, - .ndo_set_mac_address = et131x_set_mac_addr, + .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, .ndo_get_stats = et131x_stats, .ndo_do_ioctl = et131x_ioctl, -- 2.1.0
next prev parent reply other threads:[~2014-08-20 22:20 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-20 22:17 [PATCH 0/8] Implement NAPI in et131x Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-20 22:17 ` Mark Einon [this message] 2014-08-20 22:17 ` [PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality Mark Einon 2014-08-20 22:17 ` [PATCH 2/8] staging: et131x: Don't handle rx/tx packets when changing mtu Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-20 22:17 ` [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-30 20:32 ` Greg KH 2014-08-31 14:25 ` Mark Einon 2014-08-31 16:11 ` Greg KH 2014-08-20 22:17 ` [PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat " Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-21 8:40 ` David Laight 2014-08-21 10:05 ` Mark Einon 2014-08-21 10:05 ` Mark Einon 2014-08-20 22:17 ` [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-20 22:22 ` Fabio Estevam 2014-08-20 22:22 ` Fabio Estevam 2014-08-21 9:18 ` Mark Einon 2014-08-21 9:18 ` Mark Einon 2014-08-21 12:06 ` Fabio Estevam 2014-08-21 12:06 ` Fabio Estevam 2014-08-21 14:59 ` Mark Einon 2014-08-21 14:59 ` Mark Einon 2014-08-20 22:17 ` [PATCH 6/8] staging: et131x: Rename NUM_PACKETS_HANDLED to MAX_PACKETS_HANDLED Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-20 22:17 ` [PATCH 7/8] staging: et131x: Fix ET_INTR_TXDMA_ISR register name typo Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-20 22:17 ` [PATCH 8/8] staging: et131x: Implement NAPI support Mark Einon 2014-08-20 22:17 ` Mark Einon 2014-08-21 3:25 ` Stephen Hemminger 2014-08-21 9:23 ` Mark Einon 2014-08-21 9:23 ` Mark Einon 2014-08-21 3:25 ` Stephen Hemminger 2014-08-21 9:25 ` Mark Einon 2014-08-21 9:25 ` Mark Einon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1408573078-9320-2-git-send-email-mark.einon@gmail.com \ --to=mark.einon@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.