From: Mark Einon <mark.einon@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] staging: et131x: Implement NAPI support
Date: Thu, 21 Aug 2014 10:23:05 +0100 [thread overview]
Message-ID: <20140821092302.GB2230@msilap.einon.net> (raw)
In-Reply-To: <20140820202501.558fdb3f@uryu.home.lan>
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon <mark.einon@gmail.com> wrote:
>
> >
> > + if (budget > MAX_PACKETS_HANDLED)
> > + limit = MAX_PACKETS_HANDLED;
>
> Why this artificial restriction?
Hi Stephen, thanks for the review.
It's a restriction that was in the original driver code, and I'm being
cautious. I don't have much documentation for the device, and I haven't
yet figured a way to test the limit so I can play with removing it. If
you have any suggestions on how to do that, I'd be happy to hear them.
Cheers,
Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Einon <mark.einon@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] staging: et131x: Implement NAPI support
Date: Thu, 21 Aug 2014 10:23:05 +0100 [thread overview]
Message-ID: <20140821092302.GB2230@msilap.einon.net> (raw)
In-Reply-To: <20140820202501.558fdb3f@uryu.home.lan>
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon <mark.einon@gmail.com> wrote:
>
> >
> > + if (budget > MAX_PACKETS_HANDLED)
> > + limit = MAX_PACKETS_HANDLED;
>
> Why this artificial restriction?
Hi Stephen, thanks for the review.
It's a restriction that was in the original driver code, and I'm being
cautious. I don't have much documentation for the device, and I haven't
yet figured a way to test the limit so I can play with removing it. If
you have any suggestions on how to do that, I'd be happy to hear them.
Cheers,
Mark
next prev parent reply other threads:[~2014-08-21 9:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 22:17 [PATCH 0/8] Implement NAPI in et131x Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-20 22:17 ` [PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-20 22:17 ` [PATCH 2/8] staging: et131x: Don't handle rx/tx packets when changing mtu Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-20 22:17 ` [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-30 20:32 ` Greg KH
2014-08-31 14:25 ` Mark Einon
2014-08-31 16:11 ` Greg KH
2014-08-20 22:17 ` [PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat " Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-21 8:40 ` David Laight
2014-08-21 10:05 ` Mark Einon
2014-08-21 10:05 ` Mark Einon
2014-08-20 22:17 ` [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-20 22:22 ` Fabio Estevam
2014-08-20 22:22 ` Fabio Estevam
2014-08-21 9:18 ` Mark Einon
2014-08-21 9:18 ` Mark Einon
2014-08-21 12:06 ` Fabio Estevam
2014-08-21 12:06 ` Fabio Estevam
2014-08-21 14:59 ` Mark Einon
2014-08-21 14:59 ` Mark Einon
2014-08-20 22:17 ` [PATCH 6/8] staging: et131x: Rename NUM_PACKETS_HANDLED to MAX_PACKETS_HANDLED Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-20 22:17 ` [PATCH 7/8] staging: et131x: Fix ET_INTR_TXDMA_ISR register name typo Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-20 22:17 ` [PATCH 8/8] staging: et131x: Implement NAPI support Mark Einon
2014-08-20 22:17 ` Mark Einon
2014-08-21 3:25 ` Stephen Hemminger
2014-08-21 9:23 ` Mark Einon [this message]
2014-08-21 9:23 ` Mark Einon
2014-08-21 3:25 ` Stephen Hemminger
2014-08-21 9:25 ` Mark Einon
2014-08-21 9:25 ` Mark Einon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821092302.GB2230@msilap.einon.net \
--to=mark.einon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.