* [PATCH V2 0/2] mfd: twl4030-power: support ti,system-power-controller @ 2014-09-17 12:34 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 12:34 UTC (permalink / raw) To: Lee Jones, Samuel Ortiz Cc: Sebastian Reichel, Tony Lindgren, linux-omap, devicetree, linux-kernel, Nishanth Menon This series adds ti,system-power-controller to Documentation and the driver seperately as per maintainer preference. Based on v3.17-rc1 Changes since V1: update in documentation, picked up Tony's ack for patch #2. V1: http://marc.info/?l=devicetree&m=140977126218800&w=2 Nishanth Menon (2): Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- drivers/mfd/twl4030-power.c | 3 +++ 2 files changed, 10 insertions(+), 2 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH V2 0/2] mfd: twl4030-power: support ti,system-power-controller @ 2014-09-17 12:34 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 12:34 UTC (permalink / raw) To: Lee Jones, Samuel Ortiz Cc: Sebastian Reichel, Tony Lindgren, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Nishanth Menon This series adds ti,system-power-controller to Documentation and the driver seperately as per maintainer preference. Based on v3.17-rc1 Changes since V1: update in documentation, picked up Tony's ack for patch #2. V1: http://marc.info/?l=devicetree&m=140977126218800&w=2 Nishanth Menon (2): Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- drivers/mfd/twl4030-power.c | 3 +++ 2 files changed, 10 insertions(+), 2 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control @ 2014-09-17 12:34 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 12:34 UTC (permalink / raw) To: Lee Jones, Samuel Ortiz Cc: Sebastian Reichel, Tony Lindgren, linux-omap, devicetree, linux-kernel, Nishanth Menon ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm@ti.com> --- V2: picked up documentation suggestion from Sebastien V1: https://patchwork.kernel.org/patch/4836381/ .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..a7390c7 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip will + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control @ 2014-09-17 12:34 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 12:34 UTC (permalink / raw) To: Lee Jones, Samuel Ortiz Cc: Sebastian Reichel, Tony Lindgren, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Nishanth Menon ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> --- V2: picked up documentation suggestion from Sebastien V1: https://patchwork.kernel.org/patch/4836381/ .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..a7390c7 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip will + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 { -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control 2014-09-17 12:34 ` Nishanth Menon (?) @ 2014-09-17 15:44 ` Lee Jones 2014-09-17 16:55 ` Sebastian Reichel -1 siblings, 1 reply; 14+ messages in thread From: Lee Jones @ 2014-09-17 15:44 UTC (permalink / raw) To: Nishanth Menon Cc: Samuel Ortiz, Sebastian Reichel, Tony Lindgren, linux-omap, devicetree, linux-kernel On Wed, 17 Sep 2014, Nishanth Menon wrote: > ti,system-power-controller is more or less the standard way of > indicating that the PMIC is the system wide power controller and hence > may be used to switch off the system. Almost ALL TI PMIC drivers and > many Maxim PMIC drivers follow the same style. > > So support 'ti,system-power-controller' in addition to the usual > 'ti,use_poweroff' to indicate that the PMIC instance has control for > switching off the system. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > > V2: picked up documentation suggestion from Sebastien It would be good to get Sebastian's Ack. > V1: https://patchwork.kernel.org/patch/4836381/ > > .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt > index b9ee7b9..a7390c7 100644 > --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt > +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt > @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards > depending on how the external oscillator is wired. > > Optional properties: > -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or > - SLEEP-to-OFF transition when the system poweroffs. > + > +- ti,system-power-controller: This indicates that TWL4030 is the > + power supply master of the system. With this flag, the chip will > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > + system poweroffs. > + > +- ti,use_poweroff: Deprecated name for ti,system-power-controller > > Example: > &i2c1 { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control 2014-09-17 15:44 ` Lee Jones @ 2014-09-17 16:55 ` Sebastian Reichel 0 siblings, 0 replies; 14+ messages in thread From: Sebastian Reichel @ 2014-09-17 16:55 UTC (permalink / raw) To: Lee Jones Cc: Nishanth Menon, Samuel Ortiz, Tony Lindgren, linux-omap, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1197 bytes --] On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > ti,system-power-controller is more or less the standard way of > > indicating that the PMIC is the system wide power controller and hence > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > many Maxim PMIC drivers follow the same style. > > > > So support 'ti,system-power-controller' in addition to the usual > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > switching off the system. > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > --- > > > > V2: picked up documentation suggestion from Sebastien > > It would be good to get Sebastian's Ack. Acked-By: Sebastian Reichel <sre@kernel.org> [...] > > +- ti,system-power-controller: This indicates that TWL4030 is the > > + power supply master of the system. With this flag, the chip will > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > + system poweroffs. One minor thing: While the documentation is updated you may want to fix the typo "will initiates" to "will initiate" (or just drop the "will"). -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control @ 2014-09-17 16:55 ` Sebastian Reichel 0 siblings, 0 replies; 14+ messages in thread From: Sebastian Reichel @ 2014-09-17 16:55 UTC (permalink / raw) To: Lee Jones Cc: Nishanth Menon, Samuel Ortiz, Tony Lindgren, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1248 bytes --] On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > ti,system-power-controller is more or less the standard way of > > indicating that the PMIC is the system wide power controller and hence > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > many Maxim PMIC drivers follow the same style. > > > > So support 'ti,system-power-controller' in addition to the usual > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > switching off the system. > > > > Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> > > --- > > > > V2: picked up documentation suggestion from Sebastien > > It would be good to get Sebastian's Ack. Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [...] > > +- ti,system-power-controller: This indicates that TWL4030 is the > > + power supply master of the system. With this flag, the chip will > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > + system poweroffs. One minor thing: While the documentation is updated you may want to fix the typo "will initiates" to "will initiate" (or just drop the "will"). -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control @ 2014-09-17 17:01 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 17:01 UTC (permalink / raw) To: Sebastian Reichel, Lee Jones Cc: Lee Jones, Samuel Ortiz, Tony Lindgren, linux-omap, devicetree, linux-kernel On 18:55-20140917, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel <sre@kernel.org> Thanks. > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Updated v3 patch with your ack and correction to drop "will" below. I will assume I wont need to repost the following update. Do let me know if you'd like me to. ---8<--- >From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001 From: Nishanth Menon <nm@ti.com> Date: Wed, 3 Sep 2014 13:55:02 -0500 Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm@ti.com> Acked-By: Sebastian Reichel <sre@kernel.org> --- .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..15a63e6 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 { -- 1.7.9.5 -- Regards, Nishanth Menon ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control @ 2014-09-17 17:01 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 17:01 UTC (permalink / raw) To: Sebastian Reichel Cc: Lee Jones, Samuel Ortiz, Tony Lindgren, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 18:55-20140917, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Thanks. > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Updated v3 patch with your ack and correction to drop "will" below. I will assume I wont need to repost the following update. Do let me know if you'd like me to. ---8<--- >From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001 From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> Date: Wed, 3 Sep 2014 13:55:02 -0500 Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..15a63e6 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 { -- 1.7.9.5 -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control 2014-09-17 16:55 ` Sebastian Reichel (?) (?) @ 2014-09-17 21:39 ` Lee Jones -1 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2014-09-17 21:39 UTC (permalink / raw) To: Sebastian Reichel Cc: Nishanth Menon, Samuel Ortiz, Tony Lindgren, linux-omap, devicetree, linux-kernel On Wed, 17 Sep 2014, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel <sre@kernel.org> > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Applied with Sebastian's Ack and I fixed this up too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off 2014-09-17 12:34 ` Nishanth Menon @ 2014-09-17 12:34 ` Nishanth Menon -1 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 12:34 UTC (permalink / raw) To: Lee Jones, Samuel Ortiz Cc: Sebastian Reichel, Tony Lindgren, linux-omap, devicetree, linux-kernel, Nishanth Menon ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm@ti.com> Acked-by: Tony Lindgren <tony@atomide.com> --- V2: no change, picked up Tony's ack. V1: https://patchwork.kernel.org/patch/4836371/ drivers/mfd/twl4030-power.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 3bc969a..1c129ba 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata, if (pdata && pdata->use_poweroff) return true; + if (of_property_read_bool(node, "ti,system-power-controller")) + return true; + if (of_property_read_bool(node, "ti,use_poweroff")) return true; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off @ 2014-09-17 12:34 ` Nishanth Menon 0 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2014-09-17 12:34 UTC (permalink / raw) To: Lee Jones, Samuel Ortiz Cc: Sebastian Reichel, Tony Lindgren, linux-omap, devicetree, linux-kernel, Nishanth Menon ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm@ti.com> Acked-by: Tony Lindgren <tony@atomide.com> --- V2: no change, picked up Tony's ack. V1: https://patchwork.kernel.org/patch/4836371/ drivers/mfd/twl4030-power.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 3bc969a..1c129ba 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata, if (pdata && pdata->use_poweroff) return true; + if (of_property_read_bool(node, "ti,system-power-controller")) + return true; + if (of_property_read_bool(node, "ti,use_poweroff")) return true; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off @ 2014-09-17 21:39 ` Lee Jones 0 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2014-09-17 21:39 UTC (permalink / raw) To: Nishanth Menon Cc: Samuel Ortiz, Sebastian Reichel, Tony Lindgren, linux-omap, devicetree, linux-kernel On Wed, 17 Sep 2014, Nishanth Menon wrote: > ti,system-power-controller is more or less the standard way of > indicating that the PMIC is the system wide power controller and hence > may be used to switch off the system. Almost ALL TI PMIC drivers and > many Maxim PMIC drivers follow the same style. > > So support 'ti,system-power-controller' in addition to the usual > 'ti,use_poweroff' to indicate that the PMIC instance has control for > switching off the system. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Acked-by: Tony Lindgren <tony@atomide.com> > --- > > V2: no change, picked up Tony's ack. > V1: https://patchwork.kernel.org/patch/4836371/ > drivers/mfd/twl4030-power.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 3bc969a..1c129ba 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata, > if (pdata && pdata->use_poweroff) > return true; > > + if (of_property_read_bool(node, "ti,system-power-controller")) > + return true; > + > if (of_property_read_bool(node, "ti,use_poweroff")) > return true; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off @ 2014-09-17 21:39 ` Lee Jones 0 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2014-09-17 21:39 UTC (permalink / raw) To: Nishanth Menon Cc: Samuel Ortiz, Sebastian Reichel, Tony Lindgren, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Wed, 17 Sep 2014, Nishanth Menon wrote: > ti,system-power-controller is more or less the standard way of > indicating that the PMIC is the system wide power controller and hence > may be used to switch off the system. Almost ALL TI PMIC drivers and > many Maxim PMIC drivers follow the same style. > > So support 'ti,system-power-controller' in addition to the usual > 'ti,use_poweroff' to indicate that the PMIC instance has control for > switching off the system. > > Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> > Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> > --- > > V2: no change, picked up Tony's ack. > V1: https://patchwork.kernel.org/patch/4836371/ > drivers/mfd/twl4030-power.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 3bc969a..1c129ba 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata, > if (pdata && pdata->use_poweroff) > return true; > > + if (of_property_read_bool(node, "ti,system-power-controller")) > + return true; > + > if (of_property_read_bool(node, "ti,use_poweroff")) > return true; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-09-17 21:40 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-09-17 12:34 [PATCH V2 0/2] mfd: twl4030-power: support ti,system-power-controller Nishanth Menon 2014-09-17 12:34 ` Nishanth Menon 2014-09-17 12:34 ` [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Nishanth Menon 2014-09-17 12:34 ` Nishanth Menon 2014-09-17 15:44 ` Lee Jones 2014-09-17 16:55 ` Sebastian Reichel 2014-09-17 16:55 ` Sebastian Reichel 2014-09-17 17:01 ` Nishanth Menon 2014-09-17 17:01 ` Nishanth Menon 2014-09-17 21:39 ` Lee Jones 2014-09-17 12:34 ` [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off Nishanth Menon 2014-09-17 12:34 ` Nishanth Menon 2014-09-17 21:39 ` Lee Jones 2014-09-17 21:39 ` Lee Jones
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.