* [PATCH] Si2168: increase timeout to fix firmware loading
@ 2014-12-08 8:30 Jurgen Kramer
2014-12-08 17:52 ` Antti Palosaari
0 siblings, 1 reply; 6+ messages in thread
From: Jurgen Kramer @ 2014-12-08 8:30 UTC (permalink / raw)
To: linux-media; +Cc: Jurgen Kramer
Increase si2168 cmd execute timeout to prevent firmware load failures. Tests
shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware.
Increase timeout to a safe value of 70ms.
Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
---
drivers/media/dvb-frontends/si2168.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index ce9ab44..d2f1a3e 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd)
if (cmd->rlen) {
/* wait cmd execution terminate */
- #define TIMEOUT 50
+ #define TIMEOUT 70
timeout = jiffies + msecs_to_jiffies(TIMEOUT);
while (!time_after(jiffies, timeout)) {
ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Si2168: increase timeout to fix firmware loading
2014-12-08 8:30 [PATCH] Si2168: increase timeout to fix firmware loading Jurgen Kramer
@ 2014-12-08 17:52 ` Antti Palosaari
2014-12-14 11:29 ` Antti Palosaari
0 siblings, 1 reply; 6+ messages in thread
From: Antti Palosaari @ 2014-12-08 17:52 UTC (permalink / raw)
To: Jurgen Kramer, linux-media; +Cc: Olli Salonen
On 12/08/2014 10:30 AM, Jurgen Kramer wrote:
> Increase si2168 cmd execute timeout to prevent firmware load failures. Tests
> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware.
> Increase timeout to a safe value of 70ms.
>
> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Cc: <stable@vger.kernel.org> # v3.17+
That must go stable 3.17.
Antti
> ---
> drivers/media/dvb-frontends/si2168.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index ce9ab44..d2f1a3e 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd)
>
> if (cmd->rlen) {
> /* wait cmd execution terminate */
> - #define TIMEOUT 50
> + #define TIMEOUT 70
> timeout = jiffies + msecs_to_jiffies(TIMEOUT);
> while (!time_after(jiffies, timeout)) {
> ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Si2168: increase timeout to fix firmware loading
2014-12-08 17:52 ` Antti Palosaari
@ 2014-12-14 11:29 ` Antti Palosaari
2015-01-22 10:04 ` Antti Palosaari
0 siblings, 1 reply; 6+ messages in thread
From: Antti Palosaari @ 2014-12-14 11:29 UTC (permalink / raw)
To: Jurgen Kramer, linux-media; +Cc: Olli Salonen
On 12/08/2014 07:52 PM, Antti Palosaari wrote:
> On 12/08/2014 10:30 AM, Jurgen Kramer wrote:
>> Increase si2168 cmd execute timeout to prevent firmware load failures.
>> Tests
>> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'
>> firmware.
>> Increase timeout to a safe value of 70ms.
>>
>> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
> Reviewed-by: Antti Palosaari <crope@iki.fi>
> Cc: <stable@vger.kernel.org> # v3.17+
Cc: <stable@vger.kernel.org> # v3.16+
Changed from stable 3.17+ to 3.16+ as I found that PCTV 292e timeouts
too when tuning DVB-T2, not always, but from time to time...
Antti
>
> That must go stable 3.17.
>
> Antti
>
>> ---
>> drivers/media/dvb-frontends/si2168.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/dvb-frontends/si2168.c
>> b/drivers/media/dvb-frontends/si2168.c
>> index ce9ab44..d2f1a3e 100644
>> --- a/drivers/media/dvb-frontends/si2168.c
>> +++ b/drivers/media/dvb-frontends/si2168.c
>> @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s,
>> struct si2168_cmd *cmd)
>>
>> if (cmd->rlen) {
>> /* wait cmd execution terminate */
>> - #define TIMEOUT 50
>> + #define TIMEOUT 70
>> timeout = jiffies + msecs_to_jiffies(TIMEOUT);
>> while (!time_after(jiffies, timeout)) {
>> ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
>>
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Si2168: increase timeout to fix firmware loading
2014-12-14 11:29 ` Antti Palosaari
@ 2015-01-22 10:04 ` Antti Palosaari
2015-01-22 13:37 ` Jurgen Kramer
0 siblings, 1 reply; 6+ messages in thread
From: Antti Palosaari @ 2015-01-22 10:04 UTC (permalink / raw)
To: Jurgen Kramer, linux-media; +Cc: Olli Salonen
I will make pull request for that as that is still on patchwork.... :(
Antti
On 12/14/2014 01:29 PM, Antti Palosaari wrote:
> On 12/08/2014 07:52 PM, Antti Palosaari wrote:
>> On 12/08/2014 10:30 AM, Jurgen Kramer wrote:
>>> Increase si2168 cmd execute timeout to prevent firmware load failures.
>>> Tests
>>> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'
>>> firmware.
>>> Increase timeout to a safe value of 70ms.
>>>
>>> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
>> Reviewed-by: Antti Palosaari <crope@iki.fi>
>> Cc: <stable@vger.kernel.org> # v3.17+
>
> Cc: <stable@vger.kernel.org> # v3.16+
>
> Changed from stable 3.17+ to 3.16+ as I found that PCTV 292e timeouts
> too when tuning DVB-T2, not always, but from time to time...
>
> Antti
>
>>
>> That must go stable 3.17.
>>
>> Antti
>>
>>> ---
>>> drivers/media/dvb-frontends/si2168.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/dvb-frontends/si2168.c
>>> b/drivers/media/dvb-frontends/si2168.c
>>> index ce9ab44..d2f1a3e 100644
>>> --- a/drivers/media/dvb-frontends/si2168.c
>>> +++ b/drivers/media/dvb-frontends/si2168.c
>>> @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s,
>>> struct si2168_cmd *cmd)
>>>
>>> if (cmd->rlen) {
>>> /* wait cmd execution terminate */
>>> - #define TIMEOUT 50
>>> + #define TIMEOUT 70
>>> timeout = jiffies + msecs_to_jiffies(TIMEOUT);
>>> while (!time_after(jiffies, timeout)) {
>>> ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
>>>
>>
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Si2168: increase timeout to fix firmware loading
2015-01-22 10:04 ` Antti Palosaari
@ 2015-01-22 13:37 ` Jurgen Kramer
0 siblings, 0 replies; 6+ messages in thread
From: Jurgen Kramer @ 2015-01-22 13:37 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media, Olli Salonen
On Thu, 2015-01-22 at 12:04 +0200, Antti Palosaari wrote:
> I will make pull request for that as that is still on patchwork.... :(
Thanks, I was about to send in a resend.
Jurgen
> Antti
>
> On 12/14/2014 01:29 PM, Antti Palosaari wrote:
> > On 12/08/2014 07:52 PM, Antti Palosaari wrote:
> >> On 12/08/2014 10:30 AM, Jurgen Kramer wrote:
> >>> Increase si2168 cmd execute timeout to prevent firmware load failures.
> >>> Tests
> >>> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'
> >>> firmware.
> >>> Increase timeout to a safe value of 70ms.
> >>>
> >>> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
> >> Reviewed-by: Antti Palosaari <crope@iki.fi>
> >> Cc: <stable@vger.kernel.org> # v3.17+
> >
> > Cc: <stable@vger.kernel.org> # v3.16+
> >
> > Changed from stable 3.17+ to 3.16+ as I found that PCTV 292e timeouts
> > too when tuning DVB-T2, not always, but from time to time...
> >
> > Antti
> >
> >>
> >> That must go stable 3.17.
> >>
> >> Antti
> >>
> >>> ---
> >>> drivers/media/dvb-frontends/si2168.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/media/dvb-frontends/si2168.c
> >>> b/drivers/media/dvb-frontends/si2168.c
> >>> index ce9ab44..d2f1a3e 100644
> >>> --- a/drivers/media/dvb-frontends/si2168.c
> >>> +++ b/drivers/media/dvb-frontends/si2168.c
> >>> @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s,
> >>> struct si2168_cmd *cmd)
> >>>
> >>> if (cmd->rlen) {
> >>> /* wait cmd execution terminate */
> >>> - #define TIMEOUT 50
> >>> + #define TIMEOUT 70
> >>> timeout = jiffies + msecs_to_jiffies(TIMEOUT);
> >>> while (!time_after(jiffies, timeout)) {
> >>> ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
> >>>
> >>
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Si2168: increase timeout to fix firmware loading
@ 2015-02-26 21:28 Antti Palosaari
0 siblings, 0 replies; 6+ messages in thread
From: Antti Palosaari @ 2015-02-26 21:28 UTC (permalink / raw)
To: linux-media; +Cc: Jurgen Kramer, stable
From: Jurgen Kramer <gtmkramer@xs4all.nl>
Increase si2168 cmd execute timeout to prevent firmware load failures. Tests
shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware.
Increase timeout to a safe value of 70ms.
Cc: <stable@vger.kernel.org> # v3.16+
Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
Reviewed-by: Antti Palosaari <crope@iki.fi>
---
Patch for stable 3.16+
That patch is already applied to master as commit 551c33e729f654ecfaed00ad399f5d2a631b72cb
There was some mistake and Cc stable tag I added to patchwork [1] was lost.
[1] https://patchwork.linuxtv.org/patch/27382/
---
drivers/media/dvb-frontends/si2168.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 2e3cdcf..fbc1fa8 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd)
if (cmd->rlen) {
/* wait cmd execution terminate */
- #define TIMEOUT 50
+ #define TIMEOUT 70
timeout = jiffies + msecs_to_jiffies(TIMEOUT);
while (!time_after(jiffies, timeout)) {
ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
--
http://palosaari.fi/
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-26 21:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-08 8:30 [PATCH] Si2168: increase timeout to fix firmware loading Jurgen Kramer
2014-12-08 17:52 ` Antti Palosaari
2014-12-14 11:29 ` Antti Palosaari
2015-01-22 10:04 ` Antti Palosaari
2015-01-22 13:37 ` Jurgen Kramer
2015-02-26 21:28 Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.